Coverity-found bug: don't use temp->next *before* checking it for NULL. Also

return rather than use it again.

Coverity-found bug: don't use temp->next before checking it for NULL. Also
return rather than use it again.
47f003d3 · Thomas Wouters · 622927b8 · 47f003d3
Kaydet (Commit) 47f003d3 authored Mar 07, 2006 tarafından Thomas Wouters
Show whitespace changes
Inline Side-by-side

Showing with 4 additions and 2 deletions

_curses_panel.c Modules/_curses_panel.c +4 -2

No files found.
--- a/Modules/_curses_panel.c
+++ b/Modules/_curses_panel.c
@@ -111,10 +111,12 @@ remove_lop(PyCursesPanelObject *po)
 	free(temp);
 	return;
    }
-    while (temp->next->po != po) {
+    while (temp->next == NULL || temp->next->po != po) {
-	if (temp->next == NULL)
+	if (temp->next == NULL) {
 	    PyErr_SetString(PyExc_RuntimeError,
 			    "remove_lop: can't find Panel Object");
+	    return;
+	}
 	temp = temp->next;
    }
    n = temp->next->next;