Kaydet (Commit) 742206d9 authored tarafından Serhiy Storchaka's avatar Serhiy Storchaka

Issue #27063: Some unittest loader tests were silently skipped.

...@@ -8,7 +8,7 @@ import unittest ...@@ -8,7 +8,7 @@ import unittest
# test isolation and reproducibility. # test isolation and reproducibility.
def warningregistry(func): def warningregistry(func):
def wrapper(*args, **kws): def wrapper(*args, **kws):
missing = object() missing = []
saved = getattr(warnings, '__warningregistry__', missing).copy() saved = getattr(warnings, '__warningregistry__', missing).copy()
try: try:
return func(*args, **kws) return func(*args, **kws)
...@@ -20,6 +20,7 @@ def warningregistry(func): ...@@ -20,6 +20,7 @@ def warningregistry(func):
pass pass
else: else:
warnings.__warningregistry__ = saved warnings.__warningregistry__ = saved
return wrapper
class Test_TestLoader(unittest.TestCase): class Test_TestLoader(unittest.TestCase):
...@@ -197,7 +198,7 @@ class Test_TestLoader(unittest.TestCase): ...@@ -197,7 +198,7 @@ class Test_TestLoader(unittest.TestCase):
# ignored (and deprecated). # ignored (and deprecated).
load_tests_args = [] load_tests_args = []
with warnings.catch_warnings(record=False): with warnings.catch_warnings(record=False):
warnings.simplefilter('never') warnings.simplefilter('ignore')
suite = loader.loadTestsFromModule(m, use_load_tests=False) suite = loader.loadTestsFromModule(m, use_load_tests=False)
self.assertEqual(load_tests_args, [loader, suite, None]) self.assertEqual(load_tests_args, [loader, suite, None])
...@@ -274,7 +275,8 @@ class Test_TestLoader(unittest.TestCase): ...@@ -274,7 +275,8 @@ class Test_TestLoader(unittest.TestCase):
m.load_tests = load_tests m.load_tests = load_tests
loader = unittest.TestLoader() loader = unittest.TestLoader()
with self.assertRaises(TypeError) as cm, \ with self.assertRaises(TypeError) as cm, \
warnings.catch_warning(record=True) as w: warnings.catch_warnings(record=True) as w:
warnings.simplefilter('always')
loader.loadTestsFromModule(m, False, 'testme.*') loader.loadTestsFromModule(m, False, 'testme.*')
# We still got the deprecation warning. # We still got the deprecation warning.
self.assertIs(w[-1].category, DeprecationWarning) self.assertIs(w[-1].category, DeprecationWarning)
...@@ -302,7 +304,7 @@ class Test_TestLoader(unittest.TestCase): ...@@ -302,7 +304,7 @@ class Test_TestLoader(unittest.TestCase):
m.load_tests = load_tests m.load_tests = load_tests
loader = unittest.TestLoader() loader = unittest.TestLoader()
with warnings.catch_warnings(): with warnings.catch_warnings():
warnings.simplefilter('never') warnings.simplefilter('ignore')
with self.assertRaises(TypeError) as cm: with self.assertRaises(TypeError) as cm:
loader.loadTestsFromModule( loader.loadTestsFromModule(
m, use_load_tests=False, very_bad=True, worse=False) m, use_load_tests=False, very_bad=True, worse=False)
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment