Kaydet (Commit) c211a0a0 authored tarafından Georg Brandl's avatar Georg Brandl

#1782: don't leak in error case in PyModule_AddXxxConstant. Patch by Hrvoje Nikšić.

üst 6ebc5274
...@@ -621,11 +621,23 @@ PyModule_AddObject(PyObject *m, const char *name, PyObject *o) ...@@ -621,11 +621,23 @@ PyModule_AddObject(PyObject *m, const char *name, PyObject *o)
int int
PyModule_AddIntConstant(PyObject *m, const char *name, long value) PyModule_AddIntConstant(PyObject *m, const char *name, long value)
{ {
return PyModule_AddObject(m, name, PyInt_FromLong(value)); PyObject *o = PyInt_FromLong(value);
if (!o)
return -1;
if (PyModule_AddObject(m, name, o) == 0)
return 0;
Py_DECREF(o);
return -1;
} }
int int
PyModule_AddStringConstant(PyObject *m, const char *name, const char *value) PyModule_AddStringConstant(PyObject *m, const char *name, const char *value)
{ {
return PyModule_AddObject(m, name, PyString_FromString(value)); PyObject *o = PyString_FromString(value);
if (!o)
return -1;
if (PyModule_AddObject(m, name, o) == 0)
return 0;
Py_DECREF(o);
return -1;
} }
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment