#5932: fix error return in _convertPyInt_AsSsize_t() conversion function.

Lib/json/tests/test_scanstring.py

@@ -107,3 +107,6 @@ class TestScanString(TestCase):
                           "xxx")
         self.assertRaises(UnicodeDecodeError,
                           json.encoder.encode_basestring_ascii, b"xx\xff")
+
+    def test_overflow(self):
+        self.assertRaises(OverflowError, json.decoder.scanstring, b"xxx", sys.maxsize+1)

Modules/_json.c

@@ -143,9 +143,9 @@ _convertPyInt_AsSsize_t(PyObject *o, Py_ssize_t *size_ptr)
 {
     /* PyObject to Py_ssize_t converter */
     *size_ptr = PyInt_AsSsize_t(o);
-    if (*size_ptr == -1 && PyErr_Occurred());
-        return 1;
+    if (*size_ptr == -1 && PyErr_Occurred())
         return 0;
+    return 1;
 }
 
 static PyObject *