Kaydet (Commit) 0b6a1f2a authored tarafından PriyankaGaikwad's avatar PriyankaGaikwad Kaydeden (comit) Caolán McNamara

fdo#75200:Libreoffice crash while opening the file

Conflicts:
	chart2/qa/extras/chart2import.cxx

Change-Id: Icb2a5bc43ef5fd0f307b43bbe8aaf892a043dc5b
Reviewed-on: https://gerrit.libreoffice.org/8127Reviewed-by: 's avatarCaolán McNamara <caolanm@redhat.com>
Tested-by: 's avatarCaolán McNamara <caolanm@redhat.com>
üst e059218a
...@@ -34,6 +34,7 @@ public: ...@@ -34,6 +34,7 @@ public:
void testPPTChartSeries(); void testPPTChartSeries();
void testODPChartSeries(); void testODPChartSeries();
void testBnc864396(); void testBnc864396();
void testChartFileOpen();
CPPUNIT_TEST_SUITE(Chart2ImportTest); CPPUNIT_TEST_SUITE(Chart2ImportTest);
CPPUNIT_TEST(Fdo60083); CPPUNIT_TEST(Fdo60083);
...@@ -45,6 +46,7 @@ public: ...@@ -45,6 +46,7 @@ public:
CPPUNIT_TEST(testODTChartSeries); CPPUNIT_TEST(testODTChartSeries);
CPPUNIT_TEST(testDOCChartSeries); CPPUNIT_TEST(testDOCChartSeries);
CPPUNIT_TEST(testDOCXChartSeries); CPPUNIT_TEST(testDOCXChartSeries);
CPPUNIT_TEST(testChartFileOpen);
/* /*
* Disabling Impress Uts. * Disabling Impress Uts.
* ChartTest::tearDown() calls dispose of mxComponent * ChartTest::tearDown() calls dispose of mxComponent
...@@ -260,7 +262,6 @@ void Chart2ImportTest::testPPTChartSeries() ...@@ -260,7 +262,6 @@ void Chart2ImportTest::testPPTChartSeries()
CPPUNIT_ASSERT_EQUAL(OUString("Column 1"), seriesList[0]); CPPUNIT_ASSERT_EQUAL(OUString("Column 1"), seriesList[0]);
CPPUNIT_ASSERT_EQUAL(OUString("Column 2"), seriesList[1]); CPPUNIT_ASSERT_EQUAL(OUString("Column 2"), seriesList[1]);
CPPUNIT_ASSERT_EQUAL(OUString("Column 3"), seriesList[2]); CPPUNIT_ASSERT_EQUAL(OUString("Column 3"), seriesList[2]);
} }
void Chart2ImportTest::testPPTXChartSeries() void Chart2ImportTest::testPPTXChartSeries()
...@@ -270,7 +271,6 @@ void Chart2ImportTest::testPPTXChartSeries() ...@@ -270,7 +271,6 @@ void Chart2ImportTest::testPPTXChartSeries()
CPPUNIT_ASSERT_EQUAL(OUString("Column 1"), seriesList[1]); CPPUNIT_ASSERT_EQUAL(OUString("Column 1"), seriesList[1]);
CPPUNIT_ASSERT_EQUAL(OUString("Column 2"), seriesList[2]); CPPUNIT_ASSERT_EQUAL(OUString("Column 2"), seriesList[2]);
CPPUNIT_ASSERT_EQUAL(OUString("Column 3"), seriesList[3]); CPPUNIT_ASSERT_EQUAL(OUString("Column 3"), seriesList[3]);
} }
void Chart2ImportTest::testODPChartSeries() void Chart2ImportTest::testODPChartSeries()
...@@ -280,7 +280,6 @@ void Chart2ImportTest::testODPChartSeries() ...@@ -280,7 +280,6 @@ void Chart2ImportTest::testODPChartSeries()
CPPUNIT_ASSERT_EQUAL(OUString("Column 1"), seriesList[0]); CPPUNIT_ASSERT_EQUAL(OUString("Column 1"), seriesList[0]);
CPPUNIT_ASSERT_EQUAL(OUString("Column 2"), seriesList[1]); CPPUNIT_ASSERT_EQUAL(OUString("Column 2"), seriesList[1]);
CPPUNIT_ASSERT_EQUAL(OUString("Column 3"), seriesList[2]); CPPUNIT_ASSERT_EQUAL(OUString("Column 3"), seriesList[2]);
} }
void Chart2ImportTest::testBnc864396() void Chart2ImportTest::testBnc864396()
...@@ -298,6 +297,11 @@ void Chart2ImportTest::testBnc864396() ...@@ -298,6 +297,11 @@ void Chart2ImportTest::testBnc864396()
} }
} }
void Chart2ImportTest::testChartFileOpen()
{
load("/chart2/qa/extras/data/docx/", "barChart.docx");
}
CPPUNIT_TEST_SUITE_REGISTRATION(Chart2ImportTest); CPPUNIT_TEST_SUITE_REGISTRATION(Chart2ImportTest);
CPPUNIT_PLUGIN_IMPLEMENT(); CPPUNIT_PLUGIN_IMPLEMENT();
......
...@@ -243,10 +243,13 @@ void PropertyMap::fillSequences( Sequence< OUString >& rNames, Sequence< Any >& ...@@ -243,10 +243,13 @@ void PropertyMap::fillSequences( Sequence< OUString >& rNames, Sequence< Any >&
for( const_iterator aIt = begin(), aEnd = end(); aIt != aEnd; ++aIt, ++pNames, ++pValues ) for( const_iterator aIt = begin(), aEnd = end(); aIt != aEnd; ++aIt, ++pNames, ++pValues )
{ {
OSL_ENSURE( (0 <= aIt->first) && (aIt->first < PROP_COUNT), "PropertyMap::fillSequences - invalid property identifier" ); OSL_ENSURE( (0 <= aIt->first) && (aIt->first < PROP_COUNT), "PropertyMap::fillSequences - invalid property identifier" );
if((sal_uInt32)aIt->first <= mpPropNames->size())
{
*pNames = (*mpPropNames)[ aIt->first ]; *pNames = (*mpPropNames)[ aIt->first ];
*pValues = aIt->second; *pValues = aIt->second;
} }
} }
}
} }
Reference< XPropertySet > PropertyMap::makePropertySet() const Reference< XPropertySet > PropertyMap::makePropertySet() const
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment