loplugin:countusersofdefaultparams in xmloff

Change-Id: Ia92a878ac97b3cc668594946e77a718f27a3e3ed
Reviewed-on: https://gerrit.libreoffice.org/28890Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

include/xmloff/XMLShapeStyleContext.hxx

@@ -49,7 +49,7 @@ public:
         const OUString& rLName,
         const css::uno::Reference< css::xml::sax::XAttributeList >& xAttrList,
         SvXMLStylesContext& rStyles,
-        sal_uInt16 nFamily = XML_STYLE_FAMILY_SD_GRAPHICS_ID);
+        sal_uInt16 nFamily);
     virtual ~XMLShapeStyleContext() override;
 
     SvXMLImportContext * CreateChildContext(

include/xmloff/numehelp.hxx

@@ -83,7 +83,7 @@ public:
                                 const sal_Int16 nTypeKey,
                                 const double& rValue,
                                 const OUString& rCurrencySymbol,
-                                bool bExportValue = true);
+                                bool bExportValue);
     static bool GetCurrencySymbol(const sal_Int32 nNumberFormat, OUString& rCurrencySymbol,
         css::uno::Reference< css::util::XNumberFormatsSupplier > & xNumberFormatsSupplier);
     static sal_Int16 GetCellType(const sal_Int32 nNumberFormat, bool& bIsStandard,
@@ -95,7 +95,7 @@ public:
     static void SetNumberFormatAttributes(SvXMLExport& rXMLExport,
                                           const OUString& rValue,
                                           const OUString& rCharacters,
-                                          bool bExportValue = true,
+                                          bool bExportValue,
                                           bool bExportTypeAttribute = true);
 
     bool GetCurrencySymbol(const sal_Int32 nNumberFormat, OUString& rCurrencySymbol);
@@ -103,7 +103,7 @@ public:
     void WriteAttributes(const sal_Int16 nTypeKey,
                                           const double& rValue,
                                           const OUString& rCurrencySymbol,
-                                          bool bExportValue = true, sal_uInt16 nNamespace = XML_NAMESPACE_OFFICE);
+                                          bool bExportValue, sal_uInt16 nNamespace = XML_NAMESPACE_OFFICE);
     void SetNumberFormatAttributes(const sal_Int32 nNumberFormat,
                                           const double& rValue,
                                           bool bExportValue = true,

include/xmloff/prstylei.hxx

@@ -94,7 +94,7 @@ public:
     XMLPropStyleContext( SvXMLImport& rImport, sal_uInt16 nPrfx,
             const OUString& rLName,
             const css::uno::Reference< css::xml::sax::XAttributeList > & xAttrList,
-            SvXMLStylesContext& rStyles, sal_uInt16 nFamily = 0,
+            SvXMLStylesContext& rStyles, sal_uInt16 nFamily,
             bool bDefaultStyle=false );
     virtual ~XMLPropStyleContext() override;
 

include/xmloff/xmlexp.hxx

@@ -270,8 +270,8 @@ public:
         sal_Int16 const eDefaultMeasureUnit /*css::util::MeasureUnit*/,
         const css::uno::Reference< css::uno::XComponentContext >& xContext,
         OUString const & implementationName,
-        const enum ::xmloff::token::XMLTokenEnum eClass = xmloff::token::XML_TOKEN_INVALID,
-        SvXMLExportFlags nExportFlag = SvXMLExportFlags::ALL );
+        const enum ::xmloff::token::XMLTokenEnum eClass,
+        SvXMLExportFlags nExportFlag );
 
     SvXMLExport(
         const css::uno::Reference< css::uno::XComponentContext >& xContext,

include/xmloff/xmlexppr.hxx

@@ -89,7 +89,7 @@ protected:
                      const SvXMLNamespaceMap& rNamespaceMap,
                      SvXmlExportFlags nFlags,
                      const ::std::vector< XMLPropertyState > *pProperties,
-                     sal_uInt32 nIdx = 0 ) const;
+                     sal_uInt32 nIdx ) const;
 
     void exportElementItems(
             SvXMLExport& rExport,
@@ -154,7 +154,7 @@ public:
             const XMLPropertyState& rProperty,
             SvXmlExportFlags nFlags,
             const ::std::vector< XMLPropertyState > *pProperties,
-            sal_uInt32 nIdx = 0 ) const;
+            sal_uInt32 nIdx ) const;
 
     /** this method is called for every item that has the
         MID_FLAG_SPECIAL_ITEM_EXPORT flag set */
@@ -164,7 +164,7 @@ public:
             const SvXMLUnitConverter& rUnitConverter,
             const SvXMLNamespaceMap& rNamespaceMap,
             const ::std::vector< XMLPropertyState > *pProperties,
-            sal_uInt32 nIdx = 0 ) const;
+            sal_uInt32 nIdx ) const;
 
     const rtl::Reference<XMLPropertySetMapper>& getPropertySetMapper() const;
 

sc/source/filter/xml/xmlstyle.hxx

@@ -119,7 +119,7 @@ public:
             const XMLPropertyState& rProperty,
             SvXmlExportFlags nFlags,
             const ::std::vector< XMLPropertyState > *pProperties,
-            sal_uInt32 nIdx = 0 ) const override;
+            sal_uInt32 nIdx ) const override;
 
     /** this method is called for every item that has the MID_FLAG_SPECIAL_ITEM_EXPORT flag set */
     virtual void handleSpecialItem(
@@ -128,7 +128,7 @@ public:
             const SvXMLUnitConverter& rUnitConverter,
             const SvXMLNamespaceMap& rNamespaceMap,
             const ::std::vector< XMLPropertyState > *pProperties,
-            sal_uInt32 nIdx = 0 ) const override;
+            sal_uInt32 nIdx ) const override;
 };
 
 class ScXMLRowExportPropertyMapper : public SvXMLExportPropertyMapper
@@ -159,7 +159,7 @@ public:
             const SvXMLUnitConverter& rUnitConverter,
             const SvXMLNamespaceMap& rNamespaceMap,
             const ::std::vector< XMLPropertyState > *pProperties,
-            sal_uInt32 nIdx = 0 ) const override;
+            sal_uInt32 nIdx ) const override;
 };
 
 class ScXMLTableExportPropertyMapper : public SvXMLExportPropertyMapper
@@ -177,7 +177,7 @@ public:
             const SvXMLUnitConverter& rUnitConverter,
             const SvXMLNamespaceMap& rNamespaceMap,
             const ::std::vector< XMLPropertyState > *pProperties,
-            sal_uInt32 nIdx = 0 ) const override;
+            sal_uInt32 nIdx ) const override;
 };
 
 class ScXMLAutoStylePoolP : public SvXMLAutoStylePoolP

writerfilter/source/dmapper/PropertyMap.hxx

@@ -94,7 +94,7 @@ class PropValue
     GrabBagType m_GrabBagType;
 
 public:
-    PropValue(const css::uno::Any& rValue, GrabBagType i_GrabBagType = NO_GRAB_BAG) :
+    PropValue(const css::uno::Any& rValue, GrabBagType i_GrabBagType) :
         m_aValue(rValue), m_GrabBagType(i_GrabBagType) {}
 
     PropValue() : m_aValue(), m_GrabBagType(NO_GRAB_BAG) {}

xmlhelp/source/cxxhelp/inc/tvread.hxx

@@ -166,7 +166,7 @@ namespace treeview {
         friend class TVChildTarget;
 
     public:
-        TVRead( const ConfigData& configData,TVDom* tvDom = nullptr );
+        TVRead( const ConfigData& configData, TVDom* tvDom );
 
         virtual ~TVRead() override;
 

xmlhelp/source/cxxhelp/provider/urlparameter.cxx

@@ -320,7 +320,7 @@ public:
 
     InputStreamTransformer( URLParameter* urlParam,
                             Databases*    pDatatabases,
-                            bool isRoot = false );
+                            bool isRoot );
 
     virtual ~InputStreamTransformer() override;
 

xmloff/inc/PageMasterImportContext.hxx

@@ -44,7 +44,7 @@ public:
             const OUString& rLName,
             const css::uno::Reference< css::xml::sax::XAttributeList > & xAttrList,
             SvXMLStylesContext& rStyles,
-            bool bDefaultStyle=false);
+            bool bDefaultStyle);
     virtual ~PageStyleContext() override;
 
     virtual SvXMLImportContext *CreateChildContext(

xmloff/inc/SchXMLExport.hxx

@@ -53,7 +53,7 @@ public:
     SchXMLExport(
         const css::uno::Reference< css::uno::XComponentContext >& xContext,
         OUString const & implementationName,
-        SvXMLExportFlags nExportFlags = SvXMLExportFlags::ALL );
+        SvXMLExportFlags nExportFlags );
     virtual ~SchXMLExport() override;
 
     rtl::Reference< XMLPropertySetMapper > GetPropertySetMapper() const;

xmloff/inc/XMLChartPropertySetMapper.hxx

@@ -60,14 +60,14 @@ private:
         SvXMLExport& rExport,
         const XMLPropertyState& rProperty, SvXmlExportFlags nFlags,
         const ::std::vector< XMLPropertyState > *pProperties,
-        sal_uInt32 nIdx = 0  ) const override;
+        sal_uInt32 nIdx  ) const override;
 
     /// this method is called for every item that has the MID_FLAG_SPECIAL_ITEM_EXPORT flag set
     virtual void handleSpecialItem(
         SvXMLAttributeList& rAttrList, const XMLPropertyState& rProperty,
         const SvXMLUnitConverter& rUnitConverter, const SvXMLNamespaceMap& rNamespaceMap,
         const ::std::vector< XMLPropertyState > *pProperties,
-        sal_uInt32 nIdx = 0  ) const override;
+        sal_uInt32 nIdx  ) const override;
 
 public:
     XMLChartExportPropertyMapper( const rtl::Reference< XMLPropertySetMapper >& rMapper,

xmloff/inc/txtflde.hxx

@@ -163,7 +163,7 @@ public:
 
     XMLTextFieldExport( SvXMLExport& rExp,
                         /// XMLPropertyState for the combined characters field
-                        XMLPropertyState* pCombinedCharState = nullptr );
+                        XMLPropertyState* pCombinedCharState );
     virtual ~XMLTextFieldExport();
 
     /// Export this field and the surrounding span element with the formatting.

xmloff/inc/xexptran.hxx

@@ -98,7 +98,7 @@ class SdXMLImExViewBox
     double   mfH;
 
 public:
-    SdXMLImExViewBox(double fX = 0.0, double fY = 0.0, double fW = 1000.0, double fH = 1000.0);
+    SdXMLImExViewBox(double fX, double fY, double fW, double fH);
     SdXMLImExViewBox(const OUString& rNew, const SvXMLUnitConverter& rConv);
 
     double GetX() const { return mfX; }

xmloff/source/draw/sdpropls.hxx

@@ -93,7 +93,7 @@ public:
                             const XMLPropertyState& rProperty,
                             SvXmlExportFlags nFlags,
                             const ::std::vector< XMLPropertyState >* pProperties,
-                            sal_uInt32 nIdx = 0
+                            sal_uInt32 nIdx
                             ) const override;
 
     void SetAutoStyles( bool bIsInAutoStyles ) { mbIsInAutoStyles = bIsInAutoStyles; }
@@ -104,7 +104,7 @@ public:
             const SvXMLUnitConverter& rUnitConverter,
             const SvXMLNamespaceMap& rNamespaceMap,
             const ::std::vector< XMLPropertyState > *pProperties,
-            sal_uInt32 nIdx = 0 ) const override;
+            sal_uInt32 nIdx ) const override;
 };
 
 class XMLPageExportPropertyMapper : public SvXMLExportPropertyMapper
@@ -126,7 +126,7 @@ public:
                             const XMLPropertyState& rProperty,
                             SvXmlExportFlags nFlags,
                             const ::std::vector< XMLPropertyState >* pProperties,
-                            sal_uInt32 nIdx = 0
+                            sal_uInt32 nIdx
                             ) const override;
 };
 

xmloff/source/draw/sdxmlexp_impl.hxx

@@ -162,7 +162,7 @@ public:
     SdXMLExport(
         const css::uno::Reference< css::uno::XComponentContext >& xContext,
         OUString const & implementationName,
-        bool bIsDraw, SvXMLExportFlags nExportFlags = SvXMLExportFlags::ALL );
+        bool bIsDraw, SvXMLExportFlags nExportFlags );
     virtual ~SdXMLExport() override;
 
     void SetProgress(sal_Int32 nProg);

xmloff/source/draw/shapeimport.cxx

@@ -721,7 +721,7 @@ public:
     sal_Int32                       mnCurrentZ;
     std::shared_ptr<ShapeSortContext> mpParentContext;
 
-    ShapeSortContext( uno::Reference< drawing::XShapes >& rShapes, std::shared_ptr<ShapeSortContext> pParentContext = nullptr );
+    ShapeSortContext( uno::Reference< drawing::XShapes >& rShapes, std::shared_ptr<ShapeSortContext> pParentContext );
 
     void popGroupAndSort();
 private:

xmloff/source/forms/controlpropertymap.hxx

@@ -43,7 +43,7 @@ namespace xmloff
             const SvXMLUnitConverter&                   _rUnitConverter,
             const SvXMLNamespaceMap&                    _rNamespaceMap,
             const ::std::vector< XMLPropertyState >*    _pProperties,
-            sal_uInt32                                  _nIdx = 0
+            sal_uInt32                                  _nIdx
         ) const override;
     };
 

xmloff/source/style/PageMasterExportPropMapper.hxx

@@ -50,7 +50,7 @@ public:
                             const XMLPropertyState& rProperty,
                             SvXmlExportFlags nFlags,
                             const ::std::vector< XMLPropertyState >* pProperties,
-                            sal_uInt32 nIdx = 0
+                            sal_uInt32 nIdx
                             ) const override;
     virtual void        handleSpecialItem(
                             SvXMLAttributeList& rAttrList,
@@ -58,7 +58,7 @@ public:
                             const SvXMLUnitConverter& rUnitConverter,
                             const SvXMLNamespaceMap& rNamespaceMap,
                             const ::std::vector< XMLPropertyState >* pProperties,
-                            sal_uInt32 nIdx = 0
+                            sal_uInt32 nIdx
                             ) const override;
 };
 

xmloff/source/style/impastpl.hxx

@@ -118,7 +118,7 @@ struct XMLAutoStyleFamily
 
     XMLAutoStyleFamily( sal_Int32 nFamily, const OUString& rStrName,
             const rtl::Reference<SvXMLExportPropertyMapper>& rMapper,
-            const OUString& rStrPrefix, bool bAsFamily = true );
+            const OUString& rStrPrefix, bool bAsFamily );
 
     explicit XMLAutoStyleFamily( sal_Int32 nFamily );
     ~XMLAutoStyleFamily();

xmloff/source/style/xmlbahdl.hxx

@@ -33,7 +33,7 @@ class XMLNumberPropHdl : public XMLPropertyHandler
     sal_Int8 nBytes;
 
 public:
-    explicit XMLNumberPropHdl( sal_Int8 nB=4 ) : nBytes( nB ) {}
+    explicit XMLNumberPropHdl( sal_Int8 nB ) : nBytes( nB ) {}
     virtual ~XMLNumberPropHdl() override;
 
     virtual bool importXML( const OUString& rStrImpValue, css::uno::Any& rValue, const SvXMLUnitConverter& rUnitConverter ) const override;
@@ -49,7 +49,7 @@ class XMLNumberNonePropHdl : public XMLPropertyHandler
     sal_Int8        nBytes;
 public:
     explicit XMLNumberNonePropHdl( sal_Int8 nB = 4 );
-    XMLNumberNonePropHdl( enum ::xmloff::token::XMLTokenEnum eZeroString, sal_Int8 nB = 4 );
+    XMLNumberNonePropHdl( enum ::xmloff::token::XMLTokenEnum eZeroString, sal_Int8 nB );
     virtual ~XMLNumberNonePropHdl() override;
 
     virtual bool importXML( const OUString& rStrImpValue, css::uno::Any& rValue, const SvXMLUnitConverter& rUnitConverter ) const override;
@@ -63,7 +63,7 @@ class XMLMeasurePropHdl : public XMLPropertyHandler
 {
     sal_Int8 nBytes;
 public:
-    explicit XMLMeasurePropHdl( sal_Int8 nB=4 ) : nBytes( nB ) {}
+    explicit XMLMeasurePropHdl( sal_Int8 nB ) : nBytes( nB ) {}
     virtual ~XMLMeasurePropHdl() override;
 
     virtual bool importXML( const OUString& rStrImpValue, css::uno::Any& rValue, const SvXMLUnitConverter& rUnitConverter ) const override;
@@ -77,7 +77,7 @@ class XMLPercentPropHdl : public XMLPropertyHandler
 {
     sal_Int8 nBytes;
 public:
-    explicit XMLPercentPropHdl( sal_Int8 nB=4 ) : nBytes( nB ) {}
+    explicit XMLPercentPropHdl( sal_Int8 nB ) : nBytes( nB ) {}
     virtual ~XMLPercentPropHdl() override;
 
     virtual bool importXML( const OUString& rStrImpValue, css::uno::Any& rValue, const SvXMLUnitConverter& rUnitConverter ) const override;
@@ -101,7 +101,7 @@ class XMLNegPercentPropHdl : public XMLPropertyHandler
 {
     sal_Int8 nBytes;
 public:
-    explicit XMLNegPercentPropHdl( sal_Int8 nB=4 ) : nBytes( nB ) {}
+    explicit XMLNegPercentPropHdl( sal_Int8 nB ) : nBytes( nB ) {}
     virtual ~XMLNegPercentPropHdl() override;
 
     virtual bool importXML( const OUString& rStrImpValue, css::uno::Any& rValue, const SvXMLUnitConverter& rUnitConverter ) const override;
@@ -115,7 +115,7 @@ class XMLMeasurePxPropHdl : public XMLPropertyHandler
 {
     sal_Int8 nBytes;
 public:
-    explicit XMLMeasurePxPropHdl( sal_Int8 nB=4 ) : nBytes( nB ) {}
+    explicit XMLMeasurePxPropHdl( sal_Int8 nB ) : nBytes( nB ) {}
     virtual ~XMLMeasurePxPropHdl() override;
 
     virtual bool importXML( const OUString& rStrImpValue, css::uno::Any& rValue, const SvXMLUnitConverter& rUnitConverter ) const override;

xmloff/source/text/XMLChangeImportContext.hxx

@@ -60,7 +60,7 @@ public:
         bool bIsEnd,    /// mark end of a change
         /// true if change mark is encountered outside of a paragraph
         /// (usually before a section or table)
-        bool bIsOutsideOfParagraph = false);
+        bool bIsOutsideOfParagraph);
 
     virtual ~XMLChangeImportContext() override;
 

xmloff/source/text/XMLTextListItemContext.hxx

@@ -44,7 +44,7 @@ public:
             const sal_uInt16 nPrfx,
             const OUString& rLName,
             const css::uno::Reference< css::xml::sax::XAttributeList > & xAttrList,
-            const bool bIsHeader = false );
+            const bool bIsHeader );
     virtual ~XMLTextListItemContext() override;
 
     virtual void EndElement() override;

xmloff/source/text/txtexppr.hxx

@@ -74,7 +74,7 @@ public:
         const XMLPropertyState& rProperty,
         SvXmlExportFlags nFlags,
         const ::std::vector< XMLPropertyState > *pProperties,
-        sal_uInt32 nIdx = 0 ) const override;
+        sal_uInt32 nIdx ) const override;
 
     virtual void handleSpecialItem(
         SvXMLAttributeList& rAttrList,
@@ -82,7 +82,7 @@ public:
         const SvXMLUnitConverter& rUnitConverter,
         const SvXMLNamespaceMap& rNamespaceMap,
         const ::std::vector< XMLPropertyState > *pProperties,
-        sal_uInt32 nIdx = 0 ) const override;
+        sal_uInt32 nIdx ) const override;
 };
 
 

xmloff/source/transform/EventOOoTContext.hxx

@@ -31,7 +31,7 @@ class XMLEventOOoTransformerContext : public XMLPersElemContentTContext
 public:
     XMLEventOOoTransformerContext( XMLTransformerBase& rTransformer,
                            const OUString& rQName,
-                              bool bPersistent = false  );
+                              bool bPersistent  );
     virtual ~XMLEventOOoTransformerContext() override;
 
     static XMLTransformerOOoEventMap_Impl *CreateEventMap();

xmloff/source/transform/StyleOASISTContext.cxx

@@ -81,7 +81,7 @@ public:
                            const OUString& rQName,
                            XMLPropType eP,
                            const OUString& rStyleFamily,
-                           bool _bControlStyle = false );
+                           bool _bControlStyle );
 
     virtual ~XMLPropertiesTContext_Impl() override;
 

xmloff/source/transform/StyleOASISTContext.hxx

@@ -37,12 +37,12 @@ class XMLStyleOASISTContext : public XMLPersElemContentTContext
 public:
     XMLStyleOASISTContext( XMLTransformerBase& rTransformer,
                            const OUString& rQName,
-                              bool bPersistent=false );
+                              bool bPersistent );
     XMLStyleOASISTContext( XMLTransformerBase& rTransformer,
                            const OUString& rQName,
                               sal_uInt16 nPrefix,
                               ::xmloff::token::XMLTokenEnum eToken,
-                              bool bPersistent=false );
+                              bool bPersistent );
 
     virtual ~XMLStyleOASISTContext() override;
 

xmloff/source/transform/TransformerBase.hxx

@@ -78,8 +78,8 @@ protected:
                                       const OUString& rQName );
 
 public:
-    XMLTransformerBase( XMLTransformerActionInit *pInit=nullptr,
-                           ::xmloff::token::XMLTokenEnum *pTKMapInit=nullptr ) throw();
+    XMLTransformerBase( XMLTransformerActionInit *pInit,
+                           ::xmloff::token::XMLTokenEnum *pTKMapInit ) throw();
     virtual ~XMLTransformerBase() throw() override;
 
     // css::xml::sax::XDocumentHandler

xmloff/source/xforms/TokenContext.hxx

@@ -44,8 +44,8 @@ public:
     TokenContext( SvXMLImport& rImport,
                   sal_uInt16 nPrefix,
                   const OUString& rLocalName,
-                  const SvXMLTokenMapEntry* pAttributes = nullptr,
-                  const SvXMLTokenMapEntry* pChildren = nullptr );
+                  const SvXMLTokenMapEntry* pAttributes,
+                  const SvXMLTokenMapEntry* pChildren );
 
     virtual ~TokenContext() override;