outer loop unrelated to inner loop

since original checkin of...

commit 9cddf9da
Date:   Tue May 22 15:33:44 2007 +0000

    INTEGRATION: CWS chart2mst3 (1.1.2); FILE ADDED
...
    2006/12/13 12:31:03 tl 1.1.2.38: #i71244# update charts in writer

where I think this LockUnlockAllCharts chart2 loop was modelled on
the previous chart[1] styles loop of e.g. DoUpdateAllCharts which
loop over tables.

chart2 objects are unrelated to these tables, so remove the outer
loop, which then means the ofz#9689 ofz#9856 ofz9874 crashes that
made me look at it will get fixed

Change-Id: I7d7ba0a2aa257b5aa399f20d902f01306fbaecff
Reviewed-on: https://gerrit.libreoffice.org/59110
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

sw/source/core/unocore/unochart.cxx

@@ -117,19 +117,6 @@ void SwChartLockController_Helper::LockUnlockAllCharts( bool bLock )
     if (!pDoc)
         return;
 
-    const SwFrameFormats& rTableFormats = *pDoc->GetTableFrameFormats();
-    for( size_t n = 0; n < rTableFormats.size(); ++n )
-    {
-        const SwFrameFormat* pFormat = rTableFormats[ n ];
-        SwTable* pTmpTable = SwTable::FindTable(pFormat);
-        if (!pTmpTable)
-            continue;
-        const SwTableNode* pTableNd = pTmpTable->GetTableNode();
-        if (!pTableNd)
-            continue;
-        if (!pTableNd->GetNodes().IsDocNodes())
-            continue;
-
     uno::Reference< frame::XModel > xRes;
     SwOLENode *pONd;
     SwStartNode *pStNd;
@@ -155,7 +142,6 @@ void SwChartLockController_Helper::LockUnlockAllCharts( bool bLock )
         }
         aIdx.Assign( *pStNd->EndOfSectionNode(), + 1 );
     }
-    }
 
     bIsLocked = bLock;
 }