vcl: loplugin:passstuffbyref

Change-Id: I4ad2b77112a2c9bfbf76f0b84275d88046ed3851

include/vcl/builder.hxx

@@ -107,7 +107,7 @@ public:
     static void     reorderWithinParent(vcl::Window &rWindow, sal_uInt16 nNewPosition);
 
     /// Get label of the command (like of .uno:Save) from the description service
-    static OUString getCommandProperty(const OUString aProperty, const OUString& rCommand,
+    static OUString getCommandProperty(const OUString& rProperty, const OUString& rCommand,
                                        const css::uno::Reference<css::uno::XComponentContext>& rContext,
                                        const OUString& rModuleId);
 

vcl/source/window/builder.cxx

@@ -2168,7 +2168,7 @@ void VclBuilder::reorderWithinParent(std::vector<vcl::Window*>& rChilds, bool bI
     }
 }
 
-OUString VclBuilder::getCommandProperty(const OUString aProperty, const OUString& rCommand,
+OUString VclBuilder::getCommandProperty(const OUString& rProperty, const OUString& rCommand,
                                      const uno::Reference<uno::XComponentContext>& rContext, const OUString& rModuleId)
 {
     if (rCommand.isEmpty())
@@ -2186,7 +2186,7 @@ OUString VclBuilder::getCommandProperty(const OUString aProperty, const OUString
             {
                 for ( sal_Int32 i = 0; i < aProperties.getLength(); i++ )
                 {
-                    if (aProperties[i].Name == aProperty)
+                    if (aProperties[i].Name == rProperty)
                     {
                         OUString aLabel;
                         if (aProperties[i].Value >>= aLabel)