loplugin:countusersofdefaultparams in include/sot..svl

Change-Id: Idb022a4a6fb950f1b259abbba57daed9401732d9
Reviewed-on: https://gerrit.libreoffice.org/31038Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

include/sot/stg.hxx

@@ -128,7 +128,7 @@ protected:
     StgDirEntry*    pEntry;                   // the dir entry
                     OLEStorageBase( StgIo*, StgDirEntry*, StreamMode& );
                     ~OLEStorageBase();
-    bool            Validate_Impl( bool=false ) const;
+    bool            Validate_Impl( bool ) const;
     static bool     ValidateMode_Impl( StreamMode, StgDirEntry* p = nullptr );
 };
 
@@ -165,9 +165,9 @@ class SOT_DLLPUBLIC Storage : public BaseStorage, public OLEStorageBase
 protected:
                                 virtual ~Storage() override;
 public:
-                                Storage( const OUString &, StreamMode = StreamMode::STD_READWRITE, bool bDirect = true );
-                                Storage( SvStream& rStrm, bool bDirect = true );
-                                Storage( UCBStorageStream& rStrm, bool bDirect = true );
+                                Storage( const OUString &, StreamMode, bool bDirect );
+                                Storage( SvStream& rStrm, bool bDirect );
+                                Storage( UCBStorageStream& rStrm, bool bDirect );
 
     static bool                 IsStorageFile( const OUString & rFileName );
     static bool                 IsStorageFile( SvStream* );
@@ -258,11 +258,16 @@ public:
     static bool                 IsStorageFile( SvStream* );
     static OUString             GetLinkedFile( SvStream& );
 
-                                UCBStorage( const ::ucbhelper::Content& rContent, const OUString& rName, StreamMode nMode, bool bDirect = true, bool bIsRoot = true );
+                                UCBStorage( const ::ucbhelper::Content& rContent,
+                                            const OUString& rName,
+                                            StreamMode nMode,
+                                            bool bDirect,
+                                            bool bIsRoot );
+
                                 UCBStorage( const OUString& rName,
                                             StreamMode nMode,
-                                            bool bDirect = true,
-                                            bool bIsRoot = true );
+                                            bool bDirect,
+                                            bool bIsRoot );
 
                                 UCBStorage( const OUString& rName,
                                             StreamMode nMode,
@@ -273,7 +278,8 @@ public:
                                             xProgressHandler );
 
                                 UCBStorage( UCBStorage_Impl* );
-                                UCBStorage( SvStream& rStrm, bool bDirect = true );
+
+                                UCBStorage( SvStream& rStrm, bool bDirect );
 
     virtual const OUString&     GetName() const override;
     virtual bool                IsRoot() const override;

include/sot/storage.hxx

@@ -112,7 +112,7 @@ public:
                                 m_nError = nErrorCode;
                         }
 
-    void                SignAsRoot( bool b = true ) { m_bIsRoot = b; }
+    void                SignAsRoot( bool b ) { m_bIsRoot = b; }
 
                         // own data sector
     void                SetClass( const SvGlobalName & rClass,

include/svl/cintitem.hxx

@@ -30,7 +30,7 @@ class SVL_DLLPUBLIC CntByteItem: public SfxPoolItem
 
 public:
 
-    CntByteItem(sal_uInt16 which = 0, sal_uInt8 nTheValue = 0):
+    CntByteItem(sal_uInt16 which, sal_uInt8 nTheValue):
         SfxPoolItem(which), m_nValue(nTheValue) {}
 
     CntByteItem(const CntByteItem & rItem):
@@ -76,7 +76,7 @@ class SVL_DLLPUBLIC CntUInt16Item: public SfxPoolItem
 
 public:
 
-    CntUInt16Item(sal_uInt16 which = 0, sal_uInt16 nTheValue = 0):
+    CntUInt16Item(sal_uInt16 which, sal_uInt16 nTheValue):
         SfxPoolItem(which), m_nValue(nTheValue)
     {}
 
@@ -125,7 +125,7 @@ class SVL_DLLPUBLIC CntInt32Item: public SfxPoolItem
 
 public:
 
-    CntInt32Item(sal_uInt16 which = 0, sal_Int32 nTheValue = 0):
+    CntInt32Item(sal_uInt16 which, sal_Int32 nTheValue):
         SfxPoolItem(which), m_nValue(nTheValue)
     {}
 
@@ -174,7 +174,7 @@ class SVL_DLLPUBLIC CntUInt32Item: public SfxPoolItem
 
 public:
 
-    CntUInt32Item(sal_uInt16 which = 0, sal_uInt32 nTheValue = 0):
+    CntUInt32Item(sal_uInt16 which, sal_uInt32 nTheValue):
         SfxPoolItem(which), m_nValue(nTheValue)
     {}
 

include/svl/custritm.hxx

@@ -30,7 +30,7 @@ class SVL_DLLPUBLIC CntUnencodedStringItem: public SfxPoolItem
 
 public:
 
-    CntUnencodedStringItem(sal_uInt16 which = 0): SfxPoolItem(which)
+    CntUnencodedStringItem(sal_uInt16 which): SfxPoolItem(which)
     {}
 
     CntUnencodedStringItem(sal_uInt16 which, const OUString & rTheValue):

include/svl/gridprinter.hxx

@@ -26,7 +26,7 @@ class SVL_DLLPUBLIC GridPrinter
     std::unique_ptr<Impl> mpImpl;
 
 public:
-    GridPrinter( size_t nRows, size_t nCols, bool bPrint = true );
+    GridPrinter( size_t nRows, size_t nCols, bool bPrint );
     ~GridPrinter();
     void set( size_t nRow, size_t nCol, const OUString& rStr );
     void print( const char* pHeader ) const;

include/svl/int64item.hxx

@@ -18,7 +18,7 @@ class SVL_DLLPUBLIC SfxInt64Item : public SfxPoolItem
     sal_Int64 mnValue;
 
 public:
-    SfxInt64Item( sal_uInt16 nWhich = 0, sal_Int64 nVal = 0 );
+    SfxInt64Item( sal_uInt16 nWhich, sal_Int64 nVal );
     SfxInt64Item( sal_uInt16 nWhich, SvStream & rStream );
     SfxInt64Item( const SfxInt64Item& rItem );
 

include/svl/itempool.hxx

@@ -150,10 +150,10 @@ public:
     const SfxPoolItem&              GetDefaultItem( sal_uInt16 nWhich ) const;
 
     const SfxPoolItem*              LoadItem( SvStream &rStream,
-                                              const SfxItemPool *pRefPool = nullptr );
+                                              const SfxItemPool *pRefPool );
     bool                            StoreItem( SvStream &rStream,
                                                const SfxPoolItem &rItem,
-                                               bool bDirect = false ) const;
+                                               bool bDirect ) const;
 
     sal_uInt32                      GetSurrogate(const SfxPoolItem *) const;
     const SfxPoolItem *             GetItem2(sal_uInt16 nWhich, sal_uInt32 nSurrogate) const;

include/svl/metitem.hxx

@@ -25,7 +25,7 @@
 class SVL_DLLPUBLIC SfxMetricItem: public SfxInt32Item
 {
 public:
-    explicit                 SfxMetricItem( sal_uInt16 nWhich = 0, sal_uInt32 nValue = 0 );
+    explicit                 SfxMetricItem( sal_uInt16 nWhich, sal_uInt32 nValue );
                              SfxMetricItem( sal_uInt16 nWhich, SvStream & );
                              SfxMetricItem( const SfxMetricItem& );
                              virtual ~SfxMetricItem() override {}

include/svl/visitem.hxx

@@ -30,7 +30,7 @@ class SVL_DLLPUBLIC SfxVisibilityItem: public SfxPoolItem
 
 public:
 
-    explicit SfxVisibilityItem(sal_uInt16 which = 0, bool bVisible = true):
+    explicit SfxVisibilityItem(sal_uInt16 which, bool bVisible = true):
         SfxPoolItem(which)
     {
         m_nValue.bVisible = bVisible;

include/svl/zformat.hxx

@@ -618,7 +618,7 @@ private:
     // normal digits or other digits, depending on ImpSvNumFor.aNatNum,
     // [NatNum1], [NatNum2], ...
     SVL_DLLPRIVATE OUString ImpGetNatNumString( const SvNumberNatNum& rNum, sal_Int32 nVal,
-                                              sal_uInt16 nMinDigits = 0  ) const;
+                                              sal_uInt16 nMinDigits  ) const;
 
     OUString ImpIntToString( sal_uInt16 nIx, sal_Int32 nVal, sal_uInt16 nMinDigits = 0 ) const
     {

sot/source/sdstor/storage.cxx

@@ -333,7 +333,7 @@ void SotStorage::CreateStorage( bool bForceUCBStorage, StreamMode nMode )
                 {
                     // UCBStorage always works directly on the UCB content, so discard the stream first
                     DELETEZ( m_pStorStm );
-                    m_pOwnStg = new UCBStorage( m_aName, nMode, true );
+                    m_pOwnStg = new UCBStorage( m_aName, nMode, true, true/*bIsRoot*/ );
                 }
             }
             else
@@ -345,7 +345,7 @@ void SotStorage::CreateStorage( bool bForceUCBStorage, StreamMode nMode )
         }
         else if ( bForceUCBStorage )
         {
-            m_pOwnStg = new UCBStorage( m_aName, nMode, true );
+            m_pOwnStg = new UCBStorage( m_aName, nMode, true, true/*bIsRoot*/ );
             SetError( ERRCODE_IO_NOTSUPPORTED );
         }
         else
@@ -358,7 +358,7 @@ void SotStorage::CreateStorage( bool bForceUCBStorage, StreamMode nMode )
     {
         // temporary storage
         if ( bForceUCBStorage )
-            m_pOwnStg = new UCBStorage( m_aName, nMode, true );
+            m_pOwnStg = new UCBStorage( m_aName, nMode, true, true/*bIsRoot*/ );
         else
             m_pOwnStg = new Storage( m_aName, nMode, true );
         m_aName = m_pOwnStg->GetName();