Kaydet (Commit) 1e6ccc7f authored tarafından Thomas Arnhold's avatar Thomas Arnhold

cppcheck: Function parameter 'aFocusLocation' should be passed by reference

Change-Id: I2d2b9ae3ea81bd725be2af460f6c57bd0897883c
üst 058cd961
...@@ -370,25 +370,25 @@ void FocusManager::RemoveWindow (Window& rWindow) ...@@ -370,25 +370,25 @@ void FocusManager::RemoveWindow (Window& rWindow)
bool FocusManager::MoveFocusInsidePanel ( bool FocusManager::MoveFocusInsidePanel (
const FocusLocation aFocusLocation, const FocusLocation& rFocusLocation,
const sal_Int32 nDirection) const sal_Int32 nDirection)
{ {
const bool bHasToolBoxItem ( const bool bHasToolBoxItem (
maPanels[aFocusLocation.mnIndex]->GetTitleBar()->GetToolBox().GetItemCount() > 0); maPanels[rFocusLocation.mnIndex]->GetTitleBar()->GetToolBox().GetItemCount() > 0);
switch (aFocusLocation.meComponent) switch (rFocusLocation.meComponent)
{ {
case PC_PanelTitle: case PC_PanelTitle:
if (nDirection > 0 && bHasToolBoxItem) if (nDirection > 0 && bHasToolBoxItem)
maPanels[aFocusLocation.mnIndex]->GetTitleBar()->GetToolBox().GrabFocus(); maPanels[rFocusLocation.mnIndex]->GetTitleBar()->GetToolBox().GrabFocus();
else else
FocusPanelContent(aFocusLocation.mnIndex); FocusPanelContent(rFocusLocation.mnIndex);
return true; return true;
case PC_PanelToolBox: case PC_PanelToolBox:
if (nDirection < 0 && bHasToolBoxItem) if (nDirection < 0 && bHasToolBoxItem)
maPanels[aFocusLocation.mnIndex]->GetTitleBar()->GrabFocus(); maPanels[rFocusLocation.mnIndex]->GetTitleBar()->GrabFocus();
else else
FocusPanelContent(aFocusLocation.mnIndex); FocusPanelContent(rFocusLocation.mnIndex);
return true; return true;
default: default:
...@@ -400,7 +400,7 @@ bool FocusManager::MoveFocusInsidePanel ( ...@@ -400,7 +400,7 @@ bool FocusManager::MoveFocusInsidePanel (
bool FocusManager::MoveFocusInsideDeckTitle ( bool FocusManager::MoveFocusInsideDeckTitle (
const FocusLocation aFocusLocation, const FocusLocation& rFocusLocation,
const sal_Int32 nDirection) const sal_Int32 nDirection)
{ {
// Note that when the title bar of the first (and only) panel is // Note that when the title bar of the first (and only) panel is
...@@ -409,7 +409,7 @@ bool FocusManager::MoveFocusInsideDeckTitle ( ...@@ -409,7 +409,7 @@ bool FocusManager::MoveFocusInsideDeckTitle (
// of panel 0. // of panel 0.
const bool bHasToolBoxItem ( const bool bHasToolBoxItem (
mpDeckTitleBar->GetToolBox().GetItemCount() > 0); mpDeckTitleBar->GetToolBox().GetItemCount() > 0);
switch (aFocusLocation.meComponent) switch (rFocusLocation.meComponent)
{ {
case PC_DeckTitle: case PC_DeckTitle:
if (nDirection<0 && ! IsPanelTitleVisible(0)) if (nDirection<0 && ! IsPanelTitleVisible(0))
......
...@@ -134,10 +134,10 @@ private: ...@@ -134,10 +134,10 @@ private:
void FocusButton (const sal_Int32 nButtonIndex); void FocusButton (const sal_Int32 nButtonIndex);
void ClickButton (const sal_Int32 nButtonIndex); void ClickButton (const sal_Int32 nButtonIndex);
bool MoveFocusInsidePanel ( bool MoveFocusInsidePanel (
const FocusLocation aLocation, const FocusLocation& rLocation,
const sal_Int32 nDirection); const sal_Int32 nDirection);
bool MoveFocusInsideDeckTitle ( bool MoveFocusInsideDeckTitle (
const FocusLocation aLocation, const FocusLocation& rLocation,
const sal_Int32 nDirection); const sal_Int32 nDirection);
void HandleKeyEvent ( void HandleKeyEvent (
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment