Kaydet (Commit) 1fa230f7 authored tarafından Noel Grandin's avatar Noel Grandin

loplugin:useuniqueptr in chelp::ResultSetBase

Change-Id: I6e8541837a07c8cf2e001289e0804d7e4e7ba3b1
Reviewed-on: https://gerrit.libreoffice.org/50658Tested-by: 's avatarJenkins <ci@libreoffice.org>
Reviewed-by: 's avatarNoel Grandin <noel.grandin@collabora.co.uk>
üst 3b8cd4f9
...@@ -48,9 +48,6 @@ ResultSetBase::ResultSetBase( const uno::Reference< uno::XComponentContext >& r ...@@ -48,9 +48,6 @@ ResultSetBase::ResultSetBase( const uno::Reference< uno::XComponentContext >& r
ResultSetBase::~ResultSetBase() ResultSetBase::~ResultSetBase()
{ {
delete m_pIsFinalListeners;
delete m_pRowCountListeners;
delete m_pDisposeEventListeners;
} }
...@@ -96,8 +93,8 @@ ResultSetBase::addEventListener( ...@@ -96,8 +93,8 @@ ResultSetBase::addEventListener(
osl::MutexGuard aGuard( m_aMutex ); osl::MutexGuard aGuard( m_aMutex );
if ( ! m_pDisposeEventListeners ) if ( ! m_pDisposeEventListeners )
m_pDisposeEventListeners = m_pDisposeEventListeners.reset(
new comphelper::OInterfaceContainerHelper2( m_aMutex ); new comphelper::OInterfaceContainerHelper2( m_aMutex ));
m_pDisposeEventListeners->addInterface( Listener ); m_pDisposeEventListeners->addInterface( Listener );
} }
...@@ -453,8 +450,8 @@ void SAL_CALL ResultSetBase::addPropertyChangeListener( ...@@ -453,8 +450,8 @@ void SAL_CALL ResultSetBase::addPropertyChangeListener(
{ {
osl::MutexGuard aGuard( m_aMutex ); osl::MutexGuard aGuard( m_aMutex );
if ( ! m_pIsFinalListeners ) if ( ! m_pIsFinalListeners )
m_pIsFinalListeners = m_pIsFinalListeners.reset(
new comphelper::OInterfaceContainerHelper2( m_aMutex ); new comphelper::OInterfaceContainerHelper2( m_aMutex ));
m_pIsFinalListeners->addInterface( xListener ); m_pIsFinalListeners->addInterface( xListener );
} }
...@@ -462,8 +459,8 @@ void SAL_CALL ResultSetBase::addPropertyChangeListener( ...@@ -462,8 +459,8 @@ void SAL_CALL ResultSetBase::addPropertyChangeListener(
{ {
osl::MutexGuard aGuard( m_aMutex ); osl::MutexGuard aGuard( m_aMutex );
if ( ! m_pRowCountListeners ) if ( ! m_pRowCountListeners )
m_pRowCountListeners = m_pRowCountListeners.reset(
new comphelper::OInterfaceContainerHelper2( m_aMutex ); new comphelper::OInterfaceContainerHelper2( m_aMutex ));
m_pRowCountListeners->addInterface( xListener ); m_pRowCountListeners->addInterface( xListener );
} }
else else
......
...@@ -20,6 +20,7 @@ ...@@ -20,6 +20,7 @@
#define INCLUDED_XMLHELP_SOURCE_CXXHELP_PROVIDER_RESULTSETBASE_HXX #define INCLUDED_XMLHELP_SOURCE_CXXHELP_PROVIDER_RESULTSETBASE_HXX
#include <vector> #include <vector>
#include <memory>
#include <cppuhelper/weak.hxx> #include <cppuhelper/weak.hxx>
#include <comphelper/interfacecontainer2.hxx> #include <comphelper/interfacecontainer2.hxx>
#include <com/sun/star/lang/XComponent.hpp> #include <com/sun/star/lang/XComponent.hpp>
...@@ -390,10 +391,10 @@ namespace chelp { ...@@ -390,10 +391,10 @@ namespace chelp {
css::uno::Sequence< css::beans::Property > m_sProperty; css::uno::Sequence< css::beans::Property > m_sProperty;
osl::Mutex m_aMutex; osl::Mutex m_aMutex;
comphelper::OInterfaceContainerHelper2* m_pDisposeEventListeners; std::unique_ptr<comphelper::OInterfaceContainerHelper2> m_pDisposeEventListeners;
comphelper::OInterfaceContainerHelper2* m_pRowCountListeners; std::unique_ptr<comphelper::OInterfaceContainerHelper2> m_pRowCountListeners;
comphelper::OInterfaceContainerHelper2* m_pIsFinalListeners; std::unique_ptr<comphelper::OInterfaceContainerHelper2> m_pIsFinalListeners;
}; };
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment