loplugin:flatten in shell

Change-Id: Id58f692168274a942d2b976f10885341dfe63ac3
Reviewed-on: https://gerrit.libreoffice.org/67434
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

shell/source/all/xml_parser.cxx

@@ -94,8 +94,9 @@ static void xml_start_element_handler(void* UserData, const XML_Char* name, cons
     xml_parser* pImpl  = get_parser_instance(UserData);
 
     i_xml_parser_event_handler* pDocHdl = pImpl->get_document_handler();
-    if (pDocHdl)
-    {
+    if (!pDocHdl)
+        return;
+
     xml_tag_attribute_container_t attributes;
 
     int i = 0;
@@ -108,7 +109,6 @@ static void xml_start_element_handler(void* UserData, const XML_Char* name, cons
 
     pDocHdl->start_element(
         UTF8ToWString(reinterpret_cast<const char*>(name)), UTF8ToWString(reinterpret_cast<const char*>(get_local_name(name))), attributes);
-    }
 }
 
 static void xml_end_element_handler(void* UserData, const XML_Char* name)

shell/source/unix/sysshell/recently_used_file_handler.cxx

@@ -313,8 +313,9 @@ namespace /* private */ {
         recently_used_file& file,
         recently_used_item_list_t& item_list)
     {
-        if (!item_list.empty())
-        {
+        if (item_list.empty())
+            return;
+
         file.truncate();
         file.reset();
 
@@ -327,7 +328,6 @@ namespace /* private */ {
 
         file.write(XML_FOOTER, strlen(XML_FOOTER));
     }
-    }
 
 
     class find_item_predicate