Some cppcheck cleaning

vbahelper/source/vbahelper/vbacolorformat.cxx

@@ -57,7 +57,7 @@ ScVbaColorFormat::ScVbaColorFormat( const uno::Reference< XHelperInterface >& xP
     {
         uno::Reference< ov::msforms::XFillFormat > xFillFormat( xInternalParent, uno::UNO_QUERY_THROW );
         m_pFillFormat = ( ScVbaFillFormat* )( xFillFormat.get() );
-    }catch ( uno::RuntimeException  e )
+    }catch ( uno::RuntimeException& )
     {
         m_pFillFormat = NULL;
     }

vbahelper/source/vbahelper/vbacommandbar.cxx

@@ -122,7 +122,7 @@ ScVbaCommandBar::setVisible( ::sal_Bool _visible ) throw (uno::RuntimeException)
             xLayoutManager->destroyElement( m_sResourceUrl );
         }
     }
-    catch( uno::Exception e )
+    catch( uno::Exception& )
     {
         OSL_TRACE( "SetVisible get an exception\n" );
     }

vbahelper/source/vbahelper/vbacommandbarcontrols.hxx

@@ -50,7 +50,7 @@ private:
 
 public:
     ScVbaCommandBarControls( const css::uno::Reference< ov::XHelperInterface >& xParent, const css::uno::Reference< css::uno::XComponentContext >& xContext, const css::uno::Reference< css::container::XIndexAccess >& xIndexAccess, VbaCommandBarHelperRef pHelper, const css::uno::Reference< css::container::XIndexAccess >& xBarSettings, const rtl::OUString& sResourceUrl, const css::uno::Reference< css::awt::XMenu >& xMenu ) throw( css::uno::RuntimeException );
-    sal_Bool IsMenu(){ return m_bIsMenu; }
+    sal_Bool IsMenu() const { return m_bIsMenu; }
 
     // XEnumerationAccess
     virtual css::uno::Type SAL_CALL getElementType() throw (css::uno::RuntimeException);

vbahelper/source/vbahelper/vbacommandbarhelper.hxx

@@ -73,17 +73,17 @@ private:
 public:
     VbaCommandBarHelper( const css::uno::Reference< css::uno::XComponentContext >& xContext, const css::uno::Reference< css::frame::XModel >& xModel ) throw( css::uno::RuntimeException );
 
-    css::uno::Reference< css::frame::XModel > getModel() { return mxModel; }
+    css::uno::Reference< css::frame::XModel > getModel() const { return mxModel; }
 
-    css::uno::Reference< css::ui::XUIConfigurationManager > getDocCfgManager() throw (css::uno::RuntimeException)
+    css::uno::Reference< css::ui::XUIConfigurationManager > getDocCfgManager() const throw (css::uno::RuntimeException)
     {
         return m_xDocCfgMgr;
     }
-    css::uno::Reference< css::ui::XUIConfigurationManager > getAppCfgManager() throw (css::uno::RuntimeException)
+    css::uno::Reference< css::ui::XUIConfigurationManager > getAppCfgManager() const throw (css::uno::RuntimeException)
     {
         return m_xAppCfgMgr;
     }
-    css::uno::Reference< css::container::XNameAccess > getPersistentWindowState() throw (css::uno::RuntimeException)
+    css::uno::Reference< css::container::XNameAccess > getPersistentWindowState() const throw (css::uno::RuntimeException)
     {
         return m_xWindowState;
     }
@@ -94,7 +94,7 @@ public:
 
     css::uno::Reference< css::frame::XLayoutManager > getLayoutManager() throw (css::uno::RuntimeException);
 
-    const rtl::OUString getModuleId(){ return maModuleId; }
+    const rtl::OUString getModuleId() const { return maModuleId; }
     rtl::OUString findToolbarByName( const css::uno::Reference< css::container::XNameAccess >& xNameAccess, const rtl::OUString& sName ) throw (css::uno::RuntimeException);
     static sal_Int32 findControlByName( const css::uno::Reference< css::container::XIndexAccess >& xIndexAccess, const rtl::OUString& sName, bool bMenu = false ) throw (css::uno::RuntimeException);
     static rtl::OUString generateCustomURL();

vbahelper/source/vbahelper/vbalineformat.cxx

@@ -45,7 +45,7 @@ ScVbaLineFormat::ScVbaLineFormat( const uno::Reference< ov::XHelperInterface >&
 }
 
 sal_Int32
-ScVbaLineFormat::calculateArrowheadSize()
+ScVbaLineFormat::calculateArrowheadSize() const
 {
     return 0;
 }

vbahelper/source/vbahelper/vbalineformat.hxx

@@ -47,7 +47,7 @@ protected:
     virtual css::uno::Sequence<rtl::OUString> getServiceNames();
     sal_Int32 convertLineStartEndNameToArrowheadStyle( rtl::OUString sLineName );
     rtl::OUString convertArrowheadStyleToLineStartEndName( sal_Int32 nArrowheadStyle ) throw (css::uno::RuntimeException);
-    sal_Int32 calculateArrowheadSize();
+    sal_Int32 calculateArrowheadSize() const;
 public:
     ScVbaLineFormat( const css::uno::Reference< ov::XHelperInterface >& xParent, const css::uno::Reference< css::uno::XComponentContext >& xContext, const css::uno::Reference< css::drawing::XShape > xShape );