Kaydet (Commit) 20b75006 authored tarafından Caolán McNamara's avatar Caolán McNamara

noone checks the return value of ReadCsvLine

üst 5ac8641b
...@@ -464,8 +464,7 @@ public: ...@@ -464,8 +464,7 @@ public:
field may also be escaped with a preceding backslash. field may also be escaped with a preceding backslash.
Normally, quotes are escaped by doubling them. Normally, quotes are escaped by doubling them.
@return check Stream::good() to detect IO problems during read
sal_True if no stream error.
@ATTENTION @ATTENTION
Note that the string returned may be truncated even inside Note that the string returned may be truncated even inside
...@@ -483,7 +482,7 @@ public: ...@@ -483,7 +482,7 @@ public:
characters will be spoiled, and a subsequent ReadCsvLine() characters will be spoiled, and a subsequent ReadCsvLine()
may start under false preconditions. may start under false preconditions.
*/ */
sal_Bool ReadCsvLine( String& rStr, sal_Bool bEmbeddedLineBreak, void ReadCsvLine( String& rStr, sal_Bool bEmbeddedLineBreak,
const String& rFieldSeparators, sal_Unicode cFieldQuote, const String& rFieldSeparators, sal_Unicode cFieldQuote,
sal_Bool bAllowBackslashEscape = sal_False); sal_Bool bAllowBackslashEscape = sal_False);
......
...@@ -1037,7 +1037,7 @@ inline const sal_Unicode* lcl_UnicodeStrChr( const sal_Unicode* pStr, ...@@ -1037,7 +1037,7 @@ inline const sal_Unicode* lcl_UnicodeStrChr( const sal_Unicode* pStr,
return 0; return 0;
} }
sal_Bool SvStream::ReadCsvLine( String& rStr, sal_Bool bEmbeddedLineBreak, void SvStream::ReadCsvLine( String& rStr, sal_Bool bEmbeddedLineBreak,
const String& rFieldSeparators, sal_Unicode cFieldQuote, const String& rFieldSeparators, sal_Unicode cFieldQuote,
sal_Bool bAllowBackslashEscape) sal_Bool bAllowBackslashEscape)
{ {
...@@ -1102,7 +1102,6 @@ sal_Bool SvStream::ReadCsvLine( String& rStr, sal_Bool bEmbeddedLineBreak, ...@@ -1102,7 +1102,6 @@ sal_Bool SvStream::ReadCsvLine( String& rStr, sal_Bool bEmbeddedLineBreak,
} }
} }
} }
return nError == SVSTREAM_OK;
} }
/************************************************************************* /*************************************************************************
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment