Kaydet (Commit) 28f5e1b2 authored tarafından Julien Nabet's avatar Julien Nabet

Some PMD cleaning

üst 265a458c
...@@ -679,10 +679,12 @@ public class FormControlTest extends complexlib.ComplexTestCase implements XSQLE ...@@ -679,10 +679,12 @@ public class FormControlTest extends complexlib.ComplexTestCase implements XSQLE
{ {
try try
{ {
if ( fieldName.equals( "f_time" ) ) if ( ( "f_time" ).equals(fieldName) )
// http://bugs.mysql.com/bug.php?id=5681 // http://bugs.mysql.com/bug.php?id=5681
return true; return true;
if (fieldName == null) {
return false;
}
int currentValue = ((Integer)getControlModel( fieldName ).getPropertyValue( propertyName )).intValue(); int currentValue = ((Integer)getControlModel( fieldName ).getPropertyValue( propertyName )).intValue();
if ( currentValue != requiredValue ) if ( currentValue != requiredValue )
{ {
......
...@@ -836,8 +836,7 @@ public class AcceleratorsConfigurationTest ...@@ -836,8 +836,7 @@ public class AcceleratorsConfigurationTest
private XMultiServiceFactory getMSF() private XMultiServiceFactory getMSF()
{ {
final XMultiServiceFactory xMSF1 = UnoRuntime.queryInterface(XMultiServiceFactory.class, connection.getComponentContext().getServiceManager()); return(UnoRuntime.queryInterface(XMultiServiceFactory.class, connection.getComponentContext().getServiceManager()));
return xMSF1;
} }
// setup and close connections // setup and close connections
......
...@@ -80,8 +80,8 @@ public class FileHelper ...@@ -80,8 +80,8 @@ public class FileHelper
// => correct this problem first, otherwise office can't use these URL's // => correct this problem first, otherwise office can't use these URL's
if( if(
(sFileURL != null ) && (sFileURL != null ) &&
(sFileURL.startsWith("file:/") == true ) && (sFileURL.startsWith("file:/")) &&
(sFileURL.startsWith("file://") == false) (!sFileURL.startsWith("file://"))
) )
{ {
java.lang.StringBuffer sWorkBuffer = new java.lang.StringBuffer(sFileURL); java.lang.StringBuffer sWorkBuffer = new java.lang.StringBuffer(sFileURL);
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment