Kaydet (Commit) 299c5f87 authored tarafından Caolán McNamara's avatar Caolán McNamara

coverity#1397052 Logically dead code (golden)

regression from...

commit b894104a
Date:   Thu Dec 8 00:43:09 2016 +0200

    Pass GlyphItem around

    We have this nice structure that contains (almost) all the information
    we need, so pass it around instead of passing separate fragments of said
    information.

presumably this is the correct fix given the context of the other changes

Change-Id: I8518e739b1caa00ea5ae1569282e98810462d4c3
üst cfd2691e
......@@ -751,7 +751,6 @@ void OutputDevice::ImplDrawTextLines( SalLayout& rSalLayout, FontStrikeout eStri
Point aPos;
DeviceCoordinate nDist = 0;
DeviceCoordinate nWidth = 0;
DeviceCoordinate nAdvance = 0;
const GlyphItem* pGlyph;
int nStart = 0;
while (rSalLayout.GetNextGlyphs(1, &pGlyph, aPos, nStart))
......@@ -772,7 +771,7 @@ void OutputDevice::ImplDrawTextLines( SalLayout& rSalLayout, FontStrikeout eStri
}
// update the length of the textline
nWidth += nAdvance;
nWidth += pGlyph->mnNewWidth;
}
else if( nWidth > 0 )
{
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment