Hint assertions and sanity checks added.

Change-Id: I83bf8866c8855b3266703eca62010d28388c5a07
Reviewed-on: https://gerrit.libreoffice.org/13880Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

sw/inc/ndhints.hxx

@@ -103,13 +103,25 @@ public:
     SwTxtAttr * Cut( const size_t nPosInStart );
 
     inline const SwTxtAttr * GetStart( const size_t nPos ) const
-        { return m_HintStarts[nPos]; }
+    {
+        assert(nPos < m_HintStarts.size());
+        return m_HintStarts[nPos];
+    }
     inline const SwTxtAttr * GetEnd( const size_t nPos ) const
-        { return m_HintEnds  [nPos]; }
+    {
+        assert(nPos < m_HintEnds.size());
+        return m_HintEnds[nPos];
+    }
     inline       SwTxtAttr * GetStart( const size_t nPos )
-        { return m_HintStarts[nPos]; }
+    {
+        assert(nPos < m_HintStarts.size());
+        return m_HintStarts[nPos];
+    }
     inline       SwTxtAttr * GetEnd( const size_t nPos )
-        { return m_HintEnds  [nPos]; }
+    {
+        assert(nPos < m_HintStarts.size());
+        return m_HintEnds[nPos];
+    }
 
     inline size_t GetEndCount()   const { return m_HintEnds.size(); }
     inline size_t GetStartCount() const { return m_HintStarts.size(); }
@@ -122,8 +134,8 @@ public:
     inline       SwTxtAttr * GetTextHint( const size_t nIdx )
         { return GetStart(nIdx); }
     inline const SwTxtAttr * operator[]( const size_t nIdx ) const
-        { return m_HintStarts[nIdx]; }
-    inline size_t Count() const { return m_HintStarts.size(); }
+        { return GetStart(nIdx); }
+    inline size_t Count() const { return GetStartCount(); }
 
 #ifdef DBG_UTIL
     bool Check(bool) const;

sw/source/core/txtnode/ndhints.cxx

@@ -132,6 +132,10 @@ void SwpHintsArray::DeleteAtPos( const size_t nPos )
 
 bool SwpHintsArray::Contains( const SwTxtAttr *pHt ) const
 {
+#ifdef DBG_UTIL
+    Check(true);
+#endif
+
     // DO NOT use find() here!
     // if called from SwTxtNode::InsertItem, pHt has already been deleted,
     // so it cannot be dereferenced