Kaydet (Commit) 5371bc50 authored tarafından Norbert Thiebaud's avatar Norbert Thiebaud

coverity#703963 Unchecked return value

also avoid pointless double Guard

Change-Id: Ie7707fc3baf46f9363fdef6213df098123183ab9
üst 1f7a6708
...@@ -99,12 +99,12 @@ namespace svt ...@@ -99,12 +99,12 @@ namespace svt
void OCommonPicker::prepareDialog() void OCommonPicker::prepareDialog()
{ {
if ( !getDialog() ) if(createPicker())
createPicker(); {
// set the title // set the title
if ( !m_aTitle.isEmpty() ) if ( !m_aTitle.isEmpty() )
getDialog()->SetText( m_aTitle ); m_pDlg->SetText( m_aTitle );
}
} }
...@@ -199,8 +199,6 @@ namespace svt ...@@ -199,8 +199,6 @@ namespace svt
bool OCommonPicker::createPicker() bool OCommonPicker::createPicker()
{ {
SolarMutexGuard aGuard;
if ( !m_pDlg ) if ( !m_pDlg )
{ {
m_pDlg = implCreateDialog( VCLUnoHelper::GetWindow( m_xDialogParent ) ); m_pDlg = implCreateDialog( VCLUnoHelper::GetWindow( m_xDialogParent ) );
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment