Kaydet (Commit) 5ac84ff8 authored tarafından Norbert Thiebaud's avatar Norbert Thiebaud Kaydeden (comit) Michael Stahl

coverity#705766 Resource leak

Change-Id: I14ca19f33dd57ed1a4a52a8a02f213bada79c20c
Reviewed-on: https://gerrit.libreoffice.org/4409Reviewed-by: 's avatarMichael Stahl <mstahl@redhat.com>
Tested-by: 's avatarMichael Stahl <mstahl@redhat.com>
üst 37e1d7a0
...@@ -361,7 +361,6 @@ void SwView::ExecViewOptions(SfxRequest &rReq) ...@@ -361,7 +361,6 @@ void SwView::ExecViewOptions(SfxRequest &rReq)
switch ( nSlot ) switch ( nSlot )
{ {
case FN_VIEW_GRAPHIC: case FN_VIEW_GRAPHIC:
if( STATE_TOGGLE == eState ) if( STATE_TOGGLE == eState )
bFlag = !pOpt->IsGraphic(); bFlag = !pOpt->IsGraphic();
pOpt->SetGraphic( bFlag ); pOpt->SetGraphic( bFlag );
...@@ -409,7 +408,6 @@ void SwView::ExecViewOptions(SfxRequest &rReq) ...@@ -409,7 +408,6 @@ void SwView::ExecViewOptions(SfxRequest &rReq)
bBrowseModeChanged = bFlag != pOpt->getBrowseMode(); bBrowseModeChanged = bFlag != pOpt->getBrowseMode();
// Disable "multiple layout" // Disable "multiple layout"
GetDocShell()->ToggleBrowserMode( bFlag, this ); GetDocShell()->ToggleBrowserMode( bFlag, this );
pOpt->setBrowseMode( bFlag ); pOpt->setBrowseMode( bFlag );
break; break;
...@@ -459,6 +457,7 @@ void SwView::ExecViewOptions(SfxRequest &rReq) ...@@ -459,6 +457,7 @@ void SwView::ExecViewOptions(SfxRequest &rReq)
pOpt->SetViewHScrollBar( bFlag ); pOpt->SetViewHScrollBar( bFlag );
break; break;
case FN_RULER: case FN_RULER:
if( STATE_TOGGLE == eState ) if( STATE_TOGGLE == eState )
bFlag = !pOpt->IsViewAnyRuler(); bFlag = !pOpt->IsViewAnyRuler();
...@@ -478,18 +477,21 @@ void SwView::ExecViewOptions(SfxRequest &rReq) ...@@ -478,18 +477,21 @@ void SwView::ExecViewOptions(SfxRequest &rReq)
pOpt->SetFldName( bFlag ); pOpt->SetFldName( bFlag );
break; break;
case FN_VIEW_MARKS: case FN_VIEW_MARKS:
if( STATE_TOGGLE == eState ) if( STATE_TOGGLE == eState )
bFlag = !lcl_IsViewMarks(*pOpt) ; bFlag = !lcl_IsViewMarks(*pOpt) ;
lcl_SetViewMarks( *pOpt, bFlag ); lcl_SetViewMarks( *pOpt, bFlag );
break; break;
case FN_VIEW_META_CHARS: case FN_VIEW_META_CHARS:
if( STATE_TOGGLE == eState ) if( STATE_TOGGLE == eState )
bFlag = !pOpt->IsViewMetaChars(); bFlag = !pOpt->IsViewMetaChars();
lcl_SetViewMetaChars( *pOpt, bFlag ); lcl_SetViewMetaChars( *pOpt, bFlag );
break; break;
case SID_AUTOSPELL_CHECK: case SID_AUTOSPELL_CHECK:
if( STATE_TOGGLE == eState ) if( STATE_TOGGLE == eState )
bFlag = bSet = !pOpt->IsOnlineSpell(); bFlag = bSet = !pOpt->IsOnlineSpell();
...@@ -521,6 +523,7 @@ void SwView::ExecViewOptions(SfxRequest &rReq) ...@@ -521,6 +523,7 @@ void SwView::ExecViewOptions(SfxRequest &rReq)
} }
} }
break; break;
case FN_SHADOWCURSOR: case FN_SHADOWCURSOR:
if( STATE_TOGGLE == eState ) if( STATE_TOGGLE == eState )
bFlag = bSet = !pOpt->IsShadowCursor(); bFlag = bSet = !pOpt->IsShadowCursor();
...@@ -529,6 +532,7 @@ void SwView::ExecViewOptions(SfxRequest &rReq) ...@@ -529,6 +532,7 @@ void SwView::ExecViewOptions(SfxRequest &rReq)
break; break;
default: default:
delete pOpt;
OSL_FAIL("wrong request method"); OSL_FAIL("wrong request method");
return; return;
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment