const_cast: convert some C-style casts and remove some redundant ones

Change-Id: Ic14584cdd1047b2cfc590861b623a7e1e8be4429

reportdesign/source/filter/xml/xmlHelper.cxx

@@ -131,7 +131,7 @@ rtl::Reference < XMLPropertySetMapper > OXMLHelper::GetCellStylePropertyMap(bool
             MAP_CONST_C_ASCII(      "BorderBottom",     FO,     BORDER_BOTTOM,         XML_TYPE_BORDER, 0 ),
             MAP_END()
         };
-        return new XMLPropertySetMapper((XMLPropertyMapEntry*)s_aXMLCellStylesProperties,new OPropertyHandlerFactory(), bForExport);
+        return new XMLPropertySetMapper(s_aXMLCellStylesProperties,new OPropertyHandlerFactory(), bForExport);
     }
     else
     {
@@ -151,7 +151,7 @@ rtl::Reference < XMLPropertySetMapper > OXMLHelper::GetCellStylePropertyMap(bool
             MAP_CONST_C_ASCII(      "BorderBottom",     FO,     BORDER_BOTTOM,         XML_TYPE_BORDER, 0 ),
             MAP_END()
         };
-        return new XMLPropertySetMapper((XMLPropertyMapEntry*)s_aXMLCellStylesProperties,new OPropertyHandlerFactory(), bForExport);
+        return new XMLPropertySetMapper(s_aXMLCellStylesProperties,new OPropertyHandlerFactory(), bForExport);
     }
 }
 

reportdesign/source/filter/xml/xmlStyleImport.cxx

@@ -336,7 +336,7 @@ Reference < XNameContainer >
             }
             break;
             case XML_STYLE_FAMILY_SD_GRAPHICS_ID:
-                xStyles = ((SvXMLImport *)&GetImport())->GetTextImport()->GetFrameStyles();
+                xStyles = const_cast<SvXMLImport *>(&GetImport())->GetTextImport()->GetFrameStyles();
                 break;
             default:
                 OSL_FAIL("OReportStylesContext::CreateStyleStyleChildContext: Unknown style family. PLease check.");

reportdesign/source/ui/dlg/GroupsSorting.cxx

@@ -548,7 +548,7 @@ bool OFieldExpressionControl::SeekRow( long _nRow )
 
 void OFieldExpressionControl::PaintCell( OutputDevice& rDev, const Rectangle& rRect, sal_uInt16 nColumnId ) const
 {
-    OUString aText  =const_cast< OFieldExpressionControl*>(this)->GetCellText( m_nCurrentPos, nColumnId );
+    OUString aText  =GetCellText( m_nCurrentPos, nColumnId );
 
     Point aPos( rRect.TopLeft() );
     Size aTextSize( GetDataWindow().GetTextWidth( aText ), GetDataWindow().GetTextHeight() );

reportdesign/source/ui/report/FixedTextColor.cxx

@@ -157,7 +157,7 @@ namespace rptui
     {
 
         uno::Reference<awt::XControl> xControl;
-        OReportController *pController = (OReportController *)&m_rReportController;
+        OReportController *pController = const_cast<OReportController *>(&m_rReportController);
 
         ::boost::shared_ptr<OReportModel> pModel = pController->getSdrModel();
 

reportdesign/source/ui/report/FormattedFieldBeautifier.cxx

@@ -160,7 +160,7 @@ namespace rptui
     {
         uno::Reference<awt::XVclWindowPeer> xVclWindowPeer;
 
-        ::boost::shared_ptr<OReportModel> pModel = const_cast< OReportController& >( m_rReportController ).getSdrModel();
+        ::boost::shared_ptr<OReportModel> pModel = m_rReportController.getSdrModel();
 
         uno::Reference<report::XSection> xSection(_xComponent->getSection());
         if ( xSection.is() )