Kaydet (Commit) 9776cc15 authored tarafından Kohei Yoshida's avatar Kohei Yoshida

Check all this in one place i.e. in ValidQuery().

üst efdb67ca
...@@ -471,8 +471,12 @@ bool ScDPCache::InitFromDataBase (const Reference<sdbc::XRowSet>& xRowSet, const ...@@ -471,8 +471,12 @@ bool ScDPCache::InitFromDataBase (const Reference<sdbc::XRowSet>& xRowSet, const
bool ScDPCache::ValidQuery( SCROW nRow, const ScQueryParam &rParam) const bool ScDPCache::ValidQuery( SCROW nRow, const ScQueryParam &rParam) const
{ {
if (!rParam.GetEntryCount())
return true;
if (!rParam.GetEntry(0).bDoQuery) if (!rParam.GetEntry(0).bDoQuery)
return true; return true;
bool bMatchWholeCell = mpDoc->GetDocOptions().IsMatchWholeCell(); bool bMatchWholeCell = mpDoc->GetDocOptions().IsMatchWholeCell();
SCSIZE nEntryCount = rParam.GetEntryCount(); SCSIZE nEntryCount = rParam.GetEntryCount();
......
...@@ -64,15 +64,6 @@ using ::com::sun::star::uno::UNO_QUERY; ...@@ -64,15 +64,6 @@ using ::com::sun::star::uno::UNO_QUERY;
using ::com::sun::star::uno::UNO_QUERY_THROW; using ::com::sun::star::uno::UNO_QUERY_THROW;
using ::com::sun::star::sheet::DataPilotFieldFilter; using ::com::sun::star::sheet::DataPilotFieldFilter;
static sal_Bool lcl_HasQueryEntry( const ScQueryParam& rParam )
{
return rParam.GetEntryCount() > 0 &&
rParam.GetEntry(0).bDoQuery;
}
// ----------------------------------------------------------------------------
bool ScDPCacheTable::RowFlag::isActive() const bool ScDPCacheTable::RowFlag::isActive() const
{ {
return mbShowByFilter && mbShowByPage; return mbShowByFilter && mbShowByPage;
...@@ -186,9 +177,9 @@ void ScDPCacheTable::fillTable( ...@@ -186,9 +177,9 @@ void ScDPCacheTable::fillTable(
maRowFlags.back().mbShowByFilter = false; maRowFlags.back().mbShowByFilter = false;
} }
if ( lcl_HasQueryEntry(rQuery) && if (!getCache()->ValidQuery(nRow, rQuery))
!getCache()->ValidQuery(nRow , rQuery) )
continue; continue;
if ( bIgnoreEmptyRows && getCache()->IsRowEmpty( nRow ) ) if ( bIgnoreEmptyRows && getCache()->IsRowEmpty( nRow ) )
continue; continue;
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment