loplugin:unusedfields,can-be-const in xmlsecurity

Change-Id: I271b1d69d5231ab76cb49fb0101c09d7c0ef6b79
Reviewed-on: https://gerrit.libreoffice.org/57779
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

xmlsecurity/inc/certificatechooser.hxx

@@ -73,7 +73,7 @@ private:
     VclPtr<Edit>            m_pDescriptionED;
 
     bool                    mbInitialized;
-    UserAction              meAction;
+    UserAction const        meAction;
     OUString                msPreferredKey;
     css::uno::Reference<css::security::XCertificate> mxEncryptToSelf;
 

xmlsecurity/inc/certificateviewer.hxx

@@ -50,7 +50,7 @@ private:
     sal_uInt16          mnDetailsId;
     sal_uInt16          mnPathId;
 
-    bool                mbCheckForPrivateKey;
+    bool const          mbCheckForPrivateKey;
 
     css::uno::Reference< css::xml::crypto::XSecurityEnvironment > mxSecurityEnvironment;
     css::uno::Reference< css::security::XCertificate > mxCert;

xmlsecurity/inc/digitalsignaturesdialog.hxx

@@ -79,10 +79,10 @@ private:
 
     VclPtr<CloseButton>        m_pCloseBtn;
 
-    OUString m_sODFVersion;
+    OUString const m_sODFVersion;
     //Signals if the document contains already a document signature. This is only
     //important when we are signing macros and if the value is true.
-    bool m_bHasDocumentSignature;
+    bool const m_bHasDocumentSignature;
     bool m_bWarningShowSignMacro;
 
     bool m_bAdESCompliant;

xmlsecurity/inc/documentsignaturemanager.hxx

@@ -64,7 +64,7 @@ public:
     XMLSignatureHelper maSignatureHelper;
     std::unique_ptr<PDFSignatureHelper> mpPDFSignatureHelper;
     SignatureInformations maCurrentSignatureInformations;
-    DocumentSignatureMode meSignatureMode;
+    DocumentSignatureMode const meSignatureMode;
     css::uno::Sequence<css::uno::Sequence<css::beans::PropertyValue>> m_manifest;
     css::uno::Reference<css::io::XStream> mxSignatureStream;
     css::uno::Reference<css::io::XStream> mxTempSignatureStream;

xmlsecurity/source/dialogs/certificateviewer.cxx

@@ -43,11 +43,11 @@ CertificateViewer::CertificateViewer(
         vcl::Window* _pParent,
         const css::uno::Reference< css::xml::crypto::XSecurityEnvironment >& _rxSecurityEnvironment,
         const css::uno::Reference< css::security::XCertificate >& _rXCert, bool bCheckForPrivateKey )
-    : TabDialog(_pParent, "ViewCertDialog", "xmlsec/ui/viewcertdialog.ui" )
+    : TabDialog(_pParent, "ViewCertDialog", "xmlsec/ui/viewcertdialog.ui" ),
+    mbCheckForPrivateKey(bCheckForPrivateKey)
 {
     get(mpTabCtrl, "tabcontrol");
 
-    mbCheckForPrivateKey = bCheckForPrivateKey;
 
     mxSecurityEnvironment = _rxSecurityEnvironment;
     mxCert = _rXCert;
@@ -193,8 +193,8 @@ void CertificateViewerGeneralTP::ActivatePage()
 
 struct Details_UserDatat
 {
-    OUString        maTxt;
-    bool            mbFixedWidthFont;
+    OUString const  maTxt;
+    bool const      mbFixedWidthFont;
 
     inline          Details_UserDatat( const OUString& _rTxt, bool _bFixedWidthFont );
 };
@@ -361,7 +361,7 @@ IMPL_LINK_NOARG(CertificateViewerDetailsTP, ElementSelectHdl, SvTreeListBox*, vo
 struct CertPath_UserData
 {
     css::uno::Reference< css::security::XCertificate > mxCert;
-    bool mbValid;
+    bool const mbValid;
 
     CertPath_UserData( css::uno::Reference< css::security::XCertificate > const & xCert, bool bValid):
         mxCert(xCert),

xmlsecurity/source/framework/elementcollector.hxx

@@ -44,13 +44,13 @@ private:
      * BEFOREMODIFY - this ElementCollector must notify before any
      *                    internal modification happens.
      */
-    css::xml::crypto::sax::ElementMarkPriority m_nPriority;
+    css::xml::crypto::sax::ElementMarkPriority const m_nPriority;
 
     /*
      * the modify flag, representing whether which elementcollector will
      * modify its data.
      */
-    bool m_bToModify;
+    bool const m_bToModify;
 
     /* the notify enable flag, see notifyListener method */
     bool m_bAbleToNotify;

xmlsecurity/source/framework/elementmark.hxx

@@ -44,7 +44,7 @@ protected:
     sal_Int32 m_nSecurityId;
 
     /* the buffer Id */
-    sal_Int32 m_nBufferId;
+    sal_Int32 const m_nBufferId;
 
     /*
      * the type value, is one of following values:

xmlsecurity/source/xmlsec/nss/digestcontext.hxx

@@ -31,8 +31,8 @@ private:
     ::osl::Mutex m_aMutex;
 
     PK11Context* m_pContext;
-    sal_Int32 m_nDigestLength;
-    bool m_b1KData;
+    sal_Int32 const m_nDigestLength;
+    bool const m_b1KData;
     sal_Int32 m_nDigested;
 
     bool m_bDisposed;

xmlsecurity/source/xmlsec/nss/secerror.cxx

@@ -29,7 +29,7 @@
 #include <sal/types.h>
 
 struct ErrDesc {
-    PRErrorCode  errNum;
+    PRErrorCode const errNum;
     const char * errString;
 };
 

xmlsecurity/source/xmlsec/xmlelementwrapper_xmlsecimpl.hxx

@@ -51,7 +51,7 @@ class XSECXMLSEC_DLLPUBLIC XMLElementWrapper_XmlSecImpl : public cppu::WeakImplH
 {
 private:
     /* the libxml2 node wrapped by this object */
-    xmlNodePtr m_pElement;
+    xmlNodePtr const m_pElement;
 
 public:
     explicit XMLElementWrapper_XmlSecImpl(const xmlNodePtr pNode);