rewrite a horrible perl script to saner form

The old form duplicated the last line of the processed file if the key
was not present. This was not a problem before we added Unity-specific
keys to the desktop files, because all keys were always present...

Change-Id: Ifef6a90250fd303b913807944c7a23e04a5aafb1

sysui/desktop/share/translate.pl

@@ -29,15 +29,9 @@ eval 'exec perl -wS $0 ${1+"$@"}'
 #
 #*************************************************************************
 
-
-#*********************************************************************
-#
-# main
-#
-
 my ($prefix, $ext, $key);
-$productname = "LibreOffice";
-$workdir = ".";
+my $productname = "LibreOffice";
+my $workdir = ".";
 
 while ($_ = $ARGV[0], /^-/) {
     shift;
@@ -65,37 +59,61 @@ while ($_ = $ARGV[0], /^-/) {
 }
 
 # hack for unity section
-$outkey = $key;
+my $outkey = $key;
 if ( $outkey eq "UnityQuicklist" ) {
     $outkey = "Name";
 }
 
+my %templates;
+
 # open input file
 unless (open(SOURCE, $ARGV[0])) {
     print STDERR "Can't open $ARGV[0] file: $!\n";
     return;
 }
 
+# currently read template
+my $template;
 
-# For every section in the specified ulf file there should exist
-# a template file in $workdir ..
+# read ulf file
 while (<SOURCE>) {
-    $line = $_;
+    my $line = $_;
 
     if ( "[" eq substr($line, 0, 1) ) {
-        # Pass the tail of the template to the output file
-        while (<TEMPLATE>) {
-            print OUTFILE;
-        }
+        $template = substr($line, 1, index($line,"]")-1);
+        my %entry;
+        # For every section in the specified ulf file there should exist
+        # a template file in $workdir ..
+        $entry{'outfile'} = "$workdir/$prefix$template.$ext";
+        $templates{$template} = \%entry;
+    } else {
+        # split locale = "value" into 2 strings
+        my ($locale, $value) = split(' = ', $line);
 
-        close(TEMPLATE);
+        if ( $locale ne $line ) {
+            # replace en-US with en
+            $locale=~s/en-US/en/;
 
-        if (close(OUTFILE)) {
-            system "mv -f $outfile.tmp $outfile\n";
+            # use just anything inside the ""
+            $value = substr($value, index($value, "\"") + 1, rindex($value, "\"") - 1);
+
+            # replace resource placeholder
+            $value=~s/%PRODUCTNAME/$productname/g;
+
+            $locale=~s/-/_/;
+
+            $templates{$template}->{'locale'} = $locale;
+            $templates{$template}->{'value'} = $value;
+        }
     }
+}
 
-        $_ = substr($line, 1, index($line,"]")-1);
-        $outfile = "$workdir/$prefix$_.$ext";
+close(SOURCE);
+
+# process templates
+foreach $template (keys %templates) {
+    my $outfile = $templates{$template}->{'outfile'};
+    print "processing template $template in $outfile\n";
 
     # open the template file - ignore sections for which no
     # templates exist
@@ -110,32 +128,17 @@ while (<SOURCE>) {
         exit -1;
     }
 
-        # Pass the head of the template to the output file
-KEY:    while (<TEMPLATE>) {
-            $keyline = $_;
-            last KEY if (/$key/);
-            print OUTFILE;
-        }
-        $keyline=~s/^$key/$outkey/;
+    # emit the template to the output file
+    while (<TEMPLATE>) {
+        my $keyline = $_;
+        $keyline =~ s/^$key/$outkey/;
         print OUTFILE $keyline;
-
-    } else {
-        # split locale = "value" into 2 strings
-        ($locale, $value) = split(' = ', $line);
-
-        if ( $locale ne $line ) {
-            # replace en-US with en
-            $locale=~s/en-US/en/;
-
-            # use just anything inside the ""
-            $value = substr($value, index($value, "\"") + 1, rindex($value, "\"") - 1);
-
-            # replace resource placeholder
-            $value=~s/%PRODUCTNAME/$productname/g;
-
-            $locale=~s/-/_/;
-
-            if (not $value eq '') {
+        if (/$key/) {
+            my $locale = $templates{$template}->{'locale'};
+            my $value = $templates{$template}->{'value'};
+            print "locale is $locale\n";
+            print "value is $value\n";
+            if ($value) {
                 if ($ext eq "desktop") {
                     print OUTFILE "$outkey\[$locale\]=$value\n";
                 } else {
@@ -144,14 +147,10 @@ KEY:    while (<TEMPLATE>) {
             }
         }
     }
-}
 
-while (<TEMPLATE>) {
-    print OUTFILE;
-}
+    close(TEMPLATE);
 
-if (close(OUTFILE)) {
+    if (close(OUTFILE)) {
         system "mv -f $outfile.tmp $outfile\n";
+    }
 }
-
-close(TEMPLATE);