Better only call RestoreInvisibleContent if previously removed

Change-Id: I229db9567771a4967065d81fa99fee2c23dbcb3e

sw/inc/docsh.hxx

@@ -80,6 +80,10 @@ class SW_DLLPUBLIC SwDocShell: public SfxObjectShell, public SfxListener
     sal_Int16               mnUpdateDocMode;    ///< contains the com::sun::star::document::UpdateDocMode
     bool                    bIsATemplate;      ///< prevent nested calls of UpdateFontList
 
+    bool mbRemovedInvisibleContent;
+        ///< whether SID_MAIL_PREPAREEXPORT removed content that
+        ///< SID_MAIL_EXPORT_FINISHED needs to restore
+
     /// Methods for access to doc.
     SAL_DLLPRIVATE void                  AddLink();
     SAL_DLLPRIVATE void                  RemoveLink();

sw/source/uibase/app/docsh2.cxx

@@ -837,7 +837,9 @@ void SwDocShell::Execute(SfxRequest& rReq)
             mpDoc->getIDocumentFieldsAccess().UpdateFlds( NULL, false );
             mpDoc->getIDocumentLinksAdministration().EmbedAllLinks();
 
-            if(officecfg::Office::Common::ExternalMailer::Hidden::get())
+            mbRemovedInvisibleContent
+                = officecfg::Office::Common::ExternalMailer::Hidden::get();
+            if(mbRemovedInvisibleContent)
                 mpDoc->RemoveInvisibleContent();
             if(mpWrtShell)
                 mpWrtShell->EndAllAction();
@@ -848,7 +850,8 @@ void SwDocShell::Execute(SfxRequest& rReq)
         {
                 if(mpWrtShell)
                     mpWrtShell->StartAllAction();
-                //try to undo the removal of invisible content
+                //try to undo any removal of invisible content
+                if(mbRemovedInvisibleContent)
                     mpDoc->RestoreInvisibleContent();
                 if(mpWrtShell)
                     mpWrtShell->EndAllAction();

sw/source/uibase/app/docshini.cxx

@@ -328,7 +328,8 @@ SwDocShell::SwDocShell( SfxObjectCreateMode eMode ) :
     mpWrtShell( 0 ),
     mpOLEChildList( 0 ),
     mnUpdateDocMode(document::UpdateDocMode::ACCORDING_TO_CONFIG),
-    bIsATemplate(false)
+    bIsATemplate(false),
+    mbRemovedInvisibleContent(false)
 {
     Init_Impl();
 }
@@ -343,7 +344,8 @@ SwDocShell::SwDocShell( const sal_uInt64 i_nSfxCreationFlags ) :
     mpWrtShell( 0 ),
     mpOLEChildList( 0 ),
     mnUpdateDocMode(document::UpdateDocMode::ACCORDING_TO_CONFIG),
-    bIsATemplate(false)
+    bIsATemplate(false),
+    mbRemovedInvisibleContent(false)
 {
     Init_Impl();
 }
@@ -358,7 +360,8 @@ SwDocShell::SwDocShell( SwDoc *pD, SfxObjectCreateMode eMode ):
     mpWrtShell( 0 ),
     mpOLEChildList( 0 ),
     mnUpdateDocMode(document::UpdateDocMode::ACCORDING_TO_CONFIG),
-    bIsATemplate(false)
+    bIsATemplate(false),
+    mbRemovedInvisibleContent(false)
 {
     Init_Impl();
 }