Fix accidental mis-uses of VclPtr address-of operator

Change-Id: I3a82423378d3198a25f90ddfbf42af55d85c96fb
(cherry picked from commit 668408fa, w/o the
accidentally included sw/htmlexport-swobjects.patch)

cui/source/dialogs/dlgname.cxx

@@ -41,7 +41,7 @@ SvxNameDialog::SvxNameDialog( vcl::Window* pWindow, const OUString& rName, const
     pFtDescription->SetText( rDesc );
     pEdtName->SetText( rName );
     pEdtName->SetSelection(Selection(SELECTION_MIN, SELECTION_MAX));
-    ModifyHdl(&pEdtName);
+    ModifyHdl(pEdtName.get());
     pEdtName->SetModifyHdl(LINK(this, SvxNameDialog, ModifyHdl));
 }
 
@@ -82,7 +82,7 @@ SvxObjectNameDialog::SvxObjectNameDialog(
 
     // activate name
     pEdtName->SetSelection(Selection(SELECTION_MIN, SELECTION_MAX));
-    ModifyHdl(&pEdtName);
+    ModifyHdl(pEdtName.get());
     pEdtName->SetModifyHdl(LINK(this, SvxObjectNameDialog, ModifyHdl));
 }
 

dbaccess/source/ui/app/AppSwapWindow.cxx

@@ -118,7 +118,7 @@ void OApplicationSwapWindow::clearSelection()
     SvxIconChoiceCtrlEntry* pEntry = m_aIconControl->GetSelectedEntry(nPos);
     if ( pEntry )
         m_aIconControl->InvalidateEntry(pEntry);
-    m_aIconControl->GetClickHdl().Call(&m_aIconControl);
+    m_aIconControl->GetClickHdl().Call(m_aIconControl.get());
 }
 
 void OApplicationSwapWindow::createIconAutoMnemonics( MnemonicGenerator& _rMnemonics )

framework/source/classes/fwktabwindow.cxx

@@ -338,7 +338,7 @@ FwkTabPage* FwkTabWindow::AddTabPage( sal_Int32 nIndex, const uno::Sequence< bea
 void FwkTabWindow::ActivatePage( sal_Int32 nIndex )
 {
     m_aTabCtrl->SetCurPageId( static_cast< sal_uInt16 >( nIndex ) );
-    ActivatePageHdl( &m_aTabCtrl );
+    ActivatePageHdl( m_aTabCtrl.get() );
 }
 
 void FwkTabWindow::RemovePage( sal_Int32 nIndex )

sc/source/ui/sidebar/CellLineStyleControl.cxx

@@ -118,7 +118,7 @@ void CellLineStyleControl::SetAllNoSel()
 
 IMPL_LINK(CellLineStyleControl, VSSelectHdl, void *, pControl)
 {
-    if(pControl == &maCellLineStyleValueSet)
+    if(pControl == maCellLineStyleValueSet.get())
     {
         const sal_uInt16 iPos(maCellLineStyleValueSet->GetSelectItemId());
         SvxLineItem aLineItem(SID_FRAME_LINESTYLE);

svtools/source/control/filectrl.cxx

@@ -246,7 +246,7 @@ void FileControl::ImplBrowseFile( )
                 if ( aObj.GetProtocol() == INetProtocol::File )
                     aNewText = aObj.PathToFileName();
                 SetText( aNewText );
-                maEdit->GetModifyHdl().Call( &maEdit );
+                maEdit->GetModifyHdl().Call( maEdit.get() );
             }
         }
     }

svx/source/sidebar/text/TextCharacterSpacingControl.cxx

@@ -308,7 +308,7 @@ IMPL_LINK(TextCharacterSpacingControl, VSSelHdl, void *, pControl)
 {
     mnLastCus = SPACING_CLOSE_BY_CLICK_ICON;
 
-    if(pControl == &maVSSpacing)
+    if(pControl == maVSSpacing.get())
     {
         sal_uInt16 iPos = maVSSpacing->GetSelectItemId();
         short nKern = 0;

svx/source/sidebar/text/TextUnderlineControl.cxx

@@ -214,7 +214,7 @@ void TextUnderlineControl::Rearrange(FontUnderline eLine)
 
 IMPL_LINK(TextUnderlineControl, VSSelectHdl, void *, pControl)
 {
-    if ( pControl == &maVSUnderline )
+    if ( pControl == maVSUnderline.get() )
     {
         const sal_uInt16 iPos = maVSUnderline->GetSelectItemId();
         const FontUnderline eUnderline = ( iPos == 0 )

sw/source/ui/config/mailconfigpage.cxx

@@ -191,7 +191,7 @@ void SwMailConfigPage::Reset( const SfxItemSet* /*rSet*/ )
 
     m_pReplyToED->SetText(m_pConfigItem->GetMailReplyTo()) ;
     m_pReplyToCB->Check(m_pConfigItem->IsMailReplyTo());
-    m_pReplyToCB->GetClickHdl().Call(&m_pReplyToCB);
+    m_pReplyToCB->GetClickHdl().Call(m_pReplyToCB.get());
 
     m_pServerED->SetText(m_pConfigItem->GetMailServer());
     m_pPortNF->SetValue(m_pConfigItem->GetMailPort());