Kaydet (Commit) dc337752 authored tarafından Noel Grandin's avatar Noel Grandin

use rtl::Reference in ODatabaseForm

rather than manual acquire/release

Change-Id: Ic5f013b7e4cafc597c659c61fbf568adccfd806a
üst 9c6bdac8
...@@ -258,7 +258,6 @@ ODatabaseForm::ODatabaseForm(const Reference<XComponentContext>& _rxContext) ...@@ -258,7 +258,6 @@ ODatabaseForm::ODatabaseForm(const Reference<XComponentContext>& _rxContext)
,m_aErrorListeners(m_aMutex) ,m_aErrorListeners(m_aMutex)
,m_aResetListeners( *this, m_aMutex ) ,m_aResetListeners( *this, m_aMutex )
,m_aPropertyBagHelper( *this ) ,m_aPropertyBagHelper( *this )
,m_pAggregatePropertyMultiplexer(nullptr)
,m_aParameterManager( m_aMutex, _rxContext ) ,m_aParameterManager( m_aMutex, _rxContext )
,m_aFilterManager() ,m_aFilterManager()
,m_pLoadTimer(nullptr) ,m_pLoadTimer(nullptr)
...@@ -294,7 +293,6 @@ ODatabaseForm::ODatabaseForm( const ODatabaseForm& _cloneSource ) ...@@ -294,7 +293,6 @@ ODatabaseForm::ODatabaseForm( const ODatabaseForm& _cloneSource )
,m_aErrorListeners( m_aMutex ) ,m_aErrorListeners( m_aMutex )
,m_aResetListeners( *this, m_aMutex ) ,m_aResetListeners( *this, m_aMutex )
,m_aPropertyBagHelper( *this ) ,m_aPropertyBagHelper( *this )
,m_pAggregatePropertyMultiplexer( nullptr )
,m_aParameterManager( m_aMutex, _cloneSource.m_xContext ) ,m_aParameterManager( m_aMutex, _cloneSource.m_xContext )
,m_aFilterManager() ,m_aFilterManager()
,m_pLoadTimer( nullptr ) ,m_pLoadTimer( nullptr )
...@@ -392,10 +390,9 @@ void ODatabaseForm::impl_construct() ...@@ -392,10 +390,9 @@ void ODatabaseForm::impl_construct()
// listen for the properties, important for Parameters // listen for the properties, important for Parameters
if ( m_xAggregateSet.is() ) if ( m_xAggregateSet.is() )
{ {
m_pAggregatePropertyMultiplexer = new OPropertyChangeMultiplexer(this, m_xAggregateSet, false); m_xAggregatePropertyMultiplexer = new OPropertyChangeMultiplexer(this, m_xAggregateSet, false);
m_pAggregatePropertyMultiplexer->acquire(); m_xAggregatePropertyMultiplexer->addProperty(PROPERTY_COMMAND);
m_pAggregatePropertyMultiplexer->addProperty(PROPERTY_COMMAND); m_xAggregatePropertyMultiplexer->addProperty(PROPERTY_ACTIVE_CONNECTION);
m_pAggregatePropertyMultiplexer->addProperty(PROPERTY_ACTIVE_CONNECTION);
} }
{ {
...@@ -429,11 +426,10 @@ ODatabaseForm::~ODatabaseForm() ...@@ -429,11 +426,10 @@ ODatabaseForm::~ODatabaseForm()
m_aWarnings.setExternalWarnings( nullptr ); m_aWarnings.setExternalWarnings( nullptr );
if (m_pAggregatePropertyMultiplexer) if (m_xAggregatePropertyMultiplexer.is())
{ {
m_pAggregatePropertyMultiplexer->dispose(); m_xAggregatePropertyMultiplexer->dispose();
m_pAggregatePropertyMultiplexer->release(); m_xAggregatePropertyMultiplexer.clear();
m_pAggregatePropertyMultiplexer = nullptr;
} }
} }
...@@ -1252,8 +1248,8 @@ bool ODatabaseForm::executeRowSet(::osl::ResettableMutexGuard& _rClearForNotifie ...@@ -1252,8 +1248,8 @@ bool ODatabaseForm::executeRowSet(::osl::ResettableMutexGuard& _rClearForNotifie
void ODatabaseForm::disposing() void ODatabaseForm::disposing()
{ {
if (m_pAggregatePropertyMultiplexer) if (m_xAggregatePropertyMultiplexer.is())
m_pAggregatePropertyMultiplexer->dispose(); m_xAggregatePropertyMultiplexer->dispose();
if (m_bLoaded) if (m_bLoaded)
unload(); unload();
......
...@@ -73,6 +73,7 @@ ...@@ -73,6 +73,7 @@
#include <cppuhelper/implbase12.hxx> #include <cppuhelper/implbase12.hxx>
#include <cppuhelper/implbase4.hxx> #include <cppuhelper/implbase4.hxx>
#include <cppuhelper/implbase7.hxx> #include <cppuhelper/implbase7.hxx>
#include <rtl/ref.hxx>
namespace com { namespace sun { namespace star { namespace sdbc { namespace com { namespace sun { namespace star { namespace sdbc {
class SQLException; class SQLException;
...@@ -173,7 +174,7 @@ class ODatabaseForm :public OFormComponents ...@@ -173,7 +174,7 @@ class ODatabaseForm :public OFormComponents
PropertyBagHelper m_aPropertyBagHelper; PropertyBagHelper m_aPropertyBagHelper;
::dbtools::WarningsContainer m_aWarnings; ::dbtools::WarningsContainer m_aWarnings;
OPropertyChangeMultiplexer* m_pAggregatePropertyMultiplexer; rtl::Reference<OPropertyChangeMultiplexer> m_xAggregatePropertyMultiplexer;
// Management of the Control Groups // Management of the Control Groups
rtl::Reference<OGroupManager> m_pGroupManager; rtl::Reference<OGroupManager> m_pGroupManager;
::dbtools::ParameterManager m_aParameterManager; ::dbtools::ParameterManager m_aParameterManager;
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment