Skip to content

C
core
Kaydet (Commit) e1755ac8 authored tarafından Noel Grandin's avatar Noel Grandin
Dosyalara gözat
Seçenekler

loplugin:countusersofdefaultparams in connectivity 

Change-Id: Ia613257f2de1395c6629c1c37026ed48d4b927c8
Reviewed-on: https://gerrit.libreoffice.org/45854Tested-by: 's avatarJenkins <ci@libreoffice.org>
Reviewed-by: 's avatarNoel Grandin <noel.grandin@collabora.co.uk>
üst c7e5c7da
Show whitespace changes
Inline Side-by-side
Showing with 49 additions and 48 deletions
connectivity/source/cpool/ZConnectionPool.cxx
Dosyayı görüntüle @ e1755ac8
......@@ -82,7 +82,7 @@ struct TRemoveEventListenerFunctor
OConnectionPool* m_pConnectionPool;
bool m_bDispose;
TRemoveEventListenerFunctor(OConnectionPool* _pConnectionPool,bool _bDispose = false)
TRemoveEventListenerFunctor(OConnectionPool* _pConnectionPool, bool _bDispose)
: m_pConnectionPool(_pConnectionPool)
,m_bDispose(_bDispose)
{
......
connectivity/source/drivers/evoab2/NTable.hxx
Dosyayı görüntüle @ e1755ac8
......@@ -38,9 +38,9 @@ namespace connectivity
OEvoabConnection* _pConnection,
const OUString& Name,
const OUString& Type,
const OUString& Description = OUString(),
const OUString& SchemaName = OUString(),
const OUString& CatalogName = OUString()
const OUString& Description,
const OUString& SchemaName,
const OUString& CatalogName
);
OEvoabConnection* getConnection() { return m_pConnection;}
......
connectivity/source/drivers/evoab2/NTables.cxx
Dosyayı görüntüle @ e1755ac8
......@@ -63,6 +63,7 @@ ObjectType OEvoabTables::createObject(const OUString& aName)
aName,
xRow->getString(4),
xRow->getString(5),
"",
"");
xRet = pRet;
}
......
connectivity/source/drivers/firebird/Columns.cxx
Dosyayı görüntüle @ e1755ac8
......@@ -29,7 +29,8 @@ Columns::Columns(Table& rTable,
OColumnsHelper(rTable,
true, // TODO: is this case sensitivity?
rMutex,
rVector)
rVector,
/*bUseHardRef*/true)
{
OColumnsHelper::setParent(&rTable);
}
......
connectivity/source/inc/OColumn.hxx
Dosyayı görüntüle @ e1755ac8
......@@ -71,12 +71,11 @@ namespace connectivity
OColumn(const OUString &_aTableName,
const OUString &_aColumnName,
sal_Int32 _aNullable=0,
sal_Int32 _aColumnDisplaySize=0,
sal_Int32 _aPrecision=0,
sal_Int32 _aScale=0,
sal_Int32 _aColumnType=0)
sal_Int32 _aNullable,
sal_Int32 _aColumnDisplaySize,
sal_Int32 _aPrecision,
sal_Int32 _aScale,
sal_Int32 _aColumnType)
: m_TableName(_aTableName),
m_ColumnName(_aColumnName),
m_ColumnLabel(),
......
connectivity/source/inc/component/CTable.hxx
Dosyayı görüntüle @ e1755ac8
......@@ -49,9 +49,9 @@ namespace connectivity
OComponentTable( sdbcx::OCollection* _pTables,file::OConnection* _pConnection,
const OUString& Name,
const OUString& Type,
const OUString& Description = OUString(),
const OUString& SchemaName = OUString(),
const OUString& CatalogName = OUString()
const OUString& Description,
const OUString& SchemaName,
const OUString& CatalogName
);
virtual void refreshColumns() override;
......
connectivity/source/inc/dbase/dindexnode.hxx
Dosyayı görüntüle @ e1755ac8
......@@ -51,8 +51,8 @@ namespace connectivity
public:
ONDXKey();
ONDXKey(const ORowSetValue& rVal, sal_Int32 eType, sal_uInt32 nRec);
ONDXKey(const OUString& aStr, sal_uInt32 nRec = 0);
ONDXKey(double aVal, sal_uInt32 nRec = 0);
ONDXKey(const OUString& aStr, sal_uInt32 nRec);
ONDXKey(double aVal, sal_uInt32 nRec);
inline ONDXKey(const ONDXKey& rKey);
......@@ -177,7 +177,7 @@ namespace connectivity
void SearchAndReplace(const ONDXKey& rSearch, ONDXKey const & rReplace);
protected:
ONDXPage(ODbaseIndex& rIndex, sal_uInt32 nPos, ONDXPage* = nullptr);
ONDXPage(ODbaseIndex& rIndex, sal_uInt32 nPos, ONDXPage*);
~ONDXPage();
void ReleaseRef();
......
connectivity/source/inc/file/FTable.hxx
Dosyayı görüntüle @ e1755ac8
......@@ -58,9 +58,9 @@ namespace connectivity
OFileTable( sdbcx::OCollection* _pTables,OConnection* _pConnection,
const OUString& Name,
const OUString& Type,
const OUString& Description = OUString(),
const OUString& SchemaName = OUString(),
const OUString& CatalogName = OUString()
const OUString& Description,
const OUString& SchemaName,
const OUString& CatalogName
);
//XInterface
......
connectivity/source/inc/file/fcode.hxx
Dosyayı görüntüle @ e1755ac8
......@@ -245,7 +245,7 @@ namespace connectivity
const sal_Unicode cEscape;
public:
OOp_LIKE(const sal_Unicode cEsc = L'\0'):cEscape(cEsc){};
OOp_LIKE(const sal_Unicode cEsc):cEscape(cEsc){};
virtual bool operate(const OOperand*, const OOperand*) const override;
};
......@@ -254,7 +254,7 @@ namespace connectivity
{
public:
public:
OOp_NOTLIKE(const sal_Unicode cEsc = L'\0'):OOp_LIKE(cEsc){};
OOp_NOTLIKE(const sal_Unicode cEsc):OOp_LIKE(cEsc){};
virtual bool operate(const OOperand*, const OOperand*) const override;
};
......
connectivity/source/inc/hsqldb/HTable.hxx
Dosyayı görüntüle @ e1755ac8
......@@ -77,10 +77,10 @@ namespace connectivity
const css::uno::Reference< css::sdbc::XConnection >& _xConnection,
const OUString& Name,
const OUString& Type,
const OUString& Description = OUString(),
const OUString& SchemaName = OUString(),
const OUString& CatalogName = OUString(),
sal_Int32 _nPrivileges = 0
const OUString& Description,
const OUString& SchemaName,
const OUString& CatalogName,
sal_Int32 _nPrivileges
);
// ODescriptor
......
connectivity/source/inc/mysql/YTable.hxx
Dosyayı görüntüle @ e1755ac8
......@@ -84,10 +84,10 @@ namespace connectivity
const css::uno::Reference< css::sdbc::XConnection >& _xConnection,
const OUString& Name,
const OUString& Type,
const OUString& Description = OUString(),
const OUString& SchemaName = OUString(),
const OUString& CatalogName = OUString(),
sal_Int32 _nPrivileges = 0
const OUString& Description,
const OUString& SchemaName,
const OUString& CatalogName,
sal_Int32 _nPrivileges
);
// ODescriptor
......
dbaccess/source/core/api/OptimisticSet.cxx
Dosyayı görüntüle @ e1755ac8
......@@ -460,7 +460,7 @@ void OptimisticSet::mergeColumnValues(sal_Int32 i_nColumnIndex,ORowSetValueVecto
{
io_aRow[aJoinIter->second] = io_aRow[i_nColumnIndex];
io_aInsertRow[aJoinIter->second] = io_aInsertRow[i_nColumnIndex];
io_aRow[aJoinIter->second].setModified();
io_aRow[aJoinIter->second].setModified(true);
o_aChangedColumns.push_back(aJoinIter->second);
}
}
......@@ -496,7 +496,7 @@ bool OptimisticSet::updateColumnValues(const ORowSetValueVector::Vector& io_aCac
if ( aCol.second.sTableName == sTableName )
{
io_aRow[aCol.second.nPosition] = io_aCachedRow[aCol.second.nPosition];
io_aRow[aCol.second.nPosition].setModified();
io_aRow[aCol.second.nPosition].setModified(true);
}
}
}
......@@ -537,7 +537,7 @@ bool OptimisticSet::columnValuesUpdated(ORowSetValueVector::Vector& o_aCachedRow
if ( aCol2.second.sTableName == sTableName )
{
o_aCachedRow[aCol2.second.nPosition] = i_aRow[aCol2.second.nPosition];
o_aCachedRow[aCol2.second.nPosition].setModified();
o_aCachedRow[aCol2.second.nPosition].setModified(true);
}
}
fillMissingValues(o_aCachedRow);
......@@ -609,7 +609,7 @@ void OptimisticSet::fillMissingValues(ORowSetValueVector::Vector& io_aRow) const
if ( aColIter->second.sTableName == aSqlIter->first )
{
io_aRow[aColIter->second.nPosition].fill(i++, aColIter->second.nType, xRow);
io_aRow[aColIter->second.nPosition].setModified();
io_aRow[aColIter->second.nPosition].setModified(true);
}
}
}
......
dbaccess/source/core/api/RowSetCache.cxx
Dosyayı görüntüle @ e1755ac8
......@@ -562,7 +562,7 @@ void ORowSetCache::updateNull(sal_Int32 columnIndex,ORowSetValueVector::Vector&
{
rInsert[columnIndex].setBound(true);
rInsert[columnIndex].setNull();
rInsert[columnIndex].setModified();
rInsert[columnIndex].setModified(true);
io_aRow[columnIndex].setNull();
m_xCacheSet->mergeColumnValues(columnIndex,rInsert,io_aRow,o_ChangedColumns);
......@@ -582,7 +582,7 @@ void ORowSetCache::updateValue(sal_Int32 columnIndex,const ORowSetValue& x
{
rInsert[columnIndex].setBound(true);
rInsert[columnIndex] = x;
rInsert[columnIndex].setModified();
rInsert[columnIndex].setModified(true);
io_aRow[columnIndex] = rInsert[columnIndex];
m_xCacheSet->mergeColumnValues(columnIndex,rInsert,io_aRow,o_ChangedColumns);
......@@ -604,7 +604,7 @@ void ORowSetCache::updateCharacterStream( sal_Int32 columnIndex, const Reference
ORowSetValueVector::Vector& rInsert = (*m_aInsertRow)->get();
rInsert[columnIndex].setBound(true);
rInsert[columnIndex] = aSeq;
rInsert[columnIndex].setModified();
rInsert[columnIndex].setModified(true);
io_aRow[columnIndex] = makeAny(x);
m_xCacheSet->mergeColumnValues(columnIndex,rInsert,io_aRow,o_ChangedColumns);
......@@ -625,7 +625,7 @@ void ORowSetCache::updateObject( sal_Int32 columnIndex, const Any& x
{
rInsert[columnIndex].setBound(true);
rInsert[columnIndex] = aTemp;
rInsert[columnIndex].setModified();
rInsert[columnIndex].setModified(true);
io_aRow[columnIndex] = rInsert[columnIndex];
m_xCacheSet->mergeColumnValues(columnIndex,rInsert,io_aRow,o_ChangedColumns);
......@@ -647,7 +647,7 @@ void ORowSetCache::updateNumericObject( sal_Int32 columnIndex, const Any& x
{
rInsert[columnIndex].setBound(true);
rInsert[columnIndex] = aTemp;
rInsert[columnIndex].setModified();
rInsert[columnIndex].setModified(true);
io_aRow[columnIndex] = rInsert[columnIndex];
m_xCacheSet->mergeColumnValues(columnIndex,rInsert,io_aRow,o_ChangedColumns);
......
include/connectivity/FValue.hxx
Dosyayı görüntüle @ e1755ac8
......@@ -381,10 +381,10 @@ namespace connectivity
void setBound(bool _bBound) { m_bBound = _bBound; }
bool isModified() const { return m_bModified; }
void setModified(bool _bMod=true) { m_bModified = _bMod; }
void setModified(bool _bMod) { m_bModified = _bMod; }
bool isSigned() const { return m_bSigned; }
void setSigned(bool _bSig=true);
void setSigned(bool _bSig);
sal_Int32 getTypeKind() const { return m_eTypeKind; }
void setTypeKind(sal_Int32 _eType);
......
include/connectivity/TColumnsHelper.hxx
Dosyayı görüntüle @ e1755ac8
......@@ -48,7 +48,7 @@ namespace connectivity
,bool _bCase
,::osl::Mutex& _rMutex
,const TStringVector &_rVector
,bool _bUseHardRef = true
,bool _bUseHardRef
);
virtual ~OColumnsHelper() override;
......
include/connectivity/dbexception.hxx
Dosyayı görüntüle @ e1755ac8
......@@ -309,7 +309,7 @@ OOO_DLLPUBLIC_DBTOOLS void throwSQLException(
const OUString& _rMessage,
const OUString& _rSQLState,
const css::uno::Reference< css::uno::XInterface >& _rxContext,
const sal_Int32 _nErrorCode = 0
const sal_Int32 _nErrorCode
);
......
include/connectivity/dbtools.hxx
Dosyayı görüntüle @ e1755ac8
......@@ -704,9 +704,9 @@ namespace dbtools
const OUString& _rName,
bool _bCase,
bool _bQueryForInfo,
bool _bIsAutoIncrement = false,
bool _bIsCurrency = false,
sal_Int32 _nDataType = css::sdbc::DataType::OTHER);
bool _bIsAutoIncrement,
bool _bIsCurrency,
sal_Int32 _nDataType);
/** tries to locate the corresponding DataDefinitionSupplier for the given url and connection
@param _rsUrl
......@@ -803,7 +803,7 @@ namespace dbtools
OOO_DLLPUBLIC_DBTOOLS bool isAggregateColumn(
const css::uno::Reference< css::container::XNameAccess > &_xColumns,
const OUString &_sName,
bool whenNotFound = false
bool whenNotFound
);
/** is this column an aggregate?
......
include/connectivity/sqlparse.hxx
Dosyayı görüntüle @ e1755ac8
......@@ -207,7 +207,7 @@ namespace connectivity
// RuleId with enum, far more efficient
static sal_uInt32 RuleID(OSQLParseNode::Rule eRule);
// compares the _sFunctionName with all known function names and return the DataType of the return value
static sal_Int32 getFunctionReturnType(const OUString& _sFunctionName, const IParseContext* pContext = nullptr);
static sal_Int32 getFunctionReturnType(const OUString& _sFunctionName, const IParseContext* pContext);
// returns the type for a parameter in a given function name
static sal_Int32 getFunctionParameterType(sal_uInt32 _nTokenId,sal_uInt32 _nPos);
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment