Kaydet (Commit) e1c9efce authored tarafından Caolán McNamara's avatar Caolán McNamara

loplugin:cstylecast

Change-Id: I2d03c5054ef1b863052b221c0740ed3bb993600e
üst 3887e843
...@@ -463,7 +463,8 @@ void ScRangeData::MakeValidName( OUString& rName ) ...@@ -463,7 +463,8 @@ void ScRangeData::MakeValidName( OUString& rName )
ScAddress::Details details( static_cast<FormulaGrammar::AddressConvention>( nConv ) ); ScAddress::Details details( static_cast<FormulaGrammar::AddressConvention>( nConv ) );
// Don't check Parse on VALID, any partial only VALID may result in // Don't check Parse on VALID, any partial only VALID may result in
// #REF! during compile later! // #REF! during compile later!
while ( (bool)aRange.Parse( rName, nullptr, details) || (bool)aAddr.Parse( rName, nullptr, details ) ) while (aRange.Parse(rName, nullptr, details) != ScRefFlags::ZERO ||
aAddr.Parse(rName, nullptr, details) != ScRefFlags::ZERO)
{ {
// Range Parse is partially valid also with invalid sheet name, // Range Parse is partially valid also with invalid sheet name,
// Address Parse dito, during compile name would generate a #REF! // Address Parse dito, during compile name would generate a #REF!
...@@ -498,9 +499,12 @@ bool ScRangeData::IsNameValid( const OUString& rName, ScDocument* pDoc ) ...@@ -498,9 +499,12 @@ bool ScRangeData::IsNameValid( const OUString& rName, ScDocument* pDoc )
ScAddress::Details details( static_cast<FormulaGrammar::AddressConvention>( nConv ) ); ScAddress::Details details( static_cast<FormulaGrammar::AddressConvention>( nConv ) );
// Don't check Parse on VALID, any partial only VALID may result in // Don't check Parse on VALID, any partial only VALID may result in
// #REF! during compile later! // #REF! during compile later!
if ( (bool)aRange.Parse( rName, pDoc, details) || (bool)aAddr.Parse( rName, pDoc, details) ) if (aRange.Parse(rName, pDoc, details) != ScRefFlags::ZERO ||
aAddr.Parse(rName, pDoc, details) != ScRefFlags::ZERO )
{
return false; return false;
} }
}
return true; return true;
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment