loplugin:passstringbyref (and some dead code)

Change-Id: I96f5b58ac000e7535b6759af04be60e738aa2b09

fpicker/source/aqua/FilterHelper.hxx

@@ -112,11 +112,7 @@ private:
     OUString m_aCurrentFilter;
     NSStringList *m_pFilterNames;
 
-    int implAddFilter( const OUString rFilter, const OUStringList rSuffixList);
-    int implAddFilterGroup( const OUString rFilter,
-                            const ::com::sun::star::uno::Sequence< ::com::sun::star::beans::StringPair>& _rFilters );
-
-    sal_Bool FilterNameExists( const OUString rTitle );
+    sal_Bool FilterNameExists( const OUString& rTitle );
     sal_Bool FilterNameExists( const UnoFilterList& _rGroupedFilters );
 
     void ensureFilterList( const OUString& _rInitialCurrentFilter );

fpicker/source/aqua/FilterHelper.mm

@@ -92,7 +92,7 @@ isFilterString( const rtl::OUString& rFilterString, const char *pMatch )
 
 
 static rtl::OUString
-shrinkFilterName( const rtl::OUString aFilterName, bool bAllowNoStar = false )
+shrinkFilterName( const rtl::OUString& aFilterName, bool bAllowNoStar = false )
 {
     // DBG_PRINT_ENTRY(CLASS_NAME, "shrinkFilterName", "filterName", aFilterName);
 
@@ -130,7 +130,7 @@ protected:
         const rtl::OUString rTitle;
 
 public:
-        FilterTitleMatch( const rtl::OUString _rTitle ) : rTitle( _rTitle ) { }
+        FilterTitleMatch( const rtl::OUString& _rTitle ) : rTitle( _rTitle ) { }
 
 
         bool operator () ( const FilterEntry& _rEntry )
@@ -203,7 +203,7 @@ FilterHelper::~FilterHelper()
 }
 
 
-sal_Bool FilterHelper::FilterNameExists( const rtl::OUString rTitle )
+sal_Bool FilterHelper::FilterNameExists( const rtl::OUString& rTitle )
 {
     sal_Bool bRet = sal_False;