fix previous string conversion:

- unconverted assertion in dinfdlg.cxx
- wrong replaceAt in SidebarWin.cxx
- obsolete cast in SpellDialog.cxx

Change-Id: I18450c0c6fdd275b7f81a7fce58cdf98bb806e27

cui/source/dialogs/SpellDialog.cxx

@@ -1491,7 +1491,7 @@ long SentenceEditWindow_Impl::PreNotify( NotifyEvent& rNEvt )
                     sal_Int32 nStart = pErrorAttr->GetStart();
                     sal_Int32 nEnd = pErrorAttr->GetEnd();
                     pTextEngine->RemoveAttrib( 0, *pErrorAttr );
-                    nStart = nStart - (sal_uInt16)nAddedChars;
+                    nStart = nStart - nAddedChars;
                     SetAttrib( *pNewError, 0, nStart - nAddedChars, nEnd );
                     //only if the error is active the mark is moved here
                     if(bIsErrorActive)

sfx2/source/dialog/dinfdlg.cxx

@@ -1340,7 +1340,8 @@ sal_Bool SfxInternetPage::FillItemSet( SfxItemSet& rSet )
             nDelay = static_cast<sal_uIntPtr>(m_pNFReload->GetValue());
             break;
         case S_Forward:
-            DBG_ASSERT( m_pEDForwardURL->GetText().Len(), "+SfxInternetPage::FillItemSet(): empty URL should be not possible for forward option!" );
+            SAL_WARN_IF(m_pEDForwardURL->GetText().isEmpty(), "sfx2",
+                "+SfxInternetPage::FillItemSet(): empty URL should be not possible for forward option!");
 
             bEnableReload = sal_True;
             SAL_WNODEPRECATED_DECLARATIONS_PUSH

sw/source/ui/docvw/SidebarWin.cxx

@@ -384,8 +384,7 @@ void SwSidebarWin::CheckMetaText()
     }
     else if (sMeta.getLength() > 22)
     {
-        sMeta.replaceAt(20, sMeta.getLength()-20, "");
-        sMeta = sMeta + OUString("...");
+        sMeta = sMeta.copy(0, 20) + OUString("...");
     }
     if ( mpMetadataAuthor->GetText() != sMeta )
     {