Use typed ToolBox::SetStateChangedHdl Link

Change-Id: I9b574f652e5d999086e32e9c7ede7c68fe5cc99a

framework/inc/uielement/addonstoolbarmanager.hxx

@@ -64,7 +64,7 @@ class AddonsToolBarManager : public ToolBarManager
         DECL_LINK_TYPED(Select, ToolBox *, void);
         DECL_LINK_TYPED(Activate, ToolBox *, void);
         DECL_LINK_TYPED(Deactivate, ToolBox *, void);
-        DECL_LINK( StateChanged, StateChangedType* );
+        DECL_LINK_TYPED( StateChanged, StateChangedType const *, void );
         DECL_LINK( DataChanged, DataChangedEvent* );
 
         virtual bool MenuItemAllowed( sal_uInt16 ) const SAL_OVERRIDE;

framework/inc/uielement/toolbarmanager.hxx

@@ -134,7 +134,7 @@ class ToolBarManager : public ToolbarManager_Base
         DECL_LINK_TYPED(Select, ToolBox *, void);
         DECL_LINK_TYPED(Activate, ToolBox *, void);
         DECL_LINK_TYPED(Deactivate, ToolBox *, void);
-        DECL_LINK( StateChanged, StateChangedType* );
+        DECL_LINK_TYPED( StateChanged, StateChangedType const *, void );
         DECL_LINK( DataChanged, DataChangedEvent* );
         DECL_LINK( MiscOptionsChanged, void* );
 

framework/source/uielement/addonstoolbarmanager.cxx

@@ -439,13 +439,12 @@ IMPL_LINK_NOARG_TYPED(AddonsToolBarManager, Activate, ToolBox *, void)
 IMPL_LINK_NOARG_TYPED(AddonsToolBarManager, Deactivate, ToolBox *, void)
 {}
 
-IMPL_LINK( AddonsToolBarManager, StateChanged, StateChangedType*, pStateChangedType )
+IMPL_LINK_TYPED( AddonsToolBarManager, StateChanged, StateChangedType const *, pStateChangedType, void )
 {
     if ( *pStateChangedType == StateChangedType::ControlBackground )
     {
         CheckAndUpdateImages();
     }
-    return 1;
 }
 
 IMPL_LINK( AddonsToolBarManager, DataChanged, DataChangedEvent*, pDataChangedEvent  )

framework/source/uielement/toolbarmanager.cxx

@@ -276,15 +276,14 @@ void ToolBarManager::Destroy()
         // #i93173# delete toolbar lazily as we can still be in one of its handlers
     m_pToolBar->doLazyDelete();
 
-    Link<> aEmpty;
     m_pToolBar->SetSelectHdl( Link<ToolBox *, void>() );
     m_pToolBar->SetActivateHdl( Link<ToolBox *, void>() );
     m_pToolBar->SetDeactivateHdl( Link<ToolBox *, void>() );
     m_pToolBar->SetClickHdl( Link<ToolBox *, void>() );
     m_pToolBar->SetDropdownClickHdl( Link<ToolBox *, void>() );
     m_pToolBar->SetDoubleClickHdl( Link<ToolBox *, void>() );
-    m_pToolBar->SetStateChangedHdl( aEmpty );
-    m_pToolBar->SetDataChangedHdl( aEmpty );
+    m_pToolBar->SetStateChangedHdl( Link<StateChangedType const *, void>() );
+    m_pToolBar->SetDataChangedHdl( Link<>() );
     m_pToolBar->SetCommandHdl( Link<CommandEvent const *, void>() );
 
     m_pToolBar.clear();
@@ -2030,10 +2029,10 @@ IMPL_LINK_NOARG_TYPED(ToolBarManager, Activate, ToolBox *, void)
 IMPL_LINK_NOARG_TYPED(ToolBarManager, Deactivate, ToolBox *, void)
 {}
 
-IMPL_LINK( ToolBarManager, StateChanged, StateChangedType*, pStateChangedType )
+IMPL_LINK_TYPED( ToolBarManager, StateChanged, StateChangedType const *, pStateChangedType, void )
 {
     if ( m_bDisposed )
-        return 1;
+        return;
 
     if ( *pStateChangedType == StateChangedType::ControlBackground )
     {
@@ -2050,7 +2049,6 @@ IMPL_LINK( ToolBarManager, StateChanged, StateChangedType*, pStateChangedType )
     {
         m_aAsyncUpdateControllersTimer.Start();
     }
-    return 1;
 }
 
 IMPL_LINK( ToolBarManager, DataChanged, DataChangedEvent*, pDataChangedEvent  )

include/vcl/toolbox.hxx

@@ -191,7 +191,7 @@ private:
     Link<ToolBox *, void> maDeactivateHdl;
     Link<ToolBox *, void> maSelectHdl;
     Link<CommandEvent const *, void> maCommandHandler;
-    Link<>              maStateChangedHandler;
+    Link<StateChangedType const *, void> maStateChangedHandler;
     Link<>              maDataChangedHandler;
 
     public:
@@ -505,8 +505,7 @@ public:
     void                SetSelectHdl( const Link<ToolBox *, void>& rLink ) { maSelectHdl = rLink; }
     const Link<ToolBox *, void>& GetSelectHdl() const { return maSelectHdl; }
     void                SetCommandHdl( const Link<CommandEvent const *, void>& aLink ) { maCommandHandler = aLink; }
-    void                SetStateChangedHdl( const Link<>& aLink ) { maStateChangedHandler = aLink; }
-    const Link<>&       GetStateChangedHdl() const { return maStateChangedHandler; }
+    void                SetStateChangedHdl( const Link<StateChangedType const *, void>& aLink ) { maStateChangedHandler = aLink; }
     void                SetDataChangedHdl( const Link<>& aLink ) { maDataChangedHandler = aLink; }
     const Link<>&       GetDataChangedHdl() { return maDataChangedHandler; }