wcscpy_s is buffer size, not string length, so size must also account
for a terminating NULL

Change-Id: Ie69692e47c142f3b733b093d0b87fa4bb03db7b4

Change-Id: I74c683cf1ca821733717348a7840feeb7fbff3e9

Change-Id: I76ced60151bcc160eb4a4c12cc86f01edec076fc

Change-Id: Ie770ecceb8c8f5a6fa882a9f5d5a26806b029589

The buffered overlay manager paints using a timer, which is problematic
if the given vcl::Window already supports double-buffering itself, so
always use direct (to the rendercontext) painting in that case.

Change-Id: I93144c02814fd511f333224ab058374c7da369f0

Double buffering default is false, then can be enabled on a per-widget
basis, finally this can be overriden at runtime by the
VCL_DOUBLEBUFFERING_FORCE_ENABLE environment variable (so that
everything is painted using double buffering).

Let SupportsDoubleBuffering() also respect this variable, so code
calling SupportsDoubleBuffering() can react to the runtime override,
too.

Change-Id: Ic9a1c00a801f6976069d7cfc47c3fa491ebc1ff0

Change-Id: I08c60396d66a15ee94c7010753540c4e7fb3a0db

cf. <https://gerrit.libreoffice.org/#/c/16357> "Revert the removal of cast to
build on old poppler"

Change-Id: I75184cec64b4f32e0cf9adedeb84c8591be4fc73

Change-Id: I0ea809a888187624261182552cf7fa0a9c96c648

Change-Id: I0dd118f0215e06fec0cccff9b46d80f13bd802cc
Reviewed-on: https://gerrit.libreoffice.org/16620Reviewed-by: Matthew Francis <mjay.francis@gmail.com>
Tested-by: Matthew Francis <mjay.francis@gmail.com>

Change-Id: I44e2881bcf1d50fbc4d35802d90ea8ee19b39f3a

... instead of just creating a new document.

Change-Id: Ib336c07f6827775a9c1a4fa0b8fbfe4ae0ff8221

Change-Id: If5960be7b04db418a1a42bd7b661391f65e79498
Signed-off-by: Michael Stahl <mstahl@redhat.com>

Change-Id: I9309dc797c63e6c28831f545fd4d029a4d108dea

mbNoFocusRects is also the case now for gtk3, but this unfortunate
heuristic makes the database and chart wizards and various other
things just way too tall. This is likely a desperate effort to
make pre layout dialogs size to something sensible

Change-Id: I501f04ad96063935dd1f162e009ffd5053a820c4

Change-Id: I44eae735b710332d87f2f642911e988c796457cd

Change-Id: I22e9eacfddff611d368963162024437f4a7b7fdf

... to move test code out of production code

Change-Id: I8bd38f57faba41a0af3740eda098144d9e49fe15

With this, if e.g. Ctrl-A is hit for a hello-world document, then
selection is properly visible.

Change-Id: If3fae1e73dc76c50e62f6e1f31d99873636f0e93

Change-Id: I5df89581796eca4e48e0a305d4319e4674f8dd87

Change-Id: I5a990643903946ea339136fbc514ca8cb90fa34e

Change-Id: I86d2daec6dcbd6af3a8da1b8329417bae46c8079

See the comment 45 in the bug for the agreed design.

Change-Id: I428f339df48f530f606525434a4a2be8a79acaab

Change-Id: I1c5e4970d4e90bdea68a901294594104de5e189e
Reviewed-on: https://gerrit.libreoffice.org/16582Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Andras Timar <andras.timar@collabora.com>

themeing has changed around quite a bit, and there's insufficient interest to
get older versions looking right

Change-Id: Ia2ee58d66c859e3bf00b54413fac1efb00d38dd3

This reverts commit 09b4cbe9,
no good reason to revert the original commit in the first place.

Conflicts:
	bridges/test/java_remote/Bug107753_Test.java

Change-Id: I6d3d50887460fd15080c46782c29a653c3684bec

This reverts commit 262dbabe,
no good reason to revert the original commit in the first place.

Conflicts:
	linguistic/source/lngsvcmgr.cxx

Change-Id: Ifa1896da3ec3fd291a9b30a9a6734bdcce406b99

...from most rtl/bootstrap.h functions.  They are effectively only called from
C++ code (there is no plain C UNO binding), so it should be fine to let std
exceptions (like bad_alloc or length_error) propagate from their implementations
to call sites.

(The exception is rtl_bootstrap_args_close, which is typically called from C++
dtors, so should not throw anyway.)

This would strictly speaking be an [API CHANGE], but it should make no practical
difference whether a process terminates abruptly because an exception cannot
pass through a SAL_THROW_EXTERN_C() nothrow specification or because legacy
client code does not expect exceptions to be thrown from functions from which
SAL_THROW_EXTERN_C() has now been removed.

Change-Id: I08e8479e9c5731e46021aadd6a725c1793024d10

Change-Id: I9c941cfcb8c856f35ff3b24f8e15000af4993651

Remove TReportPairHelper and TStartMarkerHelper as well since they
were helper structs that were used solely for many of these
o3tl::compose calls and are now unused.

Change-Id: I75b366a7951a841c49a34709a3bdc1877952b64d
Reviewed-on: https://gerrit.libreoffice.org/16606Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>

While these functions do not throw any UNO exceptions, no need to specify them
as nothrow, and do allow std exceptions to pass through.

Also covers Coverity 1308470, 1308476, 1308482, 1308495, 1308496, 1308502,
1308506, and 1308575.

Change-Id: I00306f606f3f20462016177eebbd26ed5af76506

... for callers that individually check for them, like
ScRange::ParseAny()

Change-Id: I23fc2c178a9c89b59f99f2fb86223324b7e5d378

Change-Id: Iec79e088e67e1cddeb8242d069fae911b305f613

... that have a Writer table as data source, such as ooo38798-1.sxw.

The problem is that during layouting, the SwWrtShell::CalcAndSetScale()
wants to call setVisualAreaSize() on the embedded chart object.

This switches the state of the object to RUNNING, which loads it from
the file, and during that the ODF filter calls into SwChartDataProvider
and that uses a UnoActionRemoveContext; unfortunately that ends all
pending Actions, so we get a recursive layout action.

Apparently the UnoActionRemoveContext is required to call
SwUnoTableCrsr::MakeBoxSels() for old-style tables, which need layout
frames for selection?!?

Try to avoid the problem by disabling UnoActionRemoveContext in case a
new-style table will be selected, which can be done without layout.

Change-Id: I097991ffb2e78ddf011db7575f7bb63ae8aa7005

IMDeleteSurrounding is used by input methods to take multiple
keystrokes and convert them into a special character.  Then the
composing keystrokes are removed.
Before this fix, the cursor placement was not adjusted,
so the special character was inserted in the wrong position
and if 3+ keystrokes were involved, the wrong characters were deleted.

Change-Id: I35b97bc150dc68ffe65eebc59450e21e0033bd16
Reviewed-on: https://gerrit.libreoffice.org/15961Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I46fffbdbf952b2eb67a469a5960bc94c8ee7d377

Change-Id: Icebaba828316b0f304ad407dc88d7a45f1f62cba

Change-Id: I4fb620754aac3f962695d053f05e50242538193e

2 changes for the 2 following bts
First bt: see https://bugs.documentfoundation.org/attachment.cgi?id=116883
Second bt: see https://bugs.documentfoundation.org/attachment.cgi?id=116888

Change-Id: I92ed3b7305bb5b714532f2dcffd615a8337db8b6
Reviewed-on: https://gerrit.libreoffice.org/16557Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I845a3eda41263a07e1e69eb6ff37ff5ab2576905