I used comments from https://bugs.documentfoundation.org/show_bug.cgi?id=119743
+ https://gerrit.libreoffice.org/#/c/61144/

Thank you to Lionel and Stephan

Change-Id: I956b0c2009e3fa1169ba57a059dde0016375def5
Reviewed-on: https://gerrit.libreoffice.org/61272Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>
Tested-by: Julien Nabet <serval2412@yahoo.fr>

...ever since the code's introduction in
278b1de2 "Added base as a data provider"

Change-Id: I3ccd1d699e0888cb010e46735f8816eea8b41e34
Reviewed-on: https://gerrit.libreoffice.org/61250
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

This mostly affects explicitly defaulted functions that had recently been user-
declared to silence new GCC trunk -Wdeprecated-copy.  It is not entirely clear
to me what the best approach is overall, see my mail
<http://lists.llvm.org/pipermail/cfe-commits/Week-of-Mon-20181001/245321.html>
"Re: r343285 - [cxx2a] P0641R2: (Some) type mismatches on defaulted functions
only", but lets just explicitly delete those functions for now.

Change-Id: If8c72f612f67a8feb8b03c2fb988c807e704ef03
Reviewed-on: https://gerrit.libreoffice.org/61259
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

Change-Id: I34e0e97b165b8335e58bcc5713d2140b31ee94ed
Reviewed-on: https://gerrit.libreoffice.org/61225Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Jenkins

I thought just border windows can act as proxies, but this bug
proves me wrong; also floating windows set mpClientWindow and may
have an additional nested proxy border window.
Interestingly proxies can have multiple children, which I tested
with a temporary assertion I added!?

So just ignore all proxy windows until we find a real one, And
drop the assertion as it doesn't make sense any more.

I'm just wondering why I always read Child instead of Client...

Change-Id: I83a1a5743b434399aae361cb14058993ba60c83c
Reviewed-on: https://gerrit.libreoffice.org/61196
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

Change-Id: I3e72909ca1aa9f97721d982f16624f496152ae2d

To get that with CoreGraphics on iOS we need to use also
kCGImageByteOrder32Little in the CGBitmapContextCreate() call,
otherwise the bytes will be in ARGB order in memory.

(Not touching the macOS code here.)

Change-Id: I3c2dd94feb1c6bf46c5b335f5901b29e5fe1e7fb

On iOS, don't attempt to write the tile dump ppm file to /tmp, but use
the app-specific directory so that it can be copied for inspection
using iTunes. (Of course, even better would be to simply paint it to
the app's view. Later)

Change-Id: I8dd60d04adc61de6594099f5c358a9b6220522da
Reviewed-on: https://gerrit.libreoffice.org/61255Reviewed-by: Tor Lillqvist <tml@collabora.com>
Tested-by: Tor Lillqvist <tml@collabora.com>

Change-Id: Ie2ae18b1722e91996887162b4a8ff02d2d812341
Reviewed-on: https://gerrit.libreoffice.org/61228
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

* Update helpcontent2 from branch 'master'
  - Fix typos
    
    Change-Id: Ic23908f65b62064ae99fa337a4f269d1b1ea1c09
    Reviewed-on: https://gerrit.libreoffice.org/61254
    Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
    

Change-Id: If4dc6458d9c5fb3b574c1bb55196a5086aff3365

Change-Id: I373886d3613607b8ee8e96d8c0314865f3991a92
Reviewed-on: https://gerrit.libreoffice.org/61241Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

so that fast result return maintains correctness.

Although not necessary for fixing this bug,
lets take advantage of fast result return in the case
of empty result token by setting mfValue to 0.0 and
setting mbValueCached flag.

The fast result return was implemented in :-

<commit-header>
commit 77f7b476
Author: Dennis Francis <dennis.francis@collabora.co.uk>
Date:   Wed Jul 11 17:19:28 2018 +0530

    Allow fast result return for formula-cells with...

    "double" result which is a very frequent use-case.
    This improves overall running times in most cases,
    not just for the threaded path.

    Change-Id: I18d10ee3cea613923e2057e746a6a8187bb18647
    Reviewed-on: https://gerrit.libreoffice.org/59395
    Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
</commit-header>

Also added a ui-test for the fix. A normal unit test would
have sufficed, but I could not get it to reproduce the issue
from a ucalc environment somehow.

Change-Id: I9b95b571b596a7bb68768ea0de8ee4334448b540
Reviewed-on: https://gerrit.libreoffice.org/61140Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Jenkins

and 'standard' just has to exist, doesn't need to be translatable

Change-Id: I1e5157781ea81c40952c462253a2e3d53557aecb
Reviewed-on: https://gerrit.libreoffice.org/61229Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I1859d612e13b2f0d837aa65012552c441346cb1a
Reviewed-on: https://gerrit.libreoffice.org/61236
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>

without considering 'match' parameter for now

Change-Id: I03ec7017fdaae8c8e20f19e6c827aafb093e8a53
Reviewed-on: https://gerrit.libreoffice.org/61231
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>

Change-Id: Ic7b56da1f48760770ca5617cea6c91e10ff0dcee
Reviewed-on: https://gerrit.libreoffice.org/61100
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>

Change-Id: Idaea2e46451ee80b82764e573fdea1c7bf0c86ef
Reviewed-on: https://gerrit.libreoffice.org/61213
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>

The field names are arguably rather labels for the static-role widgets
providing the status.

Change-Id: Ic3407adf84d7399696e51de712635a986fa0c190
Reviewed-on: https://gerrit.libreoffice.org/60142
Tested-by: Jenkins
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>

Change-Id: I30c4db19db068ff73f34236776cb511280acbbd7
Reviewed-on: https://gerrit.libreoffice.org/61096
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>

it was copying maBroadcasters, without actually starting to listen to
those broadcasters, which means if we __did__ call StartListening, that
method would have just returned early.

Since nothing seems to need this functionality, and it's not obvious
what the correct behaviour would be, just don't do the copy.

Change-Id: If5865fa3449839758a43ac537475e0a474f39078
Reviewed-on: https://gerrit.libreoffice.org/61239
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I53d6d36374fc35eb8370ad6d83723aafb01fb8b4
Reviewed-on: https://gerrit.libreoffice.org/61199
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>

shows available action and allows to execute them

Change-Id: I944e4eccaac7c458af77b471c1d6e10650b1e798
Reviewed-on: https://gerrit.libreoffice.org/61183
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>

Change-Id: Ie0a7f85624da2ef2cd60fe7e074fa98cf64e779e
Reviewed-on: https://gerrit.libreoffice.org/61179
Tested-by: Jenkins
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>

Change-Id: I85aaf0f28c30055003b48209d15b1b496c234e4b
Reviewed-on: https://gerrit.libreoffice.org/61120
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Not just font color, anything defined via list styles were not imported.

Change-Id: I95e6fc52e30a09ff93fb55d0836e45e177a7b099
Reviewed-on: https://gerrit.libreoffice.org/61230Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins

Change-Id: I46db49472dcaa80b54a937f03bf03b06a2d8a87c
Reviewed-on: https://gerrit.libreoffice.org/61240Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

since this approach is better in that it avoids O(n^2) behaviour
of lots of listeners deleting from a std::vector, lets just
always use this approach.

Change-Id: I9204996ee8c9379ac71dfc168a6c1fc653e63a8e
Reviewed-on: https://gerrit.libreoffice.org/61204
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

So that it is available to other a11y implementations as well

Change-Id: Ib82c4861cf9e0e90c64703b13c46548a080ffd10
Reviewed-on: https://gerrit.libreoffice.org/61198
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>

Change-Id: I5ab173cb2517602abc42e715375157fd05fdd55f
Reviewed-on: https://gerrit.libreoffice.org/61203
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

* Update helpcontent2 from branch 'master'
  - tdf#115254 Some branch bookmarks are'nt working 32
    
    Module basctl
    
    Change-Id: I0206a66346e76e71f6fc14cd92257b2415968741
    Reviewed-on: https://gerrit.libreoffice.org/61235
    Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
    

...which appears to still work if you just disable the components that are not
present because they require Java.

Found by <https://ci.libreoffice.org/job/lo_tb_random_config_linux/1514/>.

Change-Id: I1a7f27a9f44d2a82953e4230c974f19e98127550
Reviewed-on: https://gerrit.libreoffice.org/61226
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

Change-Id: I3993f726f433503173c27c68be40936bc03aaf6e
Reviewed-on: https://gerrit.libreoffice.org/61227
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: Ic099761eaff80349e985ccf62e3f4aa6b2e98022
Reviewed-on: https://gerrit.libreoffice.org/61103
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

Change-Id: Ie90af62eff146064c3b066a8f7ca1c3a69f44c39
Reviewed-on: https://gerrit.libreoffice.org/61102
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

Change-Id: If9c7c67f48311ac68ecc9f8e3a07f9bb7c73d962
Reviewed-on: https://gerrit.libreoffice.org/61101
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

Change-Id: I1289721e2e62e258237096d79182779ca3f15bdb
Reviewed-on: https://gerrit.libreoffice.org/61205
Tested-by: Jenkins
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>

Change-Id: If65c3a9b529d2173f9795c038c877d4e4423a883
Reviewed-on: https://gerrit.libreoffice.org/61217
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I9efd96e42c7c1a7e8f9f08ddf1edf7c74b30c7ca
Reviewed-on: https://gerrit.libreoffice.org/61216Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I5102c218c969cf9302405e4146f92e187c1998ce
Reviewed-on: https://gerrit.libreoffice.org/61215
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>