Change-Id: I541d08fb32932917f8cc2c056325769e729e618a

...(but not Objective-C++ code) where BOOL (aka unsigned char) expressions are
routinely implicitly converted to int per the C rules, e.g., as operands of &&.

Change-Id: I17e5dae9f065aaa814850196b1ef31f8fb07c99b

Change-Id: I5d0a3b8ed1c49ba2806e0fa528d908da45afd58c

...at least in my build against the 10.9 SDK.  (Though Clang apparently emits
far fewer shadowing warnings than other compilers, anyway.)

Change-Id: I1f1e2ef693c3bd0846d85a3f72f32a8610f46194

Change-Id: If28afc6a2936b150e6659ed84c5ecac9f4c54edc

Change-Id: I20fbfccc3e7799539372e72490fe5721ec009896

Change-Id: I1730694d8856ed009b8bf02a71657ca933bc6101

Change-Id: Ic4c57e161419a9b185b2c5ee8e8b79d3da9e4a7e

Change-Id: I4750c17ae7110b0102ebdd141a31ab2a52c4e774

Change-Id: I618ca9c26e5d5371262d50782ea3396f11931892

Change-Id: I437801a752e2ae2fa762f46f566b761fdc02acb8

Change-Id: I28543128b75315be1eda1a82f6e856778c38a33e

Change-Id: I2b8b962054b0e1ca98db3929c6692e7c354e6a93

Change-Id: I06c09a494bdf37a87ff851a8e3cbc94b22b9a511

Change-Id: Ied856c05594a0ee5bd43ec61e65d12dd18e746d8

Change-Id: I34995118b06319a8ff5b5c51b22cbe1898cb2756

Change-Id: Ica05591754633fc64216aecbdf8010800133dfd4

Change-Id: I41aea2e62bb8c034d07825bd4b8776e718cd0920

Change-Id: I70ee031eb55d10aa47e24714b839f5eb4d9a3109

Change-Id: I901a1f1f9732fb66718dca34c698a851e5b0d87f

Change-Id: I7bc3982895fa118616330ee9df88abae96abbe14

Change-Id: I2532b772d1bfff268a8f60a4d59dad5c8960352a

Change-Id: I9363d4d90df7c74cf7462494ceda2e2f47607dc9

Change-Id: I4f36977e7b1c4c210b8c70ec7aa248d9e6912241

Change-Id: I59a7b31772e60a4da56b35e679928d8238b3d420

Change-Id: Id29dd8ad0d5de77738f162aed530ed191f326aa2

Change-Id: Icff2648f04eca42a16555d334e42dda9f453b965

Change-Id: Ief6abf58b36a9f00b63e3ca71900b026628c996c

Change-Id: I0cc54e443793dda9bd11a907cc79b54dab3810ad

Change-Id: Ie7844af5ab7ead6383e60933588f66c5871f3282

Change-Id: I19d0903c09c63198f20260f67cddd14a7552fc19

Change-Id: I0df7a930ff970c26fbbb03d9333108ee3cae7ad4

Change-Id: Ic334d7b0110319e0c581eecd111b73d1cce3134d

[MS-WMF] 2.1.1.5 CharacterSet Enumeration defines DEFAULT_CHARSET
"Specifies a character set based on the current system locale;
for example, when the system locale is United States English,
the default character set is ANSI_CHARSET"

OEM_CHARSET is defined as follows: "Specifies a mapping to one of
the OEM code pages, according to the current system locale setting"

Currently, LO WMF import treats these values as synonim for
RTL_TEXTENCODING_MS_1252. This patch fixes this to use LibreOffice
locale setting instead.

Strictly speaking, this is not quite correct for OEM. E.g., for
Russian, DEFAULT_CHARSET is equal to codepage 1251, while OEM_CHARSET
is codepage 866. But I don't know how to distinguish these two.

Change-Id: Id5eaf070cde040bd6eb1db28f1a498d647ba227e
Reviewed-on: https://gerrit.libreoffice.org/15641Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

The check was incorrect: it invariantly checked only first part
of formula, and thus gave wrong results when the relative represen-
tation of formula contained external reference in usual box form.

BTW, I don't know why there's hardcoded return of "A1" on error
in SwTableFormula::RelNmsToBoxNms? Isn't that dangerous to provide
an arbitrary valid result that may give unnoticed wrong calculation?

Change-Id: If17c0f9459c64e65a6c2b8ed4482ffee78f115b2
Reviewed-on: https://gerrit.libreoffice.org/15678Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: If0571864684ec484e859c967aebb23c378c302ef
Reviewed-on: https://gerrit.libreoffice.org/15298Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

If you searched backwards and reached the start of the document,
the text "Reached the end of the document" was shown.

Change-Id: Ic35884de2f1ada07e76c9c3e27cf6c81c4a83304
Reviewed-on: https://gerrit.libreoffice.org/15597Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

maIconCache is defined as a std::unordered_map
'interning' a OUString to give to it as a key seems completely
superfluous since no-one will ever use it by address, even less
compare the address.

Change-Id: Iab5d106d7d51fcdfbd0a0dfd50ae28d686b9b2b7
Reviewed-on: https://gerrit.libreoffice.org/15692Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: Iefcc529d8ffa608e26c75a445341e0b8ae11c613
Reviewed-on: https://gerrit.libreoffice.org/15683Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I8d4c3a62d4e63d2666bfce18d6af772a29e271d4
Reviewed-on: https://gerrit.libreoffice.org/15695Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>