symtable.c 56.8 KB
Newer Older
1
#include "Python.h"
2 3 4 5
#include "internal/pystate.h"
#ifdef Yield
#undef Yield /* undefine conflicting macro from winbase.h */
#endif
Jeremy Hylton's avatar
Jeremy Hylton committed
6 7
#include "Python-ast.h"
#include "code.h"
8 9 10
#include "symtable.h"
#include "structmember.h"

11
/* error strings used for warnings */
12 13 14 15 16 17
#define GLOBAL_PARAM \
"name '%U' is parameter and global"

#define NONLOCAL_PARAM \
"name '%U' is parameter and nonlocal"

Jeremy Hylton's avatar
Jeremy Hylton committed
18
#define GLOBAL_AFTER_ASSIGN \
19
"name '%U' is assigned to before global declaration"
20

21
#define NONLOCAL_AFTER_ASSIGN \
22
"name '%U' is assigned to before nonlocal declaration"
23

Jeremy Hylton's avatar
Jeremy Hylton committed
24
#define GLOBAL_AFTER_USE \
25
"name '%U' is used prior to global declaration"
26

27
#define NONLOCAL_AFTER_USE \
28 29 30 31 32 33 34
"name '%U' is used prior to nonlocal declaration"

#define GLOBAL_ANNOT \
"annotated name '%U' can't be global"

#define NONLOCAL_ANNOT \
"annotated name '%U' can't be nonlocal"
35

36 37
#define IMPORT_STAR_WARNING "import * only allowed at module level"

38
static PySTEntryObject *
39
ste_new(struct symtable *st, identifier name, _Py_block_ty block,
40
        void *key, int lineno, int col_offset)
41
{
42
    PySTEntryObject *ste = NULL;
43
    PyObject *k = NULL;
44 45 46 47 48

    k = PyLong_FromVoidPtr(key);
    if (k == NULL)
        goto fail;
    ste = PyObject_New(PySTEntryObject, &PySTEntry_Type);
49 50
    if (ste == NULL) {
        Py_DECREF(k);
51
        goto fail;
52
    }
53
    ste->ste_table = st;
54
    ste->ste_id = k; /* ste owns reference to k */
55 56

    Py_INCREF(name);
57
    ste->ste_name = name;
58 59 60 61 62

    ste->ste_symbols = NULL;
    ste->ste_varnames = NULL;
    ste->ste_children = NULL;

63 64
    ste->ste_directives = NULL;

65 66 67 68 69 70
    ste->ste_type = block;
    ste->ste_nested = 0;
    ste->ste_free = 0;
    ste->ste_varargs = 0;
    ste->ste_varkeywords = 0;
    ste->ste_opt_lineno = 0;
71
    ste->ste_opt_col_offset = 0;
72
    ste->ste_lineno = lineno;
73
    ste->ste_col_offset = col_offset;
74 75 76 77 78 79 80

    if (st->st_cur != NULL &&
        (st->st_cur->ste_nested ||
         st->st_cur->ste_type == FunctionBlock))
        ste->ste_nested = 1;
    ste->ste_child_free = 0;
    ste->ste_generator = 0;
81
    ste->ste_coroutine = 0;
82
    ste->ste_returns_value = 0;
83
    ste->ste_needs_class_closure = 0;
84

85 86 87 88 89 90 91 92
    ste->ste_symbols = PyDict_New();
    ste->ste_varnames = PyList_New(0);
    ste->ste_children = PyList_New(0);
    if (ste->ste_symbols == NULL
        || ste->ste_varnames == NULL
        || ste->ste_children == NULL)
        goto fail;

93 94 95 96
    if (PyDict_SetItem(st->st_blocks, ste->ste_id, (PyObject *)ste) < 0)
        goto fail;

    return ste;
97
 fail:
98 99
    Py_XDECREF(ste);
    return NULL;
100 101 102
}

static PyObject *
Jeremy Hylton's avatar
Jeremy Hylton committed
103
ste_repr(PySTEntryObject *ste)
104
{
105 106 107
    return PyUnicode_FromFormat("<symtable entry %U(%ld), line %d>",
                                ste->ste_name,
                                PyLong_AS_LONG(ste->ste_id), ste->ste_lineno);
108 109 110
}

static void
Jeremy Hylton's avatar
Jeremy Hylton committed
111
ste_dealloc(PySTEntryObject *ste)
112
{
113 114 115 116 117 118
    ste->ste_table = NULL;
    Py_XDECREF(ste->ste_id);
    Py_XDECREF(ste->ste_name);
    Py_XDECREF(ste->ste_symbols);
    Py_XDECREF(ste->ste_varnames);
    Py_XDECREF(ste->ste_children);
119
    Py_XDECREF(ste->ste_directives);
120
    PyObject_Del(ste);
121 122
}

Jeremy Hylton's avatar
Jeremy Hylton committed
123
#define OFF(x) offsetof(PySTEntryObject, x)
124

125
static PyMemberDef ste_memberlist[] = {
126 127 128 129 130 131 132 133 134
    {"id",       T_OBJECT, OFF(ste_id), READONLY},
    {"name",     T_OBJECT, OFF(ste_name), READONLY},
    {"symbols",  T_OBJECT, OFF(ste_symbols), READONLY},
    {"varnames", T_OBJECT, OFF(ste_varnames), READONLY},
    {"children", T_OBJECT, OFF(ste_children), READONLY},
    {"nested",   T_INT,    OFF(ste_nested), READONLY},
    {"type",     T_INT,    OFF(ste_type), READONLY},
    {"lineno",   T_INT,    OFF(ste_lineno), READONLY},
    {NULL}
135 136
};

Jeremy Hylton's avatar
Jeremy Hylton committed
137
PyTypeObject PySTEntry_Type = {
138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175
    PyVarObject_HEAD_INIT(&PyType_Type, 0)
    "symtable entry",
    sizeof(PySTEntryObject),
    0,
    (destructor)ste_dealloc,                /* tp_dealloc */
    0,                                      /* tp_print */
    0,                                         /* tp_getattr */
    0,                                          /* tp_setattr */
    0,                                          /* tp_reserved */
    (reprfunc)ste_repr,                         /* tp_repr */
    0,                                          /* tp_as_number */
    0,                                          /* tp_as_sequence */
    0,                                          /* tp_as_mapping */
    0,                                          /* tp_hash */
    0,                                          /* tp_call */
    0,                                          /* tp_str */
    PyObject_GenericGetAttr,                    /* tp_getattro */
    0,                                          /* tp_setattro */
    0,                                          /* tp_as_buffer */
    Py_TPFLAGS_DEFAULT,                         /* tp_flags */
    0,                                          /* tp_doc */
    0,                                          /* tp_traverse */
    0,                                          /* tp_clear */
    0,                                          /* tp_richcompare */
    0,                                          /* tp_weaklistoffset */
    0,                                          /* tp_iter */
    0,                                          /* tp_iternext */
    0,                                          /* tp_methods */
    ste_memberlist,                             /* tp_members */
    0,                                          /* tp_getset */
    0,                                          /* tp_base */
    0,                                          /* tp_dict */
    0,                                          /* tp_descr_get */
    0,                                          /* tp_descr_set */
    0,                                          /* tp_dictoffset */
    0,                                          /* tp_init */
    0,                                          /* tp_alloc */
    0,                                          /* tp_new */
176
};
Jeremy Hylton's avatar
Jeremy Hylton committed
177 178

static int symtable_analyze(struct symtable *st);
179
static int symtable_enter_block(struct symtable *st, identifier name,
180 181
                                _Py_block_ty block, void *ast, int lineno,
                                int col_offset);
Jeremy Hylton's avatar
Jeremy Hylton committed
182 183 184 185
static int symtable_exit_block(struct symtable *st, void *ast);
static int symtable_visit_stmt(struct symtable *st, stmt_ty s);
static int symtable_visit_expr(struct symtable *st, expr_ty s);
static int symtable_visit_genexp(struct symtable *st, expr_ty s);
186 187
static int symtable_visit_listcomp(struct symtable *st, expr_ty s);
static int symtable_visit_setcomp(struct symtable *st, expr_ty s);
188
static int symtable_visit_dictcomp(struct symtable *st, expr_ty s);
Jeremy Hylton's avatar
Jeremy Hylton committed
189 190 191 192 193 194
static int symtable_visit_arguments(struct symtable *st, arguments_ty);
static int symtable_visit_excepthandler(struct symtable *st, excepthandler_ty);
static int symtable_visit_alias(struct symtable *st, alias_ty);
static int symtable_visit_comprehension(struct symtable *st, comprehension_ty);
static int symtable_visit_keyword(struct symtable *st, keyword_ty);
static int symtable_visit_slice(struct symtable *st, slice_ty);
195 196
static int symtable_visit_params(struct symtable *st, asdl_seq *args);
static int symtable_visit_argannotations(struct symtable *st, asdl_seq *args);
Jeremy Hylton's avatar
Jeremy Hylton committed
197
static int symtable_implicit_arg(struct symtable *st, int pos);
198
static int symtable_visit_annotations(struct symtable *st, stmt_ty s, arguments_ty, expr_ty);
199
static int symtable_visit_withitem(struct symtable *st, withitem_ty item);
Jeremy Hylton's avatar
Jeremy Hylton committed
200 201


202
static identifier top = NULL, lambda = NULL, genexpr = NULL,
203
    listcomp = NULL, setcomp = NULL, dictcomp = NULL,
204
    __class__ = NULL;
Jeremy Hylton's avatar
Jeremy Hylton committed
205 206

#define GET_IDENTIFIER(VAR) \
207
    ((VAR) ? (VAR) : ((VAR) = PyUnicode_InternFromString(# VAR)))
Jeremy Hylton's avatar
Jeremy Hylton committed
208 209

#define DUPLICATE_ARGUMENT \
210
"duplicate argument '%U' in function definition"
Jeremy Hylton's avatar
Jeremy Hylton committed
211 212 213 214

static struct symtable *
symtable_new(void)
{
215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230
    struct symtable *st;

    st = (struct symtable *)PyMem_Malloc(sizeof(struct symtable));
    if (st == NULL)
        return NULL;

    st->st_filename = NULL;
    st->st_blocks = NULL;

    if ((st->st_stack = PyList_New(0)) == NULL)
        goto fail;
    if ((st->st_blocks = PyDict_New()) == NULL)
        goto fail;
    st->st_cur = NULL;
    st->st_private = NULL;
    return st;
Jeremy Hylton's avatar
Jeremy Hylton committed
231
 fail:
232 233
    PySymtable_Free(st);
    return NULL;
Jeremy Hylton's avatar
Jeremy Hylton committed
234 235
}

236 237 238 239 240 241 242 243 244 245 246 247
/* When compiling the use of C stack is probably going to be a lot
   lighter than when executing Python code but still can overflow
   and causing a Python crash if not checked (e.g. eval("()"*300000)).
   Using the current recursion limit for the compiler seems too
   restrictive (it caused at least one test to fail) so a factor is
   used to allow deeper recursion when compiling an expression.

   Using a scaling factor means this should automatically adjust when
   the recursion limit is adjusted for small or large C stack allocations.
*/
#define COMPILER_STACK_FRAME_SCALE 3

Jeremy Hylton's avatar
Jeremy Hylton committed
248
struct symtable *
249
PySymtable_BuildObject(mod_ty mod, PyObject *filename, PyFutureFeatures *future)
Jeremy Hylton's avatar
Jeremy Hylton committed
250
{
251
    struct symtable *st = symtable_new();
252 253
    asdl_seq *seq;
    int i;
254
    PyThreadState *tstate;
255
    int recursion_limit = Py_GetRecursionLimit();
256 257

    if (st == NULL)
258 259 260 261 262 263
        return NULL;
    if (filename == NULL) {
        PySymtable_Free(st);
        return NULL;
    }
    Py_INCREF(filename);
264 265
    st->st_filename = filename;
    st->st_future = future;
266 267 268 269 270 271 272

    /* Setup recursion depth check counters */
    tstate = PyThreadState_GET();
    if (!tstate) {
        PySymtable_Free(st);
        return NULL;
    }
273 274 275 276 277
    /* Be careful here to prevent overflow. */
    st->recursion_depth = (tstate->recursion_depth < INT_MAX / COMPILER_STACK_FRAME_SCALE) ?
        tstate->recursion_depth * COMPILER_STACK_FRAME_SCALE : tstate->recursion_depth;
    st->recursion_limit = (recursion_limit < INT_MAX / COMPILER_STACK_FRAME_SCALE) ?
        recursion_limit * COMPILER_STACK_FRAME_SCALE : recursion_limit;
278

279 280
    /* Make the initial symbol information gathering pass */
    if (!GET_IDENTIFIER(top) ||
281
        !symtable_enter_block(st, top, ModuleBlock, (void *)mod, 0, 0)) {
282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319
        PySymtable_Free(st);
        return NULL;
    }

    st->st_top = st->st_cur;
    switch (mod->kind) {
    case Module_kind:
        seq = mod->v.Module.body;
        for (i = 0; i < asdl_seq_LEN(seq); i++)
            if (!symtable_visit_stmt(st,
                        (stmt_ty)asdl_seq_GET(seq, i)))
                goto error;
        break;
    case Expression_kind:
        if (!symtable_visit_expr(st, mod->v.Expression.body))
            goto error;
        break;
    case Interactive_kind:
        seq = mod->v.Interactive.body;
        for (i = 0; i < asdl_seq_LEN(seq); i++)
            if (!symtable_visit_stmt(st,
                        (stmt_ty)asdl_seq_GET(seq, i)))
                goto error;
        break;
    case Suite_kind:
        PyErr_SetString(PyExc_RuntimeError,
                        "this compiler does not handle Suites");
        goto error;
    }
    if (!symtable_exit_block(st, (void *)mod)) {
        PySymtable_Free(st);
        return NULL;
    }
    /* Make the second symbol analysis pass */
    if (symtable_analyze(st))
        return st;
    PySymtable_Free(st);
    return NULL;
Jeremy Hylton's avatar
Jeremy Hylton committed
320
 error:
321 322 323
    (void) symtable_exit_block(st, (void *)mod);
    PySymtable_Free(st);
    return NULL;
Jeremy Hylton's avatar
Jeremy Hylton committed
324 325
}

326 327 328 329 330 331 332 333 334 335 336 337 338
struct symtable *
PySymtable_Build(mod_ty mod, const char *filename_str, PyFutureFeatures *future)
{
    PyObject *filename;
    struct symtable *st;
    filename = PyUnicode_DecodeFSDefault(filename_str);
    if (filename == NULL)
        return NULL;
    st = PySymtable_BuildObject(mod, filename, future);
    Py_DECREF(filename);
    return st;
}

Jeremy Hylton's avatar
Jeremy Hylton committed
339 340 341
void
PySymtable_Free(struct symtable *st)
{
342
    Py_XDECREF(st->st_filename);
343 344 345
    Py_XDECREF(st->st_blocks);
    Py_XDECREF(st->st_stack);
    PyMem_Free((void *)st);
Jeremy Hylton's avatar
Jeremy Hylton committed
346 347 348 349 350
}

PySTEntryObject *
PySymtable_Lookup(struct symtable *st, void *key)
{
351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367
    PyObject *k, *v;

    k = PyLong_FromVoidPtr(key);
    if (k == NULL)
        return NULL;
    v = PyDict_GetItem(st->st_blocks, k);
    if (v) {
        assert(PySTEntry_Check(v));
        Py_INCREF(v);
    }
    else {
        PyErr_SetString(PyExc_KeyError,
                        "unknown symbol table entry");
    }

    Py_DECREF(k);
    return (PySTEntryObject *)v;
Jeremy Hylton's avatar
Jeremy Hylton committed
368 369
}

370
int
Jeremy Hylton's avatar
Jeremy Hylton committed
371 372
PyST_GetScope(PySTEntryObject *ste, PyObject *name)
{
373 374 375 376 377
    PyObject *v = PyDict_GetItem(ste->ste_symbols, name);
    if (!v)
        return 0;
    assert(PyLong_Check(v));
    return (PyLong_AS_LONG(v) >> SCOPE_OFFSET) & SCOPE_MASK;
Jeremy Hylton's avatar
Jeremy Hylton committed
378 379
}

380 381 382 383 384 385
static int
error_at_directive(PySTEntryObject *ste, PyObject *name)
{
    Py_ssize_t i;
    PyObject *data;
    assert(ste->ste_directives);
386
    for (i = 0; i < PyList_GET_SIZE(ste->ste_directives); i++) {
387 388
        data = PyList_GET_ITEM(ste->ste_directives, i);
        assert(PyTuple_CheckExact(data));
389 390 391 392 393 394 395
        assert(PyUnicode_CheckExact(PyTuple_GET_ITEM(data, 0)));
        if (PyUnicode_Compare(PyTuple_GET_ITEM(data, 0), name) == 0) {
            PyErr_SyntaxLocationObject(ste->ste_table->st_filename,
                                       PyLong_AsLong(PyTuple_GET_ITEM(data, 1)),
                                       PyLong_AsLong(PyTuple_GET_ITEM(data, 2)));

            return 0;
396
        }
397
    }
398 399
    PyErr_SetString(PyExc_RuntimeError,
                    "BUG: internal directive bookkeeping broken");
400 401 402
    return 0;
}

Jeremy Hylton's avatar
Jeremy Hylton committed
403 404 405

/* Analyze raw symbol information to determine scope of each name.

406
   The next several functions are helpers for symtable_analyze(),
407
   which determines whether a name is local, global, or free.  In addition,
Jeremy Hylton's avatar
Jeremy Hylton committed
408
   it determines which local variables are cell variables; they provide
409
   bindings that are used for free variables in enclosed blocks.
Jeremy Hylton's avatar
Jeremy Hylton committed
410

411
   There are also two kinds of global variables, implicit and explicit.  An
Jeremy Hylton's avatar
Jeremy Hylton committed
412 413 414 415 416 417 418 419 420
   explicit global is declared with the global statement.  An implicit
   global is a free variable for which the compiler has found no binding
   in an enclosing function scope.  The implicit global is either a global
   or a builtin.  Python's module and class blocks use the xxx_NAME opcodes
   to handle these names to implement slightly odd semantics.  In such a
   block, the name is treated as global until it is assigned to; then it
   is treated as a local.

   The symbol table requires two passes to determine the scope of each name.
421 422 423 424
   The first pass collects raw facts from the AST via the symtable_visit_*
   functions: the name is a parameter here, the name is used but not defined
   here, etc.  The second pass analyzes these facts during a pass over the
   PySTEntryObjects created during pass 1.
Jeremy Hylton's avatar
Jeremy Hylton committed
425 426

   When a function is entered during the second pass, the parent passes
427
   the set of all name bindings visible to its children.  These bindings
428
   are used to determine if non-local variables are free or implicit globals.
429 430 431 432
   Names which are explicitly declared nonlocal must exist in this set of
   visible names - if they do not, a syntax error is raised. After doing
   the local analysis, it analyzes each of its child blocks using an
   updated set of name bindings.
Jeremy Hylton's avatar
Jeremy Hylton committed
433

434 435 436 437 438
   The children update the free variable set.  If a local variable is added to
   the free variable set by the child, the variable is marked as a cell.  The
   function object being defined must provide runtime storage for the variable
   that may outlive the function's frame.  Cell variables are removed from the
   free set before the analyze function returns to its parent.
439

440 441 442 443 444 445 446
   During analysis, the names are:
      symbols: dict mapping from symbol names to flag values (including offset scope values)
      scopes: dict mapping from symbol names to scope values (no offset)
      local: set of all symbol names local to the current scope
      bound: set of all symbol names local to a containing function scope
      free: set of all symbol names referenced but not bound in child scopes
      global: set of all symbol names explicitly declared as global
Jeremy Hylton's avatar
Jeremy Hylton committed
447 448 449
*/

#define SET_SCOPE(DICT, NAME, I) { \
450 451 452 453 454 455 456 457
    PyObject *o = PyLong_FromLong(I); \
    if (!o) \
        return 0; \
    if (PyDict_SetItem((DICT), (NAME), o) < 0) { \
        Py_DECREF(o); \
        return 0; \
    } \
    Py_DECREF(o); \
Jeremy Hylton's avatar
Jeremy Hylton committed
458 459 460 461
}

/* Decide on scope of name, given flags.

462 463 464
   The namespace dictionaries may be modified to record information
   about the new name.  For example, a new global will add an entry to
   global.  A name that was global can be changed to local.
Jeremy Hylton's avatar
Jeremy Hylton committed
465 466
*/

467
static int
468
analyze_name(PySTEntryObject *ste, PyObject *scopes, PyObject *name, long flags,
469 470
             PyObject *bound, PyObject *local, PyObject *free,
             PyObject *global)
Jeremy Hylton's avatar
Jeremy Hylton committed
471
{
472
    if (flags & DEF_GLOBAL) {
473
        if (flags & DEF_NONLOCAL) {
474 475 476
            PyErr_Format(PyExc_SyntaxError,
                         "name '%U' is nonlocal and global",
                         name);
477
            return error_at_directive(ste, name);
478 479 480 481 482 483 484 485 486 487 488 489
        }
        SET_SCOPE(scopes, name, GLOBAL_EXPLICIT);
        if (PySet_Add(global, name) < 0)
            return 0;
        if (bound && (PySet_Discard(bound, name) < 0))
            return 0;
        return 1;
    }
    if (flags & DEF_NONLOCAL) {
        if (!bound) {
            PyErr_Format(PyExc_SyntaxError,
                         "nonlocal declaration not allowed at module level");
490
            return error_at_directive(ste, name);
491 492 493 494 495 496
        }
        if (!PySet_Contains(bound, name)) {
            PyErr_Format(PyExc_SyntaxError,
                         "no binding for nonlocal '%U' found",
                         name);

497
            return error_at_directive(ste, name);
498 499 500 501 502 503
        }
        SET_SCOPE(scopes, name, FREE);
        ste->ste_free = 1;
        return PySet_Add(free, name) >= 0;
    }
    if (flags & DEF_BOUND) {
504
        SET_SCOPE(scopes, name, LOCAL);
505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531
        if (PySet_Add(local, name) < 0)
            return 0;
        if (PySet_Discard(global, name) < 0)
            return 0;
        return 1;
    }
    /* If an enclosing block has a binding for this name, it
       is a free variable rather than a global variable.
       Note that having a non-NULL bound implies that the block
       is nested.
    */
    if (bound && PySet_Contains(bound, name)) {
        SET_SCOPE(scopes, name, FREE);
        ste->ste_free = 1;
        return PySet_Add(free, name) >= 0;
    }
    /* If a parent has a global statement, then call it global
       explicit?  It could also be global implicit.
     */
    if (global && PySet_Contains(global, name)) {
        SET_SCOPE(scopes, name, GLOBAL_IMPLICIT);
        return 1;
    }
    if (ste->ste_nested)
        ste->ste_free = 1;
    SET_SCOPE(scopes, name, GLOBAL_IMPLICIT);
    return 1;
Jeremy Hylton's avatar
Jeremy Hylton committed
532 533 534 535 536 537 538 539 540 541 542 543 544
}

#undef SET_SCOPE

/* If a name is defined in free and also in locals, then this block
   provides the binding for the free variable.  The name should be
   marked CELL in this block and removed from the free list.

   Note that the current block's free variables are included in free.
   That's safe because no name can be free and local in the same scope.
*/

static int
545
analyze_cells(PyObject *scopes, PyObject *free)
Jeremy Hylton's avatar
Jeremy Hylton committed
546
{
547 548 549 550 551 552 553 554 555 556 557
    PyObject *name, *v, *v_cell;
    int success = 0;
    Py_ssize_t pos = 0;

    v_cell = PyLong_FromLong(CELL);
    if (!v_cell)
        return 0;
    while (PyDict_Next(scopes, &pos, &name, &v)) {
        long scope;
        assert(PyLong_Check(v));
        scope = PyLong_AS_LONG(v);
558
        if (scope != LOCAL)
559 560 561 562 563 564 565 566 567 568 569 570 571
            continue;
        if (!PySet_Contains(free, name))
            continue;
        /* Replace LOCAL with CELL for this name, and remove
           from free. It is safe to replace the value of name
           in the dict, because it will not cause a resize.
         */
        if (PyDict_SetItem(scopes, name, v_cell) < 0)
            goto error;
        if (PySet_Discard(free, name) < 0)
            goto error;
    }
    success = 1;
Jeremy Hylton's avatar
Jeremy Hylton committed
572
 error:
573 574
    Py_DECREF(v_cell);
    return success;
Jeremy Hylton's avatar
Jeremy Hylton committed
575 576
}

577 578 579 580 581 582 583 584 585 586 587 588 589 590
static int
drop_class_free(PySTEntryObject *ste, PyObject *free)
{
    int res;
    if (!GET_IDENTIFIER(__class__))
        return 0;
    res = PySet_Discard(free, __class__);
    if (res < 0)
        return 0;
    if (res)
        ste->ste_needs_class_closure = 1;
    return 1;
}

591 592
/* Enter the final scope information into the ste_symbols dict.
 *
Jeremy Hylton's avatar
Jeremy Hylton committed
593 594 595
 * All arguments are dicts.  Modifies symbols, others are read-only.
*/
static int
596
update_symbols(PyObject *symbols, PyObject *scopes,
597
               PyObject *bound, PyObject *free, int classflag)
Jeremy Hylton's avatar
Jeremy Hylton committed
598
{
599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617
    PyObject *name = NULL, *itr = NULL;
    PyObject *v = NULL, *v_scope = NULL, *v_new = NULL, *v_free = NULL;
    Py_ssize_t pos = 0;

    /* Update scope information for all symbols in this scope */
    while (PyDict_Next(symbols, &pos, &name, &v)) {
        long scope, flags;
        assert(PyLong_Check(v));
        flags = PyLong_AS_LONG(v);
        v_scope = PyDict_GetItem(scopes, name);
        assert(v_scope && PyLong_Check(v_scope));
        scope = PyLong_AS_LONG(v_scope);
        flags |= (scope << SCOPE_OFFSET);
        v_new = PyLong_FromLong(flags);
        if (!v_new)
            return 0;
        if (PyDict_SetItem(symbols, name, v_new) < 0) {
            Py_DECREF(v_new);
            return 0;
Jeremy Hylton's avatar
Jeremy Hylton committed
618
        }
619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657
        Py_DECREF(v_new);
    }

    /* Record not yet resolved free variables from children (if any) */
    v_free = PyLong_FromLong(FREE << SCOPE_OFFSET);
    if (!v_free)
        return 0;

    itr = PyObject_GetIter(free);
    if (!itr)
        goto error;

    while ((name = PyIter_Next(itr))) {
        v = PyDict_GetItem(symbols, name);

        /* Handle symbol that already exists in this scope */
        if (v) {
            /* Handle a free variable in a method of
               the class that has the same name as a local
               or global in the class scope.
            */
            if  (classflag &&
                 PyLong_AS_LONG(v) & (DEF_BOUND | DEF_GLOBAL)) {
                long flags = PyLong_AS_LONG(v) | DEF_FREE_CLASS;
                v_new = PyLong_FromLong(flags);
                if (!v_new) {
                    goto error;
                }
                if (PyDict_SetItem(symbols, name, v_new) < 0) {
                    Py_DECREF(v_new);
                    goto error;
                }
                Py_DECREF(v_new);
            }
            /* It's a cell, or already free in this scope */
            Py_DECREF(name);
            continue;
        }
        /* Handle global symbol */
658
        if (bound && !PySet_Contains(bound, name)) {
659 660 661 662 663 664 665 666 667 668 669 670
            Py_DECREF(name);
            continue;       /* it's a global */
        }
        /* Propagate new free symbol up the lexical stack */
        if (PyDict_SetItem(symbols, name, v_free) < 0) {
            goto error;
        }
        Py_DECREF(name);
    }
    Py_DECREF(itr);
    Py_DECREF(v_free);
    return 1;
671
error:
672 673 674 675 676
    Py_XDECREF(v_free);
    Py_XDECREF(itr);
    Py_XDECREF(name);
    return 0;
}
Jeremy Hylton's avatar
Jeremy Hylton committed
677 678

/* Make final symbol table decisions for block of ste.
679

Jeremy Hylton's avatar
Jeremy Hylton committed
680 681
   Arguments:
   ste -- current symtable entry (input/output)
682 683
   bound -- set of variables bound in enclosing scopes (input).  bound
       is NULL for module blocks.
Jeremy Hylton's avatar
Jeremy Hylton committed
684 685
   free -- set of free variables in enclosed scopes (output)
   globals -- set of declared global variables in enclosing scopes (input)
686 687 688 689 690 691 692 693 694 695

   The implementation uses two mutually recursive functions,
   analyze_block() and analyze_child_block().  analyze_block() is
   responsible for analyzing the individual names defined in a block.
   analyze_child_block() prepares temporary namespace dictionaries
   used to evaluated nested blocks.

   The two functions exist because a child block should see the name
   bindings of its enclosing blocks, but those bindings should not
   propagate back to a parent block.
Jeremy Hylton's avatar
Jeremy Hylton committed
696 697
*/

698
static int
699 700
analyze_child_block(PySTEntryObject *entry, PyObject *bound, PyObject *free,
                    PyObject *global, PyObject* child_free);
701

Jeremy Hylton's avatar
Jeremy Hylton committed
702
static int
703 704
analyze_block(PySTEntryObject *ste, PyObject *bound, PyObject *free,
              PyObject *global)
Jeremy Hylton's avatar
Jeremy Hylton committed
705
{
706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732 733 734 735 736 737 738 739 740 741 742 743 744 745 746 747 748 749 750 751 752 753 754 755 756 757 758 759 760 761 762 763 764 765 766 767 768 769 770 771 772 773 774 775 776 777 778 779 780 781 782 783 784 785 786 787 788 789 790
    PyObject *name, *v, *local = NULL, *scopes = NULL, *newbound = NULL;
    PyObject *newglobal = NULL, *newfree = NULL, *allfree = NULL;
    PyObject *temp;
    int i, success = 0;
    Py_ssize_t pos = 0;

    local = PySet_New(NULL);  /* collect new names bound in block */
    if (!local)
        goto error;
    scopes = PyDict_New();  /* collect scopes defined for each name */
    if (!scopes)
        goto error;

    /* Allocate new global and bound variable dictionaries.  These
       dictionaries hold the names visible in nested blocks.  For
       ClassBlocks, the bound and global names are initialized
       before analyzing names, because class bindings aren't
       visible in methods.  For other blocks, they are initialized
       after names are analyzed.
     */

    /* TODO(jhylton): Package these dicts in a struct so that we
       can write reasonable helper functions?
    */
    newglobal = PySet_New(NULL);
    if (!newglobal)
        goto error;
    newfree = PySet_New(NULL);
    if (!newfree)
        goto error;
    newbound = PySet_New(NULL);
    if (!newbound)
        goto error;

    /* Class namespace has no effect on names visible in
       nested functions, so populate the global and bound
       sets to be passed to child blocks before analyzing
       this one.
     */
    if (ste->ste_type == ClassBlock) {
        /* Pass down known globals */
        temp = PyNumber_InPlaceOr(newglobal, global);
        if (!temp)
            goto error;
        Py_DECREF(temp);
        /* Pass down previously bound symbols */
        if (bound) {
            temp = PyNumber_InPlaceOr(newbound, bound);
            if (!temp)
                goto error;
            Py_DECREF(temp);
        }
    }

    while (PyDict_Next(ste->ste_symbols, &pos, &name, &v)) {
        long flags = PyLong_AS_LONG(v);
        if (!analyze_name(ste, scopes, name, flags,
                          bound, local, free, global))
            goto error;
    }

    /* Populate global and bound sets to be passed to children. */
    if (ste->ste_type != ClassBlock) {
        /* Add function locals to bound set */
        if (ste->ste_type == FunctionBlock) {
            temp = PyNumber_InPlaceOr(newbound, local);
            if (!temp)
                goto error;
            Py_DECREF(temp);
        }
        /* Pass down previously bound symbols */
        if (bound) {
            temp = PyNumber_InPlaceOr(newbound, bound);
            if (!temp)
                goto error;
            Py_DECREF(temp);
        }
        /* Pass down known globals */
        temp = PyNumber_InPlaceOr(newglobal, global);
        if (!temp)
            goto error;
        Py_DECREF(temp);
    }
    else {
        /* Special-case __class__ */
791 792
        if (!GET_IDENTIFIER(__class__))
            goto error;
793 794 795 796
        if (PySet_Add(newbound, __class__) < 0)
            goto error;
    }

797
    /* Recursively call analyze_child_block() on each child block.
798 799 800 801 802 803 804 805 806 807 808 809 810 811 812 813 814 815 816 817 818 819 820 821 822 823 824

       newbound, newglobal now contain the names visible in
       nested blocks.  The free variables in the children will
       be collected in allfree.
    */
    allfree = PySet_New(NULL);
    if (!allfree)
        goto error;
    for (i = 0; i < PyList_GET_SIZE(ste->ste_children); ++i) {
        PyObject *c = PyList_GET_ITEM(ste->ste_children, i);
        PySTEntryObject* entry;
        assert(c && PySTEntry_Check(c));
        entry = (PySTEntryObject*)c;
        if (!analyze_child_block(entry, newbound, newfree, newglobal,
                                 allfree))
            goto error;
        /* Check if any children have free variables */
        if (entry->ste_free || entry->ste_child_free)
            ste->ste_child_free = 1;
    }

    temp = PyNumber_InPlaceOr(newfree, allfree);
    if (!temp)
        goto error;
    Py_DECREF(temp);

    /* Check if any local variables must be converted to cell variables */
825
    if (ste->ste_type == FunctionBlock && !analyze_cells(scopes, newfree))
826
        goto error;
827
    else if (ste->ste_type == ClassBlock && !drop_class_free(ste, newfree))
828 829 830 831 832 833 834 835 836 837 838
        goto error;
    /* Records the results of the analysis in the symbol table entry */
    if (!update_symbols(ste->ste_symbols, scopes, bound, newfree,
                        ste->ste_type == ClassBlock))
        goto error;

    temp = PyNumber_InPlaceOr(free, newfree);
    if (!temp)
        goto error;
    Py_DECREF(temp);
    success = 1;
Jeremy Hylton's avatar
Jeremy Hylton committed
839
 error:
840 841 842 843 844 845 846 847 848
    Py_XDECREF(scopes);
    Py_XDECREF(local);
    Py_XDECREF(newbound);
    Py_XDECREF(newglobal);
    Py_XDECREF(newfree);
    Py_XDECREF(allfree);
    if (!success)
        assert(PyErr_Occurred());
    return success;
Jeremy Hylton's avatar
Jeremy Hylton committed
849 850
}

851
static int
852 853
analyze_child_block(PySTEntryObject *entry, PyObject *bound, PyObject *free,
                    PyObject *global, PyObject* child_free)
854
{
855 856 857 858 859
    PyObject *temp_bound = NULL, *temp_global = NULL, *temp_free = NULL;
    PyObject *temp;

    /* Copy the bound and global dictionaries.

860
       These dictionaries are used by all blocks enclosed by the
861 862 863 864 865 866 867 868 869 870 871 872 873 874 875 876 877 878 879 880 881 882 883 884
       current block.  The analyze_block() call modifies these
       dictionaries.

    */
    temp_bound = PySet_New(bound);
    if (!temp_bound)
        goto error;
    temp_free = PySet_New(free);
    if (!temp_free)
        goto error;
    temp_global = PySet_New(global);
    if (!temp_global)
        goto error;

    if (!analyze_block(entry, temp_bound, temp_free, temp_global))
        goto error;
    temp = PyNumber_InPlaceOr(child_free, temp_free);
    if (!temp)
        goto error;
    Py_DECREF(temp);
    Py_DECREF(temp_bound);
    Py_DECREF(temp_free);
    Py_DECREF(temp_global);
    return 1;
885
 error:
886 887 888 889
    Py_XDECREF(temp_bound);
    Py_XDECREF(temp_free);
    Py_XDECREF(temp_global);
    return 0;
890 891
}

Jeremy Hylton's avatar
Jeremy Hylton committed
892 893 894
static int
symtable_analyze(struct symtable *st)
{
895 896 897 898 899 900 901 902 903 904 905 906 907 908 909
    PyObject *free, *global;
    int r;

    free = PySet_New(NULL);
    if (!free)
        return 0;
    global = PySet_New(NULL);
    if (!global) {
        Py_DECREF(free);
        return 0;
    }
    r = analyze_block(st->st_top, NULL, free, global);
    Py_DECREF(free);
    Py_DECREF(global);
    return r;
Jeremy Hylton's avatar
Jeremy Hylton committed
910 911
}

912
/* symtable_enter_block() gets a reference via ste_new.
Jeremy Hylton's avatar
Jeremy Hylton committed
913 914 915 916 917 918 919
   This reference is released when the block is exited, via the DECREF
   in symtable_exit_block().
*/

static int
symtable_exit_block(struct symtable *st, void *ast)
{
920
    Py_ssize_t size;
921

922 923 924 925
    st->st_cur = NULL;
    size = PyList_GET_SIZE(st->st_stack);
    if (size) {
        if (PyList_SetSlice(st->st_stack, size - 1, size, NULL) < 0)
926
            return 0;
927 928
        if (--size)
            st->st_cur = (PySTEntryObject *)PyList_GET_ITEM(st->st_stack, size - 1);
929 930
    }
    return 1;
Jeremy Hylton's avatar
Jeremy Hylton committed
931 932 933
}

static int
934
symtable_enter_block(struct symtable *st, identifier name, _Py_block_ty block,
935
                     void *ast, int lineno, int col_offset)
Jeremy Hylton's avatar
Jeremy Hylton committed
936
{
937
    PySTEntryObject *prev = NULL, *ste;
938

939 940
    ste = ste_new(st, name, block, ast, lineno, col_offset);
    if (ste == NULL)
941
        return 0;
942 943 944 945 946 947 948 949
    if (PyList_Append(st->st_stack, (PyObject *)ste) < 0) {
        Py_DECREF(ste);
        return 0;
    }
    prev = st->st_cur;
    /* The entry is owned by the stack. Borrow it for st_cur. */
    Py_DECREF(ste);
    st->st_cur = ste;
950
    if (block == ModuleBlock)
951 952
        st->st_global = st->st_cur->ste_symbols;
    if (prev) {
953
        if (PyList_Append(prev->ste_children, (PyObject *)ste) < 0) {
954 955 956 957
            return 0;
        }
    }
    return 1;
Jeremy Hylton's avatar
Jeremy Hylton committed
958 959
}

960
static long
Jeremy Hylton's avatar
Jeremy Hylton committed
961 962
symtable_lookup(struct symtable *st, PyObject *name)
{
963 964 965 966 967 968 969 970 971
    PyObject *o;
    PyObject *mangled = _Py_Mangle(st->st_private, name);
    if (!mangled)
        return 0;
    o = PyDict_GetItem(st->st_cur->ste_symbols, mangled);
    Py_DECREF(mangled);
    if (!o)
        return 0;
    return PyLong_AsLong(o);
Jeremy Hylton's avatar
Jeremy Hylton committed
972 973 974
}

static int
975
symtable_add_def(struct symtable *st, PyObject *name, int flag)
Jeremy Hylton's avatar
Jeremy Hylton committed
976
{
977 978 979 980 981 982 983 984 985 986 987 988 989 990
    PyObject *o;
    PyObject *dict;
    long val;
    PyObject *mangled = _Py_Mangle(st->st_private, name);


    if (!mangled)
        return 0;
    dict = st->st_cur->ste_symbols;
    if ((o = PyDict_GetItem(dict, mangled))) {
        val = PyLong_AS_LONG(o);
        if ((flag & DEF_PARAM) && (val & DEF_PARAM)) {
            /* Is it better to use 'mangled' or 'name' here? */
            PyErr_Format(PyExc_SyntaxError, DUPLICATE_ARGUMENT, name);
991 992 993
            PyErr_SyntaxLocationObject(st->st_filename,
                                       st->st_cur->ste_lineno,
                                       st->st_cur->ste_col_offset);
994 995 996 997 998 999 1000 1001 1002 1003 1004 1005 1006 1007 1008 1009 1010 1011 1012 1013 1014 1015 1016 1017 1018
            goto error;
        }
        val |= flag;
    } else
        val = flag;
    o = PyLong_FromLong(val);
    if (o == NULL)
        goto error;
    if (PyDict_SetItem(dict, mangled, o) < 0) {
        Py_DECREF(o);
        goto error;
    }
    Py_DECREF(o);

    if (flag & DEF_PARAM) {
        if (PyList_Append(st->st_cur->ste_varnames, mangled) < 0)
            goto error;
    } else      if (flag & DEF_GLOBAL) {
        /* XXX need to update DEF_GLOBAL for other flags too;
           perhaps only DEF_FREE_GLOBAL */
        val = flag;
        if ((o = PyDict_GetItem(st->st_global, mangled))) {
            val |= PyLong_AS_LONG(o);
        }
        o = PyLong_FromLong(val);
Jeremy Hylton's avatar
Jeremy Hylton committed
1019
        if (o == NULL)
1020 1021 1022 1023 1024 1025 1026 1027 1028
            goto error;
        if (PyDict_SetItem(st->st_global, mangled, o) < 0) {
            Py_DECREF(o);
            goto error;
        }
        Py_DECREF(o);
    }
    Py_DECREF(mangled);
    return 1;
1029 1030

error:
1031 1032
    Py_DECREF(mangled);
    return 0;
Jeremy Hylton's avatar
Jeremy Hylton committed
1033 1034 1035 1036
}

/* VISIT, VISIT_SEQ and VIST_SEQ_TAIL take an ASDL type as their second argument.
   They use the ASDL name to synthesize the name of the C type and the visit
1037 1038
   function.

Jeremy Hylton's avatar
Jeremy Hylton committed
1039 1040
   VISIT_SEQ_TAIL permits the start of an ASDL sequence to be skipped, which is
   useful if the first node in the sequence requires special treatment.
1041 1042 1043

   VISIT_QUIT macro returns the specified value exiting from the function but
   first adjusts current recursion counter depth.
Jeremy Hylton's avatar
Jeremy Hylton committed
1044 1045
*/

1046 1047 1048
#define VISIT_QUIT(ST, X) \
    return --(ST)->recursion_depth,(X)

Jeremy Hylton's avatar
Jeremy Hylton committed
1049
#define VISIT(ST, TYPE, V) \
1050
    if (!symtable_visit_ ## TYPE((ST), (V))) \
1051
        VISIT_QUIT((ST), 0);
1052

Jeremy Hylton's avatar
Jeremy Hylton committed
1053
#define VISIT_SEQ(ST, TYPE, SEQ) { \
1054 1055 1056 1057 1058
    int i; \
    asdl_seq *seq = (SEQ); /* avoid variable capture */ \
    for (i = 0; i < asdl_seq_LEN(seq); i++) { \
        TYPE ## _ty elt = (TYPE ## _ty)asdl_seq_GET(seq, i); \
        if (!symtable_visit_ ## TYPE((ST), elt)) \
1059
            VISIT_QUIT((ST), 0);                 \
1060
    } \
Jeremy Hylton's avatar
Jeremy Hylton committed
1061
}
1062

Jeremy Hylton's avatar
Jeremy Hylton committed
1063
#define VISIT_SEQ_TAIL(ST, TYPE, SEQ, START) { \
1064 1065 1066 1067 1068
    int i; \
    asdl_seq *seq = (SEQ); /* avoid variable capture */ \
    for (i = (START); i < asdl_seq_LEN(seq); i++) { \
        TYPE ## _ty elt = (TYPE ## _ty)asdl_seq_GET(seq, i); \
        if (!symtable_visit_ ## TYPE((ST), elt)) \
1069
            VISIT_QUIT((ST), 0);                 \
1070
    } \
Jeremy Hylton's avatar
Jeremy Hylton committed
1071
}
1072

1073
#define VISIT_SEQ_WITH_NULL(ST, TYPE, SEQ) {     \
1074
    int i = 0; \
1075
    asdl_seq *seq = (SEQ); /* avoid variable capture */ \
1076
    for (i = 0; i < asdl_seq_LEN(seq); i++) { \
1077
        TYPE ## _ty elt = (TYPE ## _ty)asdl_seq_GET(seq, i); \
1078
        if (!elt) continue; /* can be NULL */ \
1079
        if (!symtable_visit_ ## TYPE((ST), elt)) \
1080
            VISIT_QUIT((ST), 0);             \
1081
    } \
1082 1083
}

1084 1085 1086
static int
symtable_record_directive(struct symtable *st, identifier name, stmt_ty s)
{
1087
    PyObject *data, *mangled;
1088 1089 1090 1091 1092 1093
    int res;
    if (!st->st_cur->ste_directives) {
        st->st_cur->ste_directives = PyList_New(0);
        if (!st->st_cur->ste_directives)
            return 0;
    }
1094 1095 1096 1097
    mangled = _Py_Mangle(st->st_private, name);
    if (!mangled)
        return 0;
    data = Py_BuildValue("(Nii)", mangled, s->lineno, s->col_offset);
1098 1099 1100 1101 1102 1103 1104 1105
    if (!data)
        return 0;
    res = PyList_Append(st->st_cur->ste_directives, data);
    Py_DECREF(data);
    return res == 0;
}


Jeremy Hylton's avatar
Jeremy Hylton committed
1106 1107 1108
static int
symtable_visit_stmt(struct symtable *st, stmt_ty s)
{
1109
    if (++st->recursion_depth > st->recursion_limit) {
1110
        PyErr_SetString(PyExc_RecursionError,
1111 1112 1113
                        "maximum recursion depth exceeded during compilation");
        VISIT_QUIT(st, 0);
    }
1114 1115 1116
    switch (s->kind) {
    case FunctionDef_kind:
        if (!symtable_add_def(st, s->v.FunctionDef.name, DEF_LOCAL))
1117
            VISIT_QUIT(st, 0);
1118 1119 1120
        if (s->v.FunctionDef.args->defaults)
            VISIT_SEQ(st, expr, s->v.FunctionDef.args->defaults);
        if (s->v.FunctionDef.args->kw_defaults)
1121
            VISIT_SEQ_WITH_NULL(st, expr, s->v.FunctionDef.args->kw_defaults);
1122 1123
        if (!symtable_visit_annotations(st, s, s->v.FunctionDef.args,
                                        s->v.FunctionDef.returns))
1124
            VISIT_QUIT(st, 0);
1125 1126 1127
        if (s->v.FunctionDef.decorator_list)
            VISIT_SEQ(st, expr, s->v.FunctionDef.decorator_list);
        if (!symtable_enter_block(st, s->v.FunctionDef.name,
1128 1129
                                  FunctionBlock, (void *)s, s->lineno,
                                  s->col_offset))
1130
            VISIT_QUIT(st, 0);
1131 1132
        VISIT(st, arguments, s->v.FunctionDef.args);
        VISIT_SEQ(st, stmt, s->v.FunctionDef.body);
1133
        if (!symtable_exit_block(st, s))
1134
            VISIT_QUIT(st, 0);
1135 1136 1137 1138
        break;
    case ClassDef_kind: {
        PyObject *tmp;
        if (!symtable_add_def(st, s->v.ClassDef.name, DEF_LOCAL))
1139
            VISIT_QUIT(st, 0);
1140 1141 1142 1143 1144
        VISIT_SEQ(st, expr, s->v.ClassDef.bases);
        VISIT_SEQ(st, keyword, s->v.ClassDef.keywords);
        if (s->v.ClassDef.decorator_list)
            VISIT_SEQ(st, expr, s->v.ClassDef.decorator_list);
        if (!symtable_enter_block(st, s->v.ClassDef.name, ClassBlock,
1145
                                  (void *)s, s->lineno, s->col_offset))
1146
            VISIT_QUIT(st, 0);
1147 1148
        tmp = st->st_private;
        st->st_private = s->v.ClassDef.name;
1149
        VISIT_SEQ(st, stmt, s->v.ClassDef.body);
1150 1151
        st->st_private = tmp;
        if (!symtable_exit_block(st, s))
1152
            VISIT_QUIT(st, 0);
1153 1154 1155 1156 1157 1158 1159 1160 1161 1162 1163 1164 1165 1166 1167
        break;
    }
    case Return_kind:
        if (s->v.Return.value) {
            VISIT(st, expr, s->v.Return.value);
            st->st_cur->ste_returns_value = 1;
        }
        break;
    case Delete_kind:
        VISIT_SEQ(st, expr, s->v.Delete.targets);
        break;
    case Assign_kind:
        VISIT_SEQ(st, expr, s->v.Assign.targets);
        VISIT(st, expr, s->v.Assign.value);
        break;
1168 1169 1170 1171 1172 1173 1174 1175 1176 1177
    case AnnAssign_kind:
        if (s->v.AnnAssign.target->kind == Name_kind) {
            expr_ty e_name = s->v.AnnAssign.target;
            long cur = symtable_lookup(st, e_name->v.Name.id);
            if (cur < 0) {
                VISIT_QUIT(st, 0);
            }
            if ((cur & (DEF_GLOBAL | DEF_NONLOCAL))
                && s->v.AnnAssign.simple) {
                PyErr_Format(PyExc_SyntaxError,
1178 1179
                             cur & DEF_GLOBAL ? GLOBAL_ANNOT : NONLOCAL_ANNOT,
                             e_name->v.Name.id);
1180 1181 1182 1183 1184 1185 1186 1187 1188 1189 1190 1191 1192 1193 1194 1195 1196 1197 1198 1199 1200 1201 1202 1203 1204
                PyErr_SyntaxLocationObject(st->st_filename,
                                           s->lineno,
                                           s->col_offset);
                VISIT_QUIT(st, 0);
            }
            if (s->v.AnnAssign.simple &&
                !symtable_add_def(st, e_name->v.Name.id,
                                  DEF_ANNOT | DEF_LOCAL)) {
                VISIT_QUIT(st, 0);
            }
            else {
                if (s->v.AnnAssign.value
                    && !symtable_add_def(st, e_name->v.Name.id, DEF_LOCAL)) {
                    VISIT_QUIT(st, 0);
                }
            }
        }
        else {
            VISIT(st, expr, s->v.AnnAssign.target);
        }
        VISIT(st, expr, s->v.AnnAssign.annotation);
        if (s->v.AnnAssign.value) {
            VISIT(st, expr, s->v.AnnAssign.value);
        }
        break;
1205 1206 1207 1208 1209 1210 1211 1212 1213 1214 1215 1216 1217 1218 1219 1220 1221 1222 1223 1224 1225 1226 1227 1228 1229 1230 1231
    case AugAssign_kind:
        VISIT(st, expr, s->v.AugAssign.target);
        VISIT(st, expr, s->v.AugAssign.value);
        break;
    case For_kind:
        VISIT(st, expr, s->v.For.target);
        VISIT(st, expr, s->v.For.iter);
        VISIT_SEQ(st, stmt, s->v.For.body);
        if (s->v.For.orelse)
            VISIT_SEQ(st, stmt, s->v.For.orelse);
        break;
    case While_kind:
        VISIT(st, expr, s->v.While.test);
        VISIT_SEQ(st, stmt, s->v.While.body);
        if (s->v.While.orelse)
            VISIT_SEQ(st, stmt, s->v.While.orelse);
        break;
    case If_kind:
        /* XXX if 0: and lookup_yield() hacks */
        VISIT(st, expr, s->v.If.test);
        VISIT_SEQ(st, stmt, s->v.If.body);
        if (s->v.If.orelse)
            VISIT_SEQ(st, stmt, s->v.If.orelse);
        break;
    case Raise_kind:
        if (s->v.Raise.exc) {
            VISIT(st, expr, s->v.Raise.exc);
1232 1233 1234
            if (s->v.Raise.cause) {
                VISIT(st, expr, s->v.Raise.cause);
            }
1235 1236
        }
        break;
1237 1238 1239 1240 1241
    case Try_kind:
        VISIT_SEQ(st, stmt, s->v.Try.body);
        VISIT_SEQ(st, stmt, s->v.Try.orelse);
        VISIT_SEQ(st, excepthandler, s->v.Try.handlers);
        VISIT_SEQ(st, stmt, s->v.Try.finalbody);
1242 1243 1244 1245 1246 1247 1248 1249 1250 1251 1252 1253 1254 1255 1256 1257 1258 1259 1260
        break;
    case Assert_kind:
        VISIT(st, expr, s->v.Assert.test);
        if (s->v.Assert.msg)
            VISIT(st, expr, s->v.Assert.msg);
        break;
    case Import_kind:
        VISIT_SEQ(st, alias, s->v.Import.names);
        break;
    case ImportFrom_kind:
        VISIT_SEQ(st, alias, s->v.ImportFrom.names);
        break;
    case Global_kind: {
        int i;
        asdl_seq *seq = s->v.Global.names;
        for (i = 0; i < asdl_seq_LEN(seq); i++) {
            identifier name = (identifier)asdl_seq_GET(seq, i);
            long cur = symtable_lookup(st, name);
            if (cur < 0)
1261
                VISIT_QUIT(st, 0);
1262 1263 1264 1265 1266
            if (cur & (DEF_PARAM | DEF_LOCAL | USE | DEF_ANNOT)) {
                const char* msg;
                if (cur & DEF_PARAM) {
                    msg = GLOBAL_PARAM;
                } else if (cur & USE) {
1267 1268
                    msg = GLOBAL_AFTER_USE;
                } else if (cur & DEF_ANNOT) {
1269
                    msg = GLOBAL_ANNOT;
1270
                } else {  /* DEF_LOCAL */
1271 1272
                    msg = GLOBAL_AFTER_ASSIGN;
                }
1273
                PyErr_Format(PyExc_SyntaxError,
1274
                             msg, name);
1275 1276 1277 1278 1279
                PyErr_SyntaxLocationObject(st->st_filename,
                                           s->lineno,
                                           s->col_offset);
                VISIT_QUIT(st, 0);
            }
1280
            if (!symtable_add_def(st, name, DEF_GLOBAL))
1281
                VISIT_QUIT(st, 0);
1282
            if (!symtable_record_directive(st, name, s))
1283
                VISIT_QUIT(st, 0);
1284 1285 1286 1287 1288 1289 1290 1291 1292 1293
        }
        break;
    }
    case Nonlocal_kind: {
        int i;
        asdl_seq *seq = s->v.Nonlocal.names;
        for (i = 0; i < asdl_seq_LEN(seq); i++) {
            identifier name = (identifier)asdl_seq_GET(seq, i);
            long cur = symtable_lookup(st, name);
            if (cur < 0)
1294
                VISIT_QUIT(st, 0);
1295 1296 1297 1298 1299
            if (cur & (DEF_PARAM | DEF_LOCAL | USE | DEF_ANNOT)) {
                const char* msg;
                if (cur & DEF_PARAM) {
                    msg = NONLOCAL_PARAM;
                } else if (cur & USE) {
1300 1301
                    msg = NONLOCAL_AFTER_USE;
                } else if (cur & DEF_ANNOT) {
1302
                    msg = NONLOCAL_ANNOT;
1303
                } else {  /* DEF_LOCAL */
1304 1305 1306
                    msg = NONLOCAL_AFTER_ASSIGN;
                }
                PyErr_Format(PyExc_SyntaxError, msg, name);
1307 1308 1309 1310 1311
                PyErr_SyntaxLocationObject(st->st_filename,
                                           s->lineno,
                                           s->col_offset);
                VISIT_QUIT(st, 0);
            }
1312
            if (!symtable_add_def(st, name, DEF_NONLOCAL))
1313
                VISIT_QUIT(st, 0);
1314
            if (!symtable_record_directive(st, name, s))
1315
                VISIT_QUIT(st, 0);
1316 1317 1318 1319 1320 1321 1322 1323 1324 1325 1326 1327
        }
        break;
    }
    case Expr_kind:
        VISIT(st, expr, s->v.Expr.value);
        break;
    case Pass_kind:
    case Break_kind:
    case Continue_kind:
        /* nothing to do here */
        break;
    case With_kind:
1328
        VISIT_SEQ(st, withitem, s->v.With.items);
1329 1330
        VISIT_SEQ(st, stmt, s->v.With.body);
        break;
1331 1332 1333 1334 1335 1336 1337 1338 1339 1340 1341 1342 1343 1344 1345 1346 1347
    case AsyncFunctionDef_kind:
        if (!symtable_add_def(st, s->v.AsyncFunctionDef.name, DEF_LOCAL))
            VISIT_QUIT(st, 0);
        if (s->v.AsyncFunctionDef.args->defaults)
            VISIT_SEQ(st, expr, s->v.AsyncFunctionDef.args->defaults);
        if (s->v.AsyncFunctionDef.args->kw_defaults)
            VISIT_SEQ_WITH_NULL(st, expr,
                                s->v.AsyncFunctionDef.args->kw_defaults);
        if (!symtable_visit_annotations(st, s, s->v.AsyncFunctionDef.args,
                                        s->v.AsyncFunctionDef.returns))
            VISIT_QUIT(st, 0);
        if (s->v.AsyncFunctionDef.decorator_list)
            VISIT_SEQ(st, expr, s->v.AsyncFunctionDef.decorator_list);
        if (!symtable_enter_block(st, s->v.AsyncFunctionDef.name,
                                  FunctionBlock, (void *)s, s->lineno,
                                  s->col_offset))
            VISIT_QUIT(st, 0);
1348
        st->st_cur->ste_coroutine = 1;
1349 1350 1351 1352 1353 1354 1355 1356 1357 1358 1359 1360 1361 1362 1363 1364
        VISIT(st, arguments, s->v.AsyncFunctionDef.args);
        VISIT_SEQ(st, stmt, s->v.AsyncFunctionDef.body);
        if (!symtable_exit_block(st, s))
            VISIT_QUIT(st, 0);
        break;
    case AsyncWith_kind:
        VISIT_SEQ(st, withitem, s->v.AsyncWith.items);
        VISIT_SEQ(st, stmt, s->v.AsyncWith.body);
        break;
    case AsyncFor_kind:
        VISIT(st, expr, s->v.AsyncFor.target);
        VISIT(st, expr, s->v.AsyncFor.iter);
        VISIT_SEQ(st, stmt, s->v.AsyncFor.body);
        if (s->v.AsyncFor.orelse)
            VISIT_SEQ(st, stmt, s->v.AsyncFor.orelse);
        break;
1365
    }
1366
    VISIT_QUIT(st, 1);
Jeremy Hylton's avatar
Jeremy Hylton committed
1367 1368
}

1369
static int
Jeremy Hylton's avatar
Jeremy Hylton committed
1370 1371
symtable_visit_expr(struct symtable *st, expr_ty e)
{
1372
    if (++st->recursion_depth > st->recursion_limit) {
1373
        PyErr_SetString(PyExc_RecursionError,
1374 1375 1376
                        "maximum recursion depth exceeded during compilation");
        VISIT_QUIT(st, 0);
    }
1377 1378 1379 1380 1381 1382 1383 1384 1385 1386 1387 1388 1389
    switch (e->kind) {
    case BoolOp_kind:
        VISIT_SEQ(st, expr, e->v.BoolOp.values);
        break;
    case BinOp_kind:
        VISIT(st, expr, e->v.BinOp.left);
        VISIT(st, expr, e->v.BinOp.right);
        break;
    case UnaryOp_kind:
        VISIT(st, expr, e->v.UnaryOp.operand);
        break;
    case Lambda_kind: {
        if (!GET_IDENTIFIER(lambda))
1390
            VISIT_QUIT(st, 0);
1391 1392
        if (e->v.Lambda.args->defaults)
            VISIT_SEQ(st, expr, e->v.Lambda.args->defaults);
1393
        if (e->v.Lambda.args->kw_defaults)
1394
            VISIT_SEQ_WITH_NULL(st, expr, e->v.Lambda.args->kw_defaults);
1395
        if (!symtable_enter_block(st, lambda,
1396 1397
                                  FunctionBlock, (void *)e, e->lineno,
                                  e->col_offset))
1398
            VISIT_QUIT(st, 0);
1399 1400
        VISIT(st, arguments, e->v.Lambda.args);
        VISIT(st, expr, e->v.Lambda.body);
1401
        if (!symtable_exit_block(st, (void *)e))
1402
            VISIT_QUIT(st, 0);
1403 1404 1405 1406 1407 1408 1409 1410
        break;
    }
    case IfExp_kind:
        VISIT(st, expr, e->v.IfExp.test);
        VISIT(st, expr, e->v.IfExp.body);
        VISIT(st, expr, e->v.IfExp.orelse);
        break;
    case Dict_kind:
1411
        VISIT_SEQ_WITH_NULL(st, expr, e->v.Dict.keys);
1412 1413 1414 1415 1416 1417 1418
        VISIT_SEQ(st, expr, e->v.Dict.values);
        break;
    case Set_kind:
        VISIT_SEQ(st, expr, e->v.Set.elts);
        break;
    case GeneratorExp_kind:
        if (!symtable_visit_genexp(st, e))
1419
            VISIT_QUIT(st, 0);
1420 1421 1422
        break;
    case ListComp_kind:
        if (!symtable_visit_listcomp(st, e))
1423
            VISIT_QUIT(st, 0);
1424 1425 1426
        break;
    case SetComp_kind:
        if (!symtable_visit_setcomp(st, e))
1427
            VISIT_QUIT(st, 0);
1428 1429 1430
        break;
    case DictComp_kind:
        if (!symtable_visit_dictcomp(st, e))
1431
            VISIT_QUIT(st, 0);
1432 1433
        break;
    case Yield_kind:
1434 1435 1436 1437 1438 1439
        if (e->v.Yield.value)
            VISIT(st, expr, e->v.Yield.value);
        st->st_cur->ste_generator = 1;
        break;
    case YieldFrom_kind:
        VISIT(st, expr, e->v.YieldFrom.value);
1440 1441
        st->st_cur->ste_generator = 1;
        break;
1442 1443
    case Await_kind:
        VISIT(st, expr, e->v.Await.value);
1444
        st->st_cur->ste_coroutine = 1;
1445
        break;
1446 1447 1448 1449 1450 1451 1452
    case Compare_kind:
        VISIT(st, expr, e->v.Compare.left);
        VISIT_SEQ(st, expr, e->v.Compare.comparators);
        break;
    case Call_kind:
        VISIT(st, expr, e->v.Call.func);
        VISIT_SEQ(st, expr, e->v.Call.args);
1453
        VISIT_SEQ_WITH_NULL(st, keyword, e->v.Call.keywords);
1454
        break;
1455 1456 1457 1458 1459 1460 1461 1462
    case FormattedValue_kind:
        VISIT(st, expr, e->v.FormattedValue.value);
        if (e->v.FormattedValue.format_spec)
            VISIT(st, expr, e->v.FormattedValue.format_spec);
        break;
    case JoinedStr_kind:
        VISIT_SEQ(st, expr, e->v.JoinedStr.values);
        break;
Victor Stinner's avatar
Victor Stinner committed
1463
    case Constant_kind:
1464 1465 1466 1467
    case Num_kind:
    case Str_kind:
    case Bytes_kind:
    case Ellipsis_kind:
1468
    case NameConstant_kind:
1469 1470 1471 1472 1473 1474 1475 1476 1477 1478 1479 1480 1481 1482 1483 1484
        /* Nothing to do here. */
        break;
    /* The following exprs can be assignment targets. */
    case Attribute_kind:
        VISIT(st, expr, e->v.Attribute.value);
        break;
    case Subscript_kind:
        VISIT(st, expr, e->v.Subscript.value);
        VISIT(st, slice, e->v.Subscript.slice);
        break;
    case Starred_kind:
        VISIT(st, expr, e->v.Starred.value);
        break;
    case Name_kind:
        if (!symtable_add_def(st, e->v.Name.id,
                              e->v.Name.ctx == Load ? USE : DEF_LOCAL))
1485
            VISIT_QUIT(st, 0);
1486 1487 1488
        /* Special-case super: it counts as a use of __class__ */
        if (e->v.Name.ctx == Load &&
            st->st_cur->ste_type == FunctionBlock &&
1489
            _PyUnicode_EqualToASCIIString(e->v.Name.id, "super")) {
1490 1491
            if (!GET_IDENTIFIER(__class__) ||
                !symtable_add_def(st, __class__, USE))
1492
                VISIT_QUIT(st, 0);
1493 1494 1495 1496 1497 1498 1499 1500 1501 1502
        }
        break;
    /* child nodes of List and Tuple will have expr_context set */
    case List_kind:
        VISIT_SEQ(st, expr, e->v.List.elts);
        break;
    case Tuple_kind:
        VISIT_SEQ(st, expr, e->v.Tuple.elts);
        break;
    }
1503
    VISIT_QUIT(st, 1);
Jeremy Hylton's avatar
Jeremy Hylton committed
1504 1505 1506 1507 1508
}

static int
symtable_implicit_arg(struct symtable *st, int pos)
{
1509 1510 1511 1512 1513 1514 1515 1516 1517
    PyObject *id = PyUnicode_FromFormat(".%d", pos);
    if (id == NULL)
        return 0;
    if (!symtable_add_def(st, id, DEF_PARAM)) {
        Py_DECREF(id);
        return 0;
    }
    Py_DECREF(id);
    return 1;
Jeremy Hylton's avatar
Jeremy Hylton committed
1518 1519
}

1520
static int
1521
symtable_visit_params(struct symtable *st, asdl_seq *args)
Jeremy Hylton's avatar
Jeremy Hylton committed
1522
{
1523 1524 1525 1526 1527 1528 1529 1530 1531 1532 1533 1534
    int i;

    if (!args)
        return -1;

    for (i = 0; i < asdl_seq_LEN(args); i++) {
        arg_ty arg = (arg_ty)asdl_seq_GET(args, i);
        if (!symtable_add_def(st, arg->arg, DEF_PARAM))
            return 0;
    }

    return 1;
Jeremy Hylton's avatar
Jeremy Hylton committed
1535 1536
}

1537
static int
1538
symtable_visit_argannotations(struct symtable *st, asdl_seq *args)
Jeremy Hylton's avatar
Jeremy Hylton committed
1539
{
1540 1541 1542 1543 1544 1545 1546 1547 1548 1549 1550 1551
    int i;

    if (!args)
        return -1;

    for (i = 0; i < asdl_seq_LEN(args); i++) {
        arg_ty arg = (arg_ty)asdl_seq_GET(args, i);
        if (arg->annotation)
            VISIT(st, expr, arg->annotation);
    }

    return 1;
1552 1553 1554
}

static int
1555 1556
symtable_visit_annotations(struct symtable *st, stmt_ty s,
                           arguments_ty a, expr_ty returns)
1557
{
1558 1559
    if (a->args && !symtable_visit_argannotations(st, a->args))
        return 0;
1560 1561 1562 1563
    if (a->vararg && a->vararg->annotation)
        VISIT(st, expr, a->vararg->annotation);
    if (a->kwarg && a->kwarg->annotation)
        VISIT(st, expr, a->kwarg->annotation);
1564 1565
    if (a->kwonlyargs && !symtable_visit_argannotations(st, a->kwonlyargs))
        return 0;
1566
    if (returns)
1567
        VISIT(st, expr, returns);
1568
    return 1;
Jeremy Hylton's avatar
Jeremy Hylton committed
1569 1570
}

1571
static int
Jeremy Hylton's avatar
Jeremy Hylton committed
1572 1573
symtable_visit_arguments(struct symtable *st, arguments_ty a)
{
1574 1575 1576 1577 1578 1579 1580 1581
    /* skip default arguments inside function block
       XXX should ast be different?
    */
    if (a->args && !symtable_visit_params(st, a->args))
        return 0;
    if (a->kwonlyargs && !symtable_visit_params(st, a->kwonlyargs))
        return 0;
    if (a->vararg) {
1582
        if (!symtable_add_def(st, a->vararg->arg, DEF_PARAM))
1583 1584 1585 1586
            return 0;
        st->st_cur->ste_varargs = 1;
    }
    if (a->kwarg) {
1587
        if (!symtable_add_def(st, a->kwarg->arg, DEF_PARAM))
1588 1589 1590 1591
            return 0;
        st->st_cur->ste_varkeywords = 1;
    }
    return 1;
Jeremy Hylton's avatar
Jeremy Hylton committed
1592 1593 1594
}


1595
static int
Jeremy Hylton's avatar
Jeremy Hylton committed
1596 1597
symtable_visit_excepthandler(struct symtable *st, excepthandler_ty eh)
{
1598 1599 1600 1601 1602 1603 1604
    if (eh->v.ExceptHandler.type)
        VISIT(st, expr, eh->v.ExceptHandler.type);
    if (eh->v.ExceptHandler.name)
        if (!symtable_add_def(st, eh->v.ExceptHandler.name, DEF_LOCAL))
            return 0;
    VISIT_SEQ(st, stmt, eh->v.ExceptHandler.body);
    return 1;
Jeremy Hylton's avatar
Jeremy Hylton committed
1605 1606
}

1607 1608 1609 1610 1611 1612 1613 1614 1615 1616
static int
symtable_visit_withitem(struct symtable *st, withitem_ty item)
{
    VISIT(st, expr, item->context_expr);
    if (item->optional_vars) {
        VISIT(st, expr, item->optional_vars);
    }
    return 1;
}

Jeremy Hylton's avatar
Jeremy Hylton committed
1617

1618
static int
Jeremy Hylton's avatar
Jeremy Hylton committed
1619 1620
symtable_visit_alias(struct symtable *st, alias_ty a)
{
1621
    /* Compute store_name, the name actually bound by the import
1622
       operation.  It is different than a->name when a->name is a
1623 1624 1625 1626
       dotted package name (e.g. spam.eggs)
    */
    PyObject *store_name;
    PyObject *name = (a->asname == NULL) ? a->name : a->asname;
Martin v. Löwis's avatar
Martin v. Löwis committed
1627 1628 1629 1630
    Py_ssize_t dot = PyUnicode_FindChar(name, '.', 0,
                                        PyUnicode_GET_LENGTH(name), 1);
    if (dot != -1) {
        store_name = PyUnicode_Substring(name, 0, dot);
1631 1632 1633 1634 1635 1636 1637
        if (!store_name)
            return 0;
    }
    else {
        store_name = name;
        Py_INCREF(store_name);
    }
1638
    if (!_PyUnicode_EqualToASCIIString(name, "*")) {
1639 1640 1641 1642 1643 1644
        int r = symtable_add_def(st, store_name, DEF_IMPORT);
        Py_DECREF(store_name);
        return r;
    }
    else {
        if (st->st_cur->ste_type != ModuleBlock) {
Benjamin Peterson's avatar
Benjamin Peterson committed
1645 1646 1647
            int lineno = st->st_cur->ste_lineno;
            int col_offset = st->st_cur->ste_col_offset;
            PyErr_SetString(PyExc_SyntaxError, IMPORT_STAR_WARNING);
1648
            PyErr_SyntaxLocationObject(st->st_filename, lineno, col_offset);
Benjamin Peterson's avatar
Benjamin Peterson committed
1649 1650
            Py_DECREF(store_name);
            return 0;
1651 1652 1653 1654
        }
        Py_DECREF(store_name);
        return 1;
    }
Jeremy Hylton's avatar
Jeremy Hylton committed
1655 1656 1657
}


1658
static int
Jeremy Hylton's avatar
Jeremy Hylton committed
1659 1660
symtable_visit_comprehension(struct symtable *st, comprehension_ty lc)
{
1661 1662 1663
    VISIT(st, expr, lc->target);
    VISIT(st, expr, lc->iter);
    VISIT_SEQ(st, expr, lc->ifs);
1664 1665 1666
    if (lc->is_async) {
        st->st_cur->ste_coroutine = 1;
    }
1667
    return 1;
Jeremy Hylton's avatar
Jeremy Hylton committed
1668 1669 1670
}


1671
static int
Jeremy Hylton's avatar
Jeremy Hylton committed
1672 1673
symtable_visit_keyword(struct symtable *st, keyword_ty k)
{
1674 1675
    VISIT(st, expr, k->value);
    return 1;
Jeremy Hylton's avatar
Jeremy Hylton committed
1676 1677 1678
}


1679
static int
Jeremy Hylton's avatar
Jeremy Hylton committed
1680 1681
symtable_visit_slice(struct symtable *st, slice_ty s)
{
1682 1683 1684 1685 1686 1687 1688 1689 1690 1691 1692 1693 1694 1695 1696 1697 1698
    switch (s->kind) {
    case Slice_kind:
        if (s->v.Slice.lower)
            VISIT(st, expr, s->v.Slice.lower)
        if (s->v.Slice.upper)
            VISIT(st, expr, s->v.Slice.upper)
        if (s->v.Slice.step)
            VISIT(st, expr, s->v.Slice.step)
        break;
    case ExtSlice_kind:
        VISIT_SEQ(st, slice, s->v.ExtSlice.dims)
        break;
    case Index_kind:
        VISIT(st, expr, s->v.Index.value)
        break;
    }
    return 1;
Jeremy Hylton's avatar
Jeremy Hylton committed
1699 1700
}

1701
static int
1702
symtable_handle_comprehension(struct symtable *st, expr_ty e,
1703 1704
                              identifier scope_name, asdl_seq *generators,
                              expr_ty elt, expr_ty value)
Jeremy Hylton's avatar
Jeremy Hylton committed
1705
{
1706 1707 1708 1709 1710 1711 1712
    int is_generator = (e->kind == GeneratorExp_kind);
    comprehension_ty outermost = ((comprehension_ty)
                                    asdl_seq_GET(generators, 0));
    /* Outermost iterator is evaluated in current scope */
    VISIT(st, expr, outermost->iter);
    /* Create comprehension scope for the rest */
    if (!scope_name ||
1713 1714
        !symtable_enter_block(st, scope_name, FunctionBlock, (void *)e,
                              e->lineno, e->col_offset)) {
1715 1716
        return 0;
    }
1717 1718 1719
    if (outermost->is_async) {
        st->st_cur->ste_coroutine = 1;
    }
1720 1721 1722 1723 1724
    /* Outermost iter is received as an argument */
    if (!symtable_implicit_arg(st, 0)) {
        symtable_exit_block(st, (void *)e);
        return 0;
    }
1725 1726 1727
    VISIT(st, expr, outermost->target);
    VISIT_SEQ(st, expr, outermost->ifs);
    VISIT_SEQ_TAIL(st, comprehension, generators, 1);
1728
    if (value)
1729 1730
        VISIT(st, expr, value);
    VISIT(st, expr, elt);
1731
    if (st->st_cur->ste_generator) {
1732
        PyErr_SetString(PyExc_SyntaxError,
1733 1734 1735 1736
            (e->kind == ListComp_kind) ? "'yield' inside list comprehension" :
            (e->kind == SetComp_kind) ? "'yield' inside set comprehension" :
            (e->kind == DictComp_kind) ? "'yield' inside dict comprehension" :
            "'yield' inside generator expression");
1737 1738 1739 1740 1741
        PyErr_SyntaxLocationObject(st->st_filename,
                                   st->st_cur->ste_lineno,
                                   st->st_cur->ste_col_offset);
        symtable_exit_block(st, (void *)e);
        return 0;
1742
    }
1743
    st->st_cur->ste_generator = is_generator;
1744
    return symtable_exit_block(st, (void *)e);
Jeremy Hylton's avatar
Jeremy Hylton committed
1745
}
1746

1747
static int
1748 1749
symtable_visit_genexp(struct symtable *st, expr_ty e)
{
1750 1751 1752
    return symtable_handle_comprehension(st, e, GET_IDENTIFIER(genexpr),
                                         e->v.GeneratorExp.generators,
                                         e->v.GeneratorExp.elt, NULL);
1753 1754
}

1755
static int
1756 1757
symtable_visit_listcomp(struct symtable *st, expr_ty e)
{
1758 1759 1760
    return symtable_handle_comprehension(st, e, GET_IDENTIFIER(listcomp),
                                         e->v.ListComp.generators,
                                         e->v.ListComp.elt, NULL);
1761 1762 1763 1764 1765
}

static int
symtable_visit_setcomp(struct symtable *st, expr_ty e)
{
1766 1767 1768
    return symtable_handle_comprehension(st, e, GET_IDENTIFIER(setcomp),
                                         e->v.SetComp.generators,
                                         e->v.SetComp.elt, NULL);
1769 1770 1771 1772 1773
}

static int
symtable_visit_dictcomp(struct symtable *st, expr_ty e)
{
1774 1775 1776 1777
    return symtable_handle_comprehension(st, e, GET_IDENTIFIER(dictcomp),
                                         e->v.DictComp.generators,
                                         e->v.DictComp.key,
                                         e->v.DictComp.value);
1778
}