fix_raise.py 2.49 KB
Newer Older
1 2 3 4 5 6 7 8 9 10 11 12 13 14
"""Fixer for 'raise E, V, T'

raise         -> raise
raise E       -> raise E
raise E, V    -> raise E(V)
raise E, V, T -> raise E(V).with_traceback(T)

raise (((E, E'), E''), E'''), V -> raise E(V)
raise "foo", V, T               -> warns about string exceptions


CAVEATS:
1) "raise E, V" will be incorrectly translated if V is an exception
   instance. The correct Python 3 idiom is
15

16
        raise E from V
17

18 19 20 21 22 23 24 25 26
   but since we can't detect instance-hood by syntax alone and since
   any client code would have to be changed as well, we don't automate
   this.
"""
# Author: Collin Winter

# Local imports
from .. import pytree
from ..pgen2 import token
27 28
from .. import fixer_base
from ..fixer_util import Name, Call, Attr, ArgList, is_tuple
29

30
class FixRaise(fixer_base.BaseFix):
31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50

    PATTERN = """
    raise_stmt< 'raise' exc=any [',' val=any [',' tb=any]] >
    """

    def transform(self, node, results):
        syms = self.syms

        exc = results["exc"].clone()
        if exc.type is token.STRING:
            self.cannot_convert(node, "Python 3 does not support string exceptions")
            return

        # Python 2 supports
        #  raise ((((E1, E2), E3), E4), E5), V
        # as a synonym for
        #  raise E1, V
        # Since Python 3 will not support this, we recurse down any tuple
        # literals, always taking the first element.
        if is_tuple(exc):
51 52 53 54
            while is_tuple(exc):
                # exc.children[1:-1] is the unparenthesized tuple
                # exc.children[1].children[0] is the first element of the tuple
                exc = exc.children[1].children[0].clone()
55
            exc.prefix = " "
56 57 58 59

        if "val" not in results:
            # One-argument raise
            new = pytree.Node(syms.raise_stmt, [Name("raise"), exc])
60
            new.prefix = node.prefix
61 62 63 64 65 66
            return new

        val = results["val"].clone()
        if is_tuple(val):
            args = [c.clone() for c in val.children[1:-1]]
        else:
67
            val.prefix = ""
68 69 70 71
            args = [val]

        if "tb" in results:
            tb = results["tb"].clone()
72
            tb.prefix = ""
73 74 75 76

            e = Call(exc, args)
            with_tb = Attr(e, Name('with_traceback')) + [ArgList([tb])]
            new = pytree.Node(syms.simple_stmt, [Name("raise")] + with_tb)
77
            new.prefix = node.prefix
78 79 80 81
            return new
        else:
            return pytree.Node(syms.raise_stmt,
                               [Name("raise"), Call(exc, args)],
82
                               prefix=node.prefix)