pystate.c 17 KB
Newer Older
1 2 3 4 5

/* Thread and interpreter state structures and their interfaces */

#include "Python.h"

6 7 8 9 10 11 12 13 14 15
/* --------------------------------------------------------------------------
CAUTION

Always use malloc() and free() directly in this file.  A number of these
functions are advertised as safe to call when the GIL isn't held, and in
a debug build Python redirects (e.g.) PyMem_NEW (etc) to Python's debugging
obmalloc functions.  Those aren't thread-safe (they rely on the GIL to avoid
the expense of doing their own locking).
-------------------------------------------------------------------------- */

16 17 18 19 20 21 22 23 24 25
#ifdef HAVE_DLOPEN
#ifdef HAVE_DLFCN_H
#include <dlfcn.h>
#endif
#ifndef RTLD_LAZY
#define RTLD_LAZY 1
#endif
#endif


Guido van Rossum's avatar
Guido van Rossum committed
26 27 28
#ifdef WITH_THREAD
#include "pythread.h"
static PyThread_type_lock head_mutex = NULL; /* Protects interp->tstate_head */
29
#define HEAD_INIT() (void)(head_mutex || (head_mutex = PyThread_allocate_lock()))
Guido van Rossum's avatar
Guido van Rossum committed
30 31
#define HEAD_LOCK() PyThread_acquire_lock(head_mutex, WAIT_LOCK)
#define HEAD_UNLOCK() PyThread_release_lock(head_mutex)
Michael W. Hudson's avatar
Michael W. Hudson committed
32

33 34 35 36
#ifdef __cplusplus
extern "C" {
#endif

Michael W. Hudson's avatar
Michael W. Hudson committed
37 38 39 40 41
/* The single PyInterpreterState used by this process'
   GILState implementation
*/
static PyInterpreterState *autoInterpreterState = NULL;
static int autoTLSkey = 0;
Guido van Rossum's avatar
Guido van Rossum committed
42 43 44 45 46 47
#else
#define HEAD_INIT() /* Nothing */
#define HEAD_LOCK() /* Nothing */
#define HEAD_UNLOCK() /* Nothing */
#endif

48
static PyInterpreterState *interp_head = NULL;
49

50
PyThreadState *_PyThreadState_Current = NULL;
51
PyThreadFrameGetter _PyThreadState_GetFrame = NULL;
52

Michael W. Hudson's avatar
Michael W. Hudson committed
53
#ifdef WITH_THREAD
Michael W. Hudson's avatar
Michael W. Hudson committed
54
static void _PyGILState_NoteThreadState(PyThreadState* tstate);
Michael W. Hudson's avatar
Michael W. Hudson committed
55
#endif
Michael W. Hudson's avatar
Michael W. Hudson committed
56

57 58

PyInterpreterState *
59
PyInterpreterState_New(void)
60
{
61 62
	PyInterpreterState *interp = (PyInterpreterState *)
				     malloc(sizeof(PyInterpreterState));
63

64
	if (interp != NULL) {
Guido van Rossum's avatar
Guido van Rossum committed
65
		HEAD_INIT();
66 67 68 69
#ifdef WITH_THREAD
		if (head_mutex == NULL)
			Py_FatalError("Can't initialize threads for interpreter");
#endif
70
		interp->modules = NULL;
71
		interp->modules_reloading = NULL;
72
		interp->sysdict = NULL;
73 74
		interp->builtins = NULL;
		interp->tstate_head = NULL;
75 76 77
		interp->codec_search_path = NULL;
		interp->codec_search_cache = NULL;
		interp->codec_error_registry = NULL;
78 79 80 81 82 83
#ifdef HAVE_DLOPEN
#ifdef RTLD_NOW
                interp->dlopenflags = RTLD_NOW;
#else
		interp->dlopenflags = RTLD_LAZY;
#endif
84 85 86
#endif
#ifdef WITH_TSC
		interp->tscdump = 0;
87
#endif
88

89
		HEAD_LOCK();
90 91
		interp->next = interp_head;
		interp_head = interp;
92
		HEAD_UNLOCK();
93
	}
94

95 96 97 98 99
	return interp;
}


void
100
PyInterpreterState_Clear(PyInterpreterState *interp)
101 102
{
	PyThreadState *p;
Guido van Rossum's avatar
Guido van Rossum committed
103
	HEAD_LOCK();
104 105
	for (p = interp->tstate_head; p != NULL; p = p->next)
		PyThreadState_Clear(p);
Guido van Rossum's avatar
Guido van Rossum committed
106
	HEAD_UNLOCK();
Martin v. Löwis's avatar
Martin v. Löwis committed
107 108 109 110
	Py_CLEAR(interp->codec_search_path);
	Py_CLEAR(interp->codec_search_cache);
	Py_CLEAR(interp->codec_error_registry);
	Py_CLEAR(interp->modules);
111
	Py_CLEAR(interp->modules_reloading);
Martin v. Löwis's avatar
Martin v. Löwis committed
112 113
	Py_CLEAR(interp->sysdict);
	Py_CLEAR(interp->builtins);
114 115 116 117
}


static void
118
zapthreads(PyInterpreterState *interp)
119
{
Guido van Rossum's avatar
Guido van Rossum committed
120 121 122 123
	PyThreadState *p;
	/* No need to lock the mutex here because this should only happen
	   when the threads are all really dead (XXX famous last words). */
	while ((p = interp->tstate_head) != NULL) {
124 125 126
		PyThreadState_Delete(p);
	}
}
127

128 129

void
130
PyInterpreterState_Delete(PyInterpreterState *interp)
131 132 133
{
	PyInterpreterState **p;
	zapthreads(interp);
134
	HEAD_LOCK();
135 136 137 138 139 140 141 142 143 144
	for (p = &interp_head; ; p = &(*p)->next) {
		if (*p == NULL)
			Py_FatalError(
				"PyInterpreterState_Delete: invalid interp");
		if (*p == interp)
			break;
	}
	if (interp->tstate_head != NULL)
		Py_FatalError("PyInterpreterState_Delete: remaining threads");
	*p = interp->next;
145
	HEAD_UNLOCK();
146
	free(interp);
147 148 149
}


150 151 152 153 154 155 156
/* Default implementation for _PyThreadState_GetFrame */
static struct _frame *
threadstate_getframe(PyThreadState *self)
{
	return self->frame;
}

157
PyThreadState *
158
PyThreadState_New(PyInterpreterState *interp)
159
{
160 161
	PyThreadState *tstate = (PyThreadState *)malloc(sizeof(PyThreadState));

162
	if (_PyThreadState_GetFrame == NULL)
163
		_PyThreadState_GetFrame = threadstate_getframe;
164

165
	if (tstate != NULL) {
166
		tstate->interp = interp;
167 168 169 170

		tstate->frame = NULL;
		tstate->recursion_depth = 0;
		tstate->tracing = 0;
171
		tstate->use_tracing = 0;
172
		tstate->tick_counter = 0;
173
		tstate->gilstate_counter = 0;
174
		tstate->async_exc = NULL;
175
#ifdef WITH_THREAD
176
		tstate->thread_id = PyThread_get_thread_ident();
177 178 179
#else
		tstate->thread_id = 0;
#endif
180

181 182
		tstate->dict = NULL;

183 184 185 186 187 188 189 190
		tstate->curexc_type = NULL;
		tstate->curexc_value = NULL;
		tstate->curexc_traceback = NULL;

		tstate->exc_type = NULL;
		tstate->exc_value = NULL;
		tstate->exc_traceback = NULL;

191 192 193 194
		tstate->c_profilefunc = NULL;
		tstate->c_tracefunc = NULL;
		tstate->c_profileobj = NULL;
		tstate->c_traceobj = NULL;
195

Michael W. Hudson's avatar
Michael W. Hudson committed
196
#ifdef WITH_THREAD
Michael W. Hudson's avatar
Michael W. Hudson committed
197
		_PyGILState_NoteThreadState(tstate);
Michael W. Hudson's avatar
Michael W. Hudson committed
198
#endif
Michael W. Hudson's avatar
Michael W. Hudson committed
199

Guido van Rossum's avatar
Guido van Rossum committed
200
		HEAD_LOCK();
201 202
		tstate->next = interp->tstate_head;
		interp->tstate_head = tstate;
Guido van Rossum's avatar
Guido van Rossum committed
203
		HEAD_UNLOCK();
204
	}
205

206 207 208 209 210
	return tstate;
}


void
211
PyThreadState_Clear(PyThreadState *tstate)
212
{
213
	if (Py_VerboseFlag && tstate->frame != NULL)
214
		fprintf(stderr,
215
		  "PyThreadState_Clear: warning: thread still has a frame\n");
216

Martin v. Löwis's avatar
Martin v. Löwis committed
217
	Py_CLEAR(tstate->frame);
218

Martin v. Löwis's avatar
Martin v. Löwis committed
219 220
	Py_CLEAR(tstate->dict);
	Py_CLEAR(tstate->async_exc);
221

Martin v. Löwis's avatar
Martin v. Löwis committed
222 223 224
	Py_CLEAR(tstate->curexc_type);
	Py_CLEAR(tstate->curexc_value);
	Py_CLEAR(tstate->curexc_traceback);
225

Martin v. Löwis's avatar
Martin v. Löwis committed
226 227 228
	Py_CLEAR(tstate->exc_type);
	Py_CLEAR(tstate->exc_value);
	Py_CLEAR(tstate->exc_traceback);
229

230 231
	tstate->c_profilefunc = NULL;
	tstate->c_tracefunc = NULL;
Martin v. Löwis's avatar
Martin v. Löwis committed
232 233
	Py_CLEAR(tstate->c_profileobj);
	Py_CLEAR(tstate->c_traceobj);
234
}
235 236


237 238 239
/* Common code for PyThreadState_Delete() and PyThreadState_DeleteCurrent() */
static void
tstate_delete_common(PyThreadState *tstate)
240 241 242
{
	PyInterpreterState *interp;
	PyThreadState **p;
243
	PyThreadState *prev_p = NULL;
244 245 246 247 248
	if (tstate == NULL)
		Py_FatalError("PyThreadState_Delete: NULL tstate");
	interp = tstate->interp;
	if (interp == NULL)
		Py_FatalError("PyThreadState_Delete: NULL interp");
Guido van Rossum's avatar
Guido van Rossum committed
249
	HEAD_LOCK();
250 251 252 253 254 255
	for (p = &interp->tstate_head; ; p = &(*p)->next) {
		if (*p == NULL)
			Py_FatalError(
				"PyThreadState_Delete: invalid tstate");
		if (*p == tstate)
			break;
256 257 258 259 260 261 262 263 264
		if (*p == prev_p)
			Py_FatalError(
				"PyThreadState_Delete: small circular list(!)"
                                " and tstate not found.");
		prev_p = *p;
		if ((*p)->next == interp->tstate_head)
			Py_FatalError(
				"PyThreadState_Delete: circular list(!) and"
                                " tstate not found.");
265 266
	}
	*p = tstate->next;
Guido van Rossum's avatar
Guido van Rossum committed
267
	HEAD_UNLOCK();
268
	free(tstate);
269 270 271
}


272 273 274 275 276 277
void
PyThreadState_Delete(PyThreadState *tstate)
{
	if (tstate == _PyThreadState_Current)
		Py_FatalError("PyThreadState_Delete: tstate is still current");
	tstate_delete_common(tstate);
278 279 280 281
#ifdef WITH_THREAD
	if (autoTLSkey && PyThread_get_key_value(autoTLSkey) == tstate)
		PyThread_delete_key_value(autoTLSkey);
#endif /* WITH_THREAD */
282 283 284 285 286 287 288 289 290 291 292 293 294
}


#ifdef WITH_THREAD
void
PyThreadState_DeleteCurrent()
{
	PyThreadState *tstate = _PyThreadState_Current;
	if (tstate == NULL)
		Py_FatalError(
			"PyThreadState_DeleteCurrent: no current tstate");
	_PyThreadState_Current = NULL;
	tstate_delete_common(tstate);
Michael W. Hudson's avatar
Michael W. Hudson committed
295 296
	if (autoTLSkey && PyThread_get_key_value(autoTLSkey) == tstate)
		PyThread_delete_key_value(autoTLSkey);
297 298 299 300 301
	PyEval_ReleaseLock();
}
#endif /* WITH_THREAD */


302
PyThreadState *
303
PyThreadState_Get(void)
304
{
305
	if (_PyThreadState_Current == NULL)
306 307
		Py_FatalError("PyThreadState_Get: no current thread");

308
	return _PyThreadState_Current;
309 310 311 312
}


PyThreadState *
313
PyThreadState_Swap(PyThreadState *newts)
314
{
315
	PyThreadState *oldts = _PyThreadState_Current;
316

317
	_PyThreadState_Current = newts;
318
	/* It should not be possible for more than one thread state
Tim Peters's avatar
Tim Peters committed
319
	   to be used for a thread.  Check this the best we can in debug
320 321
	   builds.
	*/
322
#if defined(Py_DEBUG) && defined(WITH_THREAD)
323
	if (newts) {
324 325 326 327
		/* This can be called from PyEval_RestoreThread(). Similar
		   to it, we need to ensure errno doesn't change.
		*/
		int err = errno;
328
		PyThreadState *check = PyGILState_GetThisThreadState();
329
		if (check && check->interp == newts->interp && check != newts)
330
			Py_FatalError("Invalid thread state for this thread");
331
		errno = err;
332 333
	}
#endif
334
	return oldts;
335
}
336 337 338 339

/* An extension mechanism to store arbitrary additional per-thread state.
   PyThreadState_GetDict() returns a dictionary that can be used to hold such
   state; the caller should pick a unique key and store its state there.  If
340 341
   PyThreadState_GetDict() returns NULL, an exception has *not* been raised
   and the caller should assume no per-thread state is available. */
342 343

PyObject *
344
PyThreadState_GetDict(void)
345
{
346
	if (_PyThreadState_Current == NULL)
347
		return NULL;
348

349 350 351 352 353 354
	if (_PyThreadState_Current->dict == NULL) {
		PyObject *d;
		_PyThreadState_Current->dict = d = PyDict_New();
		if (d == NULL)
			PyErr_Clear();
	}
355
	return _PyThreadState_Current->dict;
356
}
357 358


359 360
/* Asynchronously raise an exception in a thread.
   Requested by Just van Rossum and Alex Martelli.
361
   To prevent naive misuse, you must write your own extension
Tim Peters's avatar
Tim Peters committed
362 363 364 365
   to call this, or use ctypes.  Must be called with the GIL held.
   Returns the number of tstates modified (normally 1, but 0 if `id` didn't
   match any known thread id).  Can be called with exc=NULL to clear an
   existing async exception.  This raises no exceptions. */
366 367 368

int
PyThreadState_SetAsyncExc(long id, PyObject *exc) {
369
	PyThreadState *tstate = PyThreadState_GET();
370 371
	PyInterpreterState *interp = tstate->interp;
	PyThreadState *p;
Tim Peters's avatar
Tim Peters committed
372 373 374 375 376 377 378

	/* Although the GIL is held, a few C API functions can be called
	 * without the GIL held, and in particular some that create and
	 * destroy thread and interpreter states.  Those can mutate the
	 * list of thread states we're traversing, so to prevent that we lock
	 * head_mutex for the duration.
	 */
379
	HEAD_LOCK();
380
	for (p = interp->tstate_head; p != NULL; p = p->next) {
Tim Peters's avatar
Tim Peters committed
381 382 383 384 385 386 387 388 389 390 391 392 393 394 395
		if (p->thread_id == id) {
			/* Tricky:  we need to decref the current value
			 * (if any) in p->async_exc, but that can in turn
			 * allow arbitrary Python code to run, including
			 * perhaps calls to this function.  To prevent
			 * deadlock, we need to release head_mutex before
			 * the decref.
			 */
			PyObject *old_exc = p->async_exc;
			Py_XINCREF(exc);
			p->async_exc = exc;
			HEAD_UNLOCK();
			Py_XDECREF(old_exc);
			return 1;
		}
396
	}
397
	HEAD_UNLOCK();
Tim Peters's avatar
Tim Peters committed
398
	return 0;
399 400 401
}


402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424
/* Routines for advanced debuggers, requested by David Beazley.
   Don't use unless you know what you are doing! */

PyInterpreterState *
PyInterpreterState_Head(void)
{
	return interp_head;
}

PyInterpreterState *
PyInterpreterState_Next(PyInterpreterState *interp) {
	return interp->next;
}

PyThreadState *
PyInterpreterState_ThreadHead(PyInterpreterState *interp) {
	return interp->tstate_head;
}

PyThreadState *
PyThreadState_Next(PyThreadState *tstate) {
	return tstate->next;
}
425

426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472
/* The implementation of sys._current_frames().  This is intended to be
   called with the GIL held, as it will be when called via
   sys._current_frames().  It's possible it would work fine even without
   the GIL held, but haven't thought enough about that.
*/
PyObject *
_PyThread_CurrentFrames(void)
{
	PyObject *result;
	PyInterpreterState *i;

	result = PyDict_New();
	if (result == NULL)
		return NULL;

	/* for i in all interpreters:
	 *     for t in all of i's thread states:
	 *          if t's frame isn't NULL, map t's id to its frame
	 * Because these lists can mutute even when the GIL is held, we
	 * need to grab head_mutex for the duration.
	 */
	HEAD_LOCK();
	for (i = interp_head; i != NULL; i = i->next) {
		PyThreadState *t;
		for (t = i->tstate_head; t != NULL; t = t->next) {
			PyObject *id;
			int stat;
			struct _frame *frame = t->frame;
			if (frame == NULL)
				continue;
			id = PyInt_FromLong(t->thread_id);
			if (id == NULL)
				goto Fail;
			stat = PyDict_SetItem(result, id, (PyObject *)frame);
			Py_DECREF(id);
			if (stat < 0)
				goto Fail;
		}
	}
	HEAD_UNLOCK();
	return result;

 Fail:
 	HEAD_UNLOCK();
 	Py_DECREF(result);
 	return NULL;
}
473

474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495
/* Python "auto thread state" API. */
#ifdef WITH_THREAD

/* Keep this as a static, as it is not reliable!  It can only
   ever be compared to the state for the *current* thread.
   * If not equal, then it doesn't matter that the actual
     value may change immediately after comparison, as it can't
     possibly change to the current thread's state.
   * If equal, then the current thread holds the lock, so the value can't
     change until we yield the lock.
*/
static int
PyThreadState_IsCurrent(PyThreadState *tstate)
{
	/* Must be the tstate for this thread */
	assert(PyGILState_GetThisThreadState()==tstate);
	/* On Windows at least, simple reads and writes to 32 bit values
	   are atomic.
	*/
	return tstate == _PyThreadState_Current;
}

Tim Peters's avatar
Tim Peters committed
496 497
/* Internal initialization/finalization functions called by
   Py_Initialize/Py_Finalize
498
*/
499 500
void
_PyGILState_Init(PyInterpreterState *i, PyThreadState *t)
501
{
502
	assert(i && t); /* must init with valid states */
503 504
	autoTLSkey = PyThread_create_key();
	autoInterpreterState = i;
505
	assert(PyThread_get_key_value(autoTLSkey) == NULL);
Michael W. Hudson's avatar
Michael W. Hudson committed
506 507 508
	assert(t->gilstate_counter == 0);

	_PyGILState_NoteThreadState(t);
509 510
}

511 512
void
_PyGILState_Fini(void)
513 514 515
{
	PyThread_delete_key(autoTLSkey);
	autoTLSkey = 0;
516
	autoInterpreterState = NULL;
517 518
}

Michael W. Hudson's avatar
Michael W. Hudson committed
519 520 521 522 523
/* When a thread state is created for a thread by some mechanism other than
   PyGILState_Ensure, it's important that the GILState machinery knows about
   it so it doesn't try to create another thread state for the thread (this is
   a better fix for SF bug #1010677 than the first one attempted).
*/
524
static void
Michael W. Hudson's avatar
Michael W. Hudson committed
525 526 527 528 529
_PyGILState_NoteThreadState(PyThreadState* tstate)
{
	/* If autoTLSkey is 0, this must be the very first threadstate created
	   in Py_Initialize().  Don't do anything for now (we'll be back here
	   when _PyGILState_Init is called). */
530
	if (!autoTLSkey)
Michael W. Hudson's avatar
Michael W. Hudson committed
531
		return;
532

Michael W. Hudson's avatar
Michael W. Hudson committed
533 534 535 536 537
	/* Stick the thread state for this thread in thread local storage.

	   The only situation where you can legitimately have more than one
	   thread state for an OS level thread is when there are multiple
	   interpreters, when:
538

Michael W. Hudson's avatar
Michael W. Hudson committed
539 540 541 542 543 544 545 546 547 548 549 550 551 552 553
	       a) You shouldn't really be using the PyGILState_ APIs anyway,
	          and:

	       b) The slightly odd way PyThread_set_key_value works (see
	          comments by its implementation) means that the first thread
	          state created for that given OS level thread will "win",
	          which seems reasonable behaviour.
	*/
	if (PyThread_set_key_value(autoTLSkey, (void *)tstate) < 0)
		Py_FatalError("Couldn't create autoTLSkey mapping");

	/* PyGILState_Release must not try to delete this thread state. */
	tstate->gilstate_counter = 1;
}

554
/* The public functions */
555 556
PyThreadState *
PyGILState_GetThisThreadState(void)
557
{
558
	if (autoInterpreterState == NULL || autoTLSkey == 0)
559
		return NULL;
560
	return (PyThreadState *)PyThread_get_key_value(autoTLSkey);
561 562
}

563 564
PyGILState_STATE
PyGILState_Ensure(void)
565 566 567
{
	int current;
	PyThreadState *tcur;
Tim Peters's avatar
Tim Peters committed
568 569
	/* Note that we do not auto-init Python here - apart from
	   potential races with 2 threads auto-initializing, pep-311
570 571 572 573
	   spells out other issues.  Embedders are expected to have
	   called Py_Initialize() and usually PyEval_InitThreads().
	*/
	assert(autoInterpreterState); /* Py_Initialize() hasn't been called! */
574
	tcur = (PyThreadState *)PyThread_get_key_value(autoTLSkey);
575
	if (tcur == NULL) {
576 577
		/* Create a new thread state for this thread */
		tcur = PyThreadState_New(autoInterpreterState);
578
		if (tcur == NULL)
579
			Py_FatalError("Couldn't create thread-state for new thread");
Michael W. Hudson's avatar
Michael W. Hudson committed
580 581 582
		/* This is our thread state!  We'll need to delete it in the
		   matching call to PyGILState_Release(). */
		tcur->gilstate_counter = 0;
583
		current = 0; /* new thread state is never current */
584 585
	}
	else
586
		current = PyThreadState_IsCurrent(tcur);
587
	if (current == 0)
588 589 590
		PyEval_RestoreThread(tcur);
	/* Update our counter in the thread-state - no need for locks:
	   - tcur will remain valid as we hold the GIL.
Tim Peters's avatar
Tim Peters committed
591
	   - the counter is safe as we are the only thread "allowed"
592 593
	     to modify this value
	*/
594
	++tcur->gilstate_counter;
595 596 597
	return current ? PyGILState_LOCKED : PyGILState_UNLOCKED;
}

598 599
void
PyGILState_Release(PyGILState_STATE oldstate)
600
{
601 602
	PyThreadState *tcur = (PyThreadState *)PyThread_get_key_value(
                                                                autoTLSkey);
603
	if (tcur == NULL)
604 605 606 607
		Py_FatalError("auto-releasing thread-state, "
		              "but no thread-state for this thread");
	/* We must hold the GIL and have our thread state current */
	/* XXX - remove the check - the assert should be fine,
Tim Peters's avatar
Tim Peters committed
608
	   but while this is very new (April 2003), the extra check
609 610
	   by release-only users can't hurt.
	*/
611
	if (! PyThreadState_IsCurrent(tcur))
612
		Py_FatalError("This thread state must be current when releasing");
613 614 615
	assert(PyThreadState_IsCurrent(tcur));
	--tcur->gilstate_counter;
	assert(tcur->gilstate_counter >= 0); /* illegal counter value */
616

617 618 619
	/* If we're going to destroy this thread-state, we must
	 * clear it while the GIL is held, as destructors may run.
	 */
620
	if (tcur->gilstate_counter == 0) {
621
		/* can't have been locked when we created it */
622
		assert(oldstate == PyGILState_UNLOCKED);
623
		PyThreadState_Clear(tcur);
624 625 626 627 628 629
		/* Delete the thread-state.  Note this releases the GIL too!
		 * It's vital that the GIL be held here, to avoid shutdown
		 * races; see bugs 225673 and 1061968 (that nasty bug has a
		 * habit of coming back).
		 */
		PyThreadState_DeleteCurrent();
630 631
	}
	/* Release the lock if necessary */
632
	else if (oldstate == PyGILState_UNLOCKED)
Michael W. Hudson's avatar
Michael W. Hudson committed
633
		PyEval_SaveThread();
634
}
635 636 637 638 639

#ifdef __cplusplus
}
#endif

640
#endif /* WITH_THREAD */
641 642