• Guido van Rossum's avatar
    Restructure comparison dramatically. There is no longer a default · 47b9ff6b
    Guido van Rossum yazdı
    *ordering* between objects; there is only a default equality test
    (defined by an object being equal to itself only).  Read the comment
    in object.c.  The current implementation never uses a three-way
    comparison to compute a rich comparison, but it does use a rich
    comparison to compute a three-way comparison.  I'm not quite done
    ripping out all the calls to PyObject_Compare/Cmp, or replacing
    tp_compare implementations with tp_richcompare implementations;
    but much of that has happened (to make most unit tests pass).
    
    The following tests still fail, because I need help deciding
    or understanding:
    
    test_codeop -- depends on comparing code objects
    test_datetime -- need Tim Peters' opinion
    test_marshal -- depends on comparing code objects
    test_mutants -- need help understanding it
    
    The problem with test_codeop and test_marshal is this: these tests
    compare two different code objects and expect them to be equal.
    Is that still a feature we'd like to support?  I've temporarily
    removed the comparison and hash code from code objects, so they
    use the default (equality by pointer only) comparison.
    
    For the other two tests, run them to see for yourself.
    (There may be more failing test with "-u all".)
    
    A general problem with getting lots of these tests to pass is
    the reality that for object types that have a natural total ordering,
    implementing __cmp__ is much more convenient than implementing
    __eq__, __ne__, __lt__, and so on.  Should we go back to allowing
    __cmp__ to provide a total ordering?  Should we provide some other
    way to implement rich comparison with a single method override?
    Alex proposed a __key__() method; I've considered a __richcmp__()
    method.  Or perhaps __cmp__() just shouldn't be killed off...
    47b9ff6b
classobject.c 11.1 KB