• Tim Peters's avatar
    PyInterpreterState_New is not thread-safe, and the recent fix to _PyPclose · 412f2460
    Tim Peters yazdı
    can cause it to get called by multiple threads simultaneously.
    
    Ditto for PyInterpreterState_Delete.
    
    Of the former, the docs say "The interpreter lock need not be held, but may
    be held if it is necessary to serialize calls to this function".  This
    kinda implies it both is and isn't thread-safe.
    
    Of the latter, the docs merely say "The interpreter lock need not be
    held.", and the clause about serializing is absent.
    
    I expect it was *believed* these are both thread-safe, and the bit about
    serializing via the global lock was meant as a permission rather than a
    caution.
    
    I also expect we've never seen a problem here because the Python core
    (prior to the _PyPclose fix) only calls these functions once per run.
    The Py_NewInterpreter subsystem exposed by the C API (but not used by
    Python itself) also calls them, but that subsystem appears to be very
    rarely used.
    
    Whatever, they're both thread-safe now.
    412f2460
pystate.c 4.73 KB