• Tim Peters's avatar
    SF bug 840829: weakref callbacks and gc corrupt memory. · add09b41
    Tim Peters yazdı
    subtype_dealloc():  This left the dying object exposed to gc, so that
    if cyclic gc triggered during the weakref callback, gc tried to delete
    the dying object a second time.  That's a disaster.  subtype_dealloc()
    had a (I hope!) unique problem here, as every normal dealloc routine
    untracks the object (from gc) before fiddling with weakrefs etc.  But
    subtype_dealloc has obscure technical reasons for re-registering the
    dying object with gc (already explained in a large comment block at
    the bottom of the function).
    
    The fix amounts to simply refraining from reregistering the dying object
    with gc until after the weakref callback (if any) has been called.
    
    This is a critical bug (hard to predict, and causes seemingly random
    memory corruption when it occurs).  I'll backport it to 2.3 later.
    add09b41
typeobject.c 145 KB