• Nathaniel J. Smith's avatar
    bpo-32591: fix abort in _PyErr_WarnUnawaitedCoroutine during shutdown (#5337) · dba976b8
    Nathaniel J. Smith yazdı
    When an unawaited coroutine is collected very late in shutdown --
    like, during the final GC at the end of PyImport_Cleanup -- then it
    was triggering an interpreter abort, because we'd try to look up the
    "warnings" module and not only was it missing (we were prepared for
    that), but the entire module system was missing (which we were not
    prepared for).
    
    I've tried to fix this at the source, by making the utility function
    get_warnings_attr robust against this in general. Note that it already
    has the convention that it can return NULL without setting an error,
    which is how it signals that the attribute it was asked to fetch is
    missing, and that all callers already check for NULL returns.
    
    There's a similar check for being late in shutdown at the top of
    warn_explicit, which might be unnecessary after this fix, but I'm not
    sure so I'm going to leave it.
    dba976b8
_warnings.c 37.1 KB