Kaydet (Commit) 0dceb918 authored tarafından Raymond Hettinger's avatar Raymond Hettinger

Tests versus zero are more compact than tests versus -1.

üst 1ce6885f
...@@ -248,7 +248,7 @@ ins1(PyListObject *self, Py_ssize_t where, PyObject *v) ...@@ -248,7 +248,7 @@ ins1(PyListObject *self, Py_ssize_t where, PyObject *v)
return -1; return -1;
} }
if (list_resize(self, n+1) == -1) if (list_resize(self, n+1) < 0)
return -1; return -1;
if (where < 0) { if (where < 0) {
...@@ -288,7 +288,7 @@ app1(PyListObject *self, PyObject *v) ...@@ -288,7 +288,7 @@ app1(PyListObject *self, PyObject *v)
return -1; return -1;
} }
if (list_resize(self, n+1) == -1) if (list_resize(self, n+1) < 0)
return -1; return -1;
Py_INCREF(v); Py_INCREF(v);
...@@ -708,7 +708,7 @@ list_inplace_repeat(PyListObject *self, Py_ssize_t n) ...@@ -708,7 +708,7 @@ list_inplace_repeat(PyListObject *self, Py_ssize_t n)
return PyErr_NoMemory(); return PyErr_NoMemory();
} }
if (list_resize(self, size*n) == -1) if (list_resize(self, size*n) < 0)
return NULL; return NULL;
p = size; p = size;
...@@ -798,7 +798,7 @@ listextend(PyListObject *self, PyObject *b) ...@@ -798,7 +798,7 @@ listextend(PyListObject *self, PyObject *b)
Py_RETURN_NONE; Py_RETURN_NONE;
} }
m = Py_SIZE(self); m = Py_SIZE(self);
if (list_resize(self, m + n) == -1) { if (list_resize(self, m + n) < 0) {
Py_DECREF(b); Py_DECREF(b);
return NULL; return NULL;
} }
...@@ -826,7 +826,7 @@ listextend(PyListObject *self, PyObject *b) ...@@ -826,7 +826,7 @@ listextend(PyListObject *self, PyObject *b)
/* Guess a result list size. */ /* Guess a result list size. */
n = PyObject_LengthHint(b, 8); n = PyObject_LengthHint(b, 8);
if (n == -1) { if (n < 0) {
Py_DECREF(it); Py_DECREF(it);
return NULL; return NULL;
} }
...@@ -834,7 +834,7 @@ listextend(PyListObject *self, PyObject *b) ...@@ -834,7 +834,7 @@ listextend(PyListObject *self, PyObject *b)
mn = m + n; mn = m + n;
if (mn >= m) { if (mn >= m) {
/* Make room. */ /* Make room. */
if (list_resize(self, mn) == -1) if (list_resize(self, mn) < 0)
goto error; goto error;
/* Make the list sane again. */ /* Make the list sane again. */
Py_SIZE(self) = m; Py_SIZE(self) = m;
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment