Kaydet (Commit) 1b01e5c7 authored tarafından Guido van Rossum's avatar Guido van Rossum

Fix some more has_key() uses. This could really use a tool to automate...

üst 5c303dec
...@@ -265,7 +265,7 @@ def SetPointerType(pointer, cls): ...@@ -265,7 +265,7 @@ def SetPointerType(pointer, cls):
if _pointer_type_cache.get(cls, None) is not None: if _pointer_type_cache.get(cls, None) is not None:
raise RuntimeError, \ raise RuntimeError, \
"This type already exists in the cache" "This type already exists in the cache"
if not _pointer_type_cache.has_key(id(pointer)): if id(pointer) not in _pointer_type_cache:
raise RuntimeError, \ raise RuntimeError, \
"What's this???" "What's this???"
pointer.set_type(cls) pointer.set_type(cls)
......
...@@ -57,7 +57,7 @@ def getDOMImplementation(name = None, features = ()): ...@@ -57,7 +57,7 @@ def getDOMImplementation(name = None, features = ()):
return mod.getDOMImplementation() return mod.getDOMImplementation()
elif name: elif name:
return registered[name]() return registered[name]()
elif os.environ.has_key("PYTHON_DOM"): elif "PYTHON_DOM" in os.environ:
return getDOMImplementation(name = os.environ["PYTHON_DOM"]) return getDOMImplementation(name = os.environ["PYTHON_DOM"])
# User did not specify a name, try implementations in arbitrary # User did not specify a name, try implementations in arbitrary
......
...@@ -243,7 +243,7 @@ class Node(xml.dom.Node): ...@@ -243,7 +243,7 @@ class Node(xml.dom.Node):
except AttributeError: except AttributeError:
d = {} d = {}
self._user_data = d self._user_data = d
if d.has_key(key): if key in d:
old = d[key][0] old = d[key][0]
if data is None: if data is None:
# ignore handlers passed for None # ignore handlers passed for None
...@@ -494,11 +494,11 @@ class NamedNodeMap(object): ...@@ -494,11 +494,11 @@ class NamedNodeMap(object):
L.append(((node.namespaceURI, node.localName), node.value)) L.append(((node.namespaceURI, node.localName), node.value))
return L return L
def has_key(self, key): def __contains__(self, key):
if isinstance(key, StringTypes): if isinstance(key, StringTypes):
return self._attrs.has_key(key) return key in self._attrs
else: else:
return self._attrsNS.has_key(key) return key in self._attrsNS
def keys(self): def keys(self):
return self._attrs.keys() return self._attrs.keys()
...@@ -560,7 +560,7 @@ class NamedNodeMap(object): ...@@ -560,7 +560,7 @@ class NamedNodeMap(object):
_clear_id_cache(self._ownerElement) _clear_id_cache(self._ownerElement)
del self._attrs[n.nodeName] del self._attrs[n.nodeName]
del self._attrsNS[(n.namespaceURI, n.localName)] del self._attrsNS[(n.namespaceURI, n.localName)]
if n.__dict__.has_key('ownerElement'): if 'ownerElement' in n.__dict__:
n.__dict__['ownerElement'] = None n.__dict__['ownerElement'] = None
return n return n
else: else:
...@@ -572,7 +572,7 @@ class NamedNodeMap(object): ...@@ -572,7 +572,7 @@ class NamedNodeMap(object):
_clear_id_cache(self._ownerElement) _clear_id_cache(self._ownerElement)
del self._attrsNS[(n.namespaceURI, n.localName)] del self._attrsNS[(n.namespaceURI, n.localName)]
del self._attrs[n.nodeName] del self._attrs[n.nodeName]
if n.__dict__.has_key('ownerElement'): if 'ownerElement' in n.__dict__:
n.__dict__['ownerElement'] = None n.__dict__['ownerElement'] = None
return n return n
else: else:
...@@ -779,10 +779,10 @@ class Element(Node): ...@@ -779,10 +779,10 @@ class Element(Node):
removeAttributeNodeNS = removeAttributeNode removeAttributeNodeNS = removeAttributeNode
def hasAttribute(self, name): def hasAttribute(self, name):
return self._attrs.has_key(name) return name in self._attrs
def hasAttributeNS(self, namespaceURI, localName): def hasAttributeNS(self, namespaceURI, localName):
return self._attrsNS.has_key((namespaceURI, localName)) return (namespaceURI, localName) in self._attrsNS
def getElementsByTagName(self, name): def getElementsByTagName(self, name):
return _get_elements_by_tagName_helper(self, name, NodeList()) return _get_elements_by_tagName_helper(self, name, NodeList())
...@@ -1660,7 +1660,7 @@ class Document(Node, DocumentLS): ...@@ -1660,7 +1660,7 @@ class Document(Node, DocumentLS):
return n return n
def getElementById(self, id): def getElementById(self, id):
if self._id_cache.has_key(id): if id in self._id_cache:
return self._id_cache[id] return self._id_cache[id]
if not (self._elem_info or self._magic_id_count): if not (self._elem_info or self._magic_id_count):
return None return None
......
...@@ -91,7 +91,7 @@ class DOMBuilder: ...@@ -91,7 +91,7 @@ class DOMBuilder:
def canSetFeature(self, name, state): def canSetFeature(self, name, state):
key = (_name_xform(name), state and 1 or 0) key = (_name_xform(name), state and 1 or 0)
return self._settings.has_key(key) return key in self._settings
# This dictionary maps from (feature,value) to a list of # This dictionary maps from (feature,value) to a list of
# (option,value) pairs that should be set on the Options object. # (option,value) pairs that should be set on the Options object.
...@@ -247,7 +247,7 @@ class DOMEntityResolver(object): ...@@ -247,7 +247,7 @@ class DOMEntityResolver(object):
def _guess_media_encoding(self, source): def _guess_media_encoding(self, source):
info = source.byteStream.info() info = source.byteStream.info()
if info.has_key("Content-Type"): if "Content-Type" in info:
for param in info.getplist(): for param in info.getplist():
if param.startswith("charset="): if param.startswith("charset="):
return param.split("=", 1)[1].lower() return param.split("=", 1)[1].lower()
......
...@@ -59,7 +59,7 @@ if _false: ...@@ -59,7 +59,7 @@ if _false:
import xml.sax.expatreader import xml.sax.expatreader
import os, sys import os, sys
if os.environ.has_key("PY_SAX_PARSER"): if "PY_SAX_PARSER" in os.environ:
default_parser_list = os.environ["PY_SAX_PARSER"].split(",") default_parser_list = os.environ["PY_SAX_PARSER"].split(",")
del os del os
...@@ -81,7 +81,7 @@ def make_parser(parser_list = []): ...@@ -81,7 +81,7 @@ def make_parser(parser_list = []):
return _create_parser(parser_name) return _create_parser(parser_name)
except ImportError,e: except ImportError,e:
import sys import sys
if sys.modules.has_key(parser_name): if parser_name in sys.modules:
# The parser module was found, but importing it # The parser module was found, but importing it
# failed unexpectedly, pass this exception through # failed unexpectedly, pass this exception through
raise raise
......
...@@ -294,12 +294,12 @@ class AttributesImpl: ...@@ -294,12 +294,12 @@ class AttributesImpl:
return self._attrs[name] return self._attrs[name]
def getNameByQName(self, name): def getNameByQName(self, name):
if not self._attrs.has_key(name): if name not in self._attrs:
raise KeyError, name raise KeyError, name
return name return name
def getQNameByName(self, name): def getQNameByName(self, name):
if not self._attrs.has_key(name): if name not in self._attrs:
raise KeyError, name raise KeyError, name
return name return name
...@@ -318,11 +318,8 @@ class AttributesImpl: ...@@ -318,11 +318,8 @@ class AttributesImpl:
def keys(self): def keys(self):
return self._attrs.keys() return self._attrs.keys()
def has_key(self, name):
return self._attrs.has_key(name)
def __contains__(self, name): def __contains__(self, name):
return self._attrs.has_key(name) return name in self._attrs
def get(self, name, alternative=None): def get(self, name, alternative=None):
return self._attrs.get(name, alternative) return self._attrs.get(name, alternative)
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment