Kaydet (Commit) 1ca8c19b authored tarafından Antoine Pitrou's avatar Antoine Pitrou

Replace a Lock with a better suited Event.

üst 5c322ece
...@@ -33,14 +33,14 @@ class TestServerThread(threading.Thread): ...@@ -33,14 +33,14 @@ class TestServerThread(threading.Thread):
threading.Thread.__init__(self) threading.Thread.__init__(self)
self.request_handler = request_handler self.request_handler = request_handler
self.test_object = test_object self.test_object = test_object
self.test_object.lock.acquire()
def run(self): def run(self):
self.server = HTTPServer(('', 0), self.request_handler) self.server = HTTPServer(('', 0), self.request_handler)
self.test_object.PORT = self.server.socket.getsockname()[1] self.test_object.PORT = self.server.socket.getsockname()[1]
self.test_object.lock.release() self.test_object.server_started.set()
self.test_object = None
try: try:
self.server.serve_forever() self.server.serve_forever(0.05)
finally: finally:
self.server.server_close() self.server.server_close()
...@@ -52,13 +52,12 @@ class BaseTestCase(unittest.TestCase): ...@@ -52,13 +52,12 @@ class BaseTestCase(unittest.TestCase):
def setUp(self): def setUp(self):
self._threads = test_support.threading_setup() self._threads = test_support.threading_setup()
os.environ = test_support.EnvironmentVarGuard() os.environ = test_support.EnvironmentVarGuard()
self.lock = threading.Lock() self.server_started = threading.Event()
self.thread = TestServerThread(self, self.request_handler) self.thread = TestServerThread(self, self.request_handler)
self.thread.start() self.thread.start()
self.lock.acquire() self.server_started.wait()
def tearDown(self): def tearDown(self):
self.lock.release()
self.thread.stop() self.thread.stop()
os.environ.__exit__() os.environ.__exit__()
test_support.threading_cleanup(*self._threads) test_support.threading_cleanup(*self._threads)
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment