Kaydet (Commit) 3a624042 authored tarafından Martin v. Löwis's avatar Martin v. Löwis

Correctly forward exception in instance_contains().

Fixes #1591996. Patch contributed by Neal Norwitz.
Will backport.
üst e452f51b
......@@ -172,6 +172,14 @@ testme ^ 1
# List/dict operations
class Empty: pass
try:
1 in Empty()
print 'failed, should have raised TypeError'
except TypeError:
pass
1 in testme
testme[1]
......
......@@ -1318,15 +1318,17 @@ instance_contains(PyInstanceObject *inst, PyObject *member)
/* Couldn't find __contains__. */
if (PyErr_ExceptionMatches(PyExc_AttributeError)) {
Py_ssize_t rc;
/* Assume the failure was simply due to that there is no
* __contains__ attribute, and try iterating instead.
*/
PyErr_Clear();
return _PySequence_IterSearch((PyObject *)inst, member,
PY_ITERSEARCH_CONTAINS) > 0;
rc = _PySequence_IterSearch((PyObject *)inst, member,
PY_ITERSEARCH_CONTAINS);
if (rc >= 0)
return rc > 0;
}
else
return -1;
return -1;
}
static PySequenceMethods
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment