Kaydet (Commit) 4e63d54b authored tarafından Gregory P. Smith's avatar Gregory P. Smith

Add weakref support to the thread.lock type.

üst 77db0165
...@@ -65,6 +65,9 @@ and regular expression pattern objects. ...@@ -65,6 +65,9 @@ and regular expression pattern objects.
.. versionchanged:: 2.4 .. versionchanged:: 2.4
Added support for files, sockets, arrays, and patterns. Added support for files, sockets, arrays, and patterns.
.. versionchanged:: 2.7
Added support for thread.lock and threading.Lock.
Several built-in types such as :class:`list` and :class:`dict` do not directly Several built-in types such as :class:`list` and :class:`dict` do not directly
support weak references but can add support through subclassing:: support weak references but can add support through subclassing::
......
...@@ -359,6 +359,8 @@ Core and Builtins ...@@ -359,6 +359,8 @@ Core and Builtins
Library Library
------- -------
- The thread.lock type now supports weak references.
- Issue #1356969: Add missing info methods in Tix.HList. - Issue #1356969: Add missing info methods in Tix.HList.
- Issue #1522587: New constants and methods for the Tix.Grid widget. - Issue #1522587: New constants and methods for the Tix.Grid widget.
......
...@@ -3,6 +3,7 @@ ...@@ -3,6 +3,7 @@
/* Interface to Sjoerd's portable C thread library */ /* Interface to Sjoerd's portable C thread library */
#include "Python.h" #include "Python.h"
#include "structmember.h" /* offsetof */
#ifndef WITH_THREAD #ifndef WITH_THREAD
#error "Error! The rest of Python is not compiled with thread support." #error "Error! The rest of Python is not compiled with thread support."
...@@ -20,12 +21,15 @@ static PyObject *ThreadError; ...@@ -20,12 +21,15 @@ static PyObject *ThreadError;
typedef struct { typedef struct {
PyObject_HEAD PyObject_HEAD
PyThread_type_lock lock_lock; PyThread_type_lock lock_lock;
PyObject *in_weakreflist;
} lockobject; } lockobject;
static void static void
lock_dealloc(lockobject *self) lock_dealloc(lockobject *self)
{ {
assert(self->lock_lock); assert(self->lock_lock);
if (self->in_weakreflist != NULL)
PyObject_ClearWeakRefs((PyObject *) self);
/* Unlock the lock so it's safe to free it */ /* Unlock the lock so it's safe to free it */
PyThread_acquire_lock(self->lock_lock, 0); PyThread_acquire_lock(self->lock_lock, 0);
PyThread_release_lock(self->lock_lock); PyThread_release_lock(self->lock_lock);
...@@ -140,12 +144,12 @@ static PyTypeObject Locktype = { ...@@ -140,12 +144,12 @@ static PyTypeObject Locktype = {
0, /* tp_getattro */ 0, /* tp_getattro */
0, /* tp_setattro */ 0, /* tp_setattro */
0, /* tp_as_buffer */ 0, /* tp_as_buffer */
0, /* tp_flags */ Py_TPFLAGS_HAVE_WEAKREFS, /* tp_flags */
0, /* tp_doc */ 0, /* tp_doc */
0, /* tp_traverse */ 0, /* tp_traverse */
0, /* tp_clear */ 0, /* tp_clear */
0, /* tp_richcompare */ 0, /* tp_richcompare */
0, /* tp_weaklistoffset */ offsetof(lockobject, in_weakreflist), /* tp_weaklistoffset */
0, /* tp_iter */ 0, /* tp_iter */
0, /* tp_iternext */ 0, /* tp_iternext */
lock_methods, /* tp_methods */ lock_methods, /* tp_methods */
...@@ -159,6 +163,7 @@ newlockobject(void) ...@@ -159,6 +163,7 @@ newlockobject(void)
if (self == NULL) if (self == NULL)
return NULL; return NULL;
self->lock_lock = PyThread_allocate_lock(); self->lock_lock = PyThread_allocate_lock();
self->in_weakreflist = NULL;
if (self->lock_lock == NULL) { if (self->lock_lock == NULL) {
PyObject_Del(self); PyObject_Del(self);
self = NULL; self = NULL;
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment