Issue #17645: convert an assert() into a proper exception in _Py_Mangle().

55bff891 · Antoine Pitrou · e8f706ed · 55bff891
Kaydet (Commit) 55bff891 authored Nis 06, 2013 tarafından Antoine Pitrou
Hide whitespace changes
Inline Side-by-side

Showing with 5 additions and 2 deletions

compile.c Python/compile.c +5 -2

No files found.
--- a/Python/compile.c
+++ b/Python/compile.c
@@ -248,8 +248,11 @@ _Py_Mangle(PyObject *privateobj, PyObject *ident)
    }
    plen -= ipriv;
-    assert(1 <= PY_SSIZE_T_MAX - nlen);
+    if (plen + nlen >= PY_SSIZE_T_MAX - 1) {
-    assert(1 + nlen <= PY_SSIZE_T_MAX - plen);
+        PyErr_SetString(PyExc_OverflowError,
+                        "private identifier too large to be mangled");
+        return NULL;
+    }
    maxchar = PyUnicode_MAX_CHAR_VALUE(ident);
    if (PyUnicode_MAX_CHAR_VALUE(privateobj) > maxchar)