Kaydet (Commit) 58ae13c1 authored tarafından Greg Ward's avatar Greg Ward

Rename the parameter 'xp' in several methods to 'self', since that's

what it is.
üst 499b73e1
...@@ -94,7 +94,7 @@ static PyObject *OSSAudioError; ...@@ -94,7 +94,7 @@ static PyObject *OSSAudioError;
static oss_audio_t * static oss_audio_t *
newossobject(PyObject *arg) newossobject(PyObject *arg)
{ {
oss_audio_t *xp; oss_audio_t *self;
int fd, afmts, imode; int fd, afmts, imode;
char *basedev = NULL; char *basedev = NULL;
char *mode = NULL; char *mode = NULL;
...@@ -139,24 +139,24 @@ newossobject(PyObject *arg) ...@@ -139,24 +139,24 @@ newossobject(PyObject *arg)
return NULL; return NULL;
} }
/* Create and initialize the object */ /* Create and initialize the object */
if ((xp = PyObject_New(oss_audio_t, &OSSAudioType)) == NULL) { if ((self = PyObject_New(oss_audio_t, &OSSAudioType)) == NULL) {
close(fd); close(fd);
return NULL; return NULL;
} }
xp->fd = fd; self->fd = fd;
xp->mode = imode; self->mode = imode;
xp->icount = xp->ocount = 0; self->icount = self->ocount = 0;
xp->afmts = afmts; self->afmts = afmts;
return xp; return self;
} }
static void static void
oss_dealloc(oss_audio_t *xp) oss_dealloc(oss_audio_t *self)
{ {
/* if already closed, don't reclose it */ /* if already closed, don't reclose it */
if (xp->fd != -1) if (self->fd != -1)
close(xp->fd); close(self->fd);
PyObject_Del(xp); PyObject_Del(self);
} }
...@@ -169,7 +169,7 @@ newossmixerobject(PyObject *arg) ...@@ -169,7 +169,7 @@ newossmixerobject(PyObject *arg)
{ {
char *basedev = NULL, *mode = NULL; char *basedev = NULL, *mode = NULL;
int fd, imode; int fd, imode;
oss_mixer_t *xp; oss_mixer_t *self;
if (!PyArg_ParseTuple(arg, "|ss", &basedev, &mode)) { if (!PyArg_ParseTuple(arg, "|ss", &basedev, &mode)) {
return NULL; return NULL;
...@@ -197,23 +197,23 @@ newossmixerobject(PyObject *arg) ...@@ -197,23 +197,23 @@ newossmixerobject(PyObject *arg)
return NULL; return NULL;
} }
if ((xp = PyObject_New(oss_mixer_t, &OSSMixerType)) == NULL) { if ((self = PyObject_New(oss_mixer_t, &OSSMixerType)) == NULL) {
close(fd); close(fd);
return NULL; return NULL;
} }
xp->fd = fd; self->fd = fd;
return xp; return self;
} }
static void static void
oss_mixer_dealloc(oss_mixer_t *xp) oss_mixer_dealloc(oss_mixer_t *self)
{ {
/* if already closed, don't reclose it */ /* if already closed, don't reclose it */
if (xp->fd != -1) if (self->fd != -1)
close(xp->fd); close(self->fd);
PyObject_Del(xp); PyObject_Del(self);
} }
...@@ -830,15 +830,15 @@ static PyMethodDef oss_mixer_methods[] = { ...@@ -830,15 +830,15 @@ static PyMethodDef oss_mixer_methods[] = {
}; };
static PyObject * static PyObject *
oss_getattr(oss_audio_t *xp, char *name) oss_getattr(oss_audio_t *self, char *name)
{ {
return Py_FindMethod(oss_methods, (PyObject *)xp, name); return Py_FindMethod(oss_methods, (PyObject *)self, name);
} }
static PyObject * static PyObject *
oss_mixer_getattr(oss_mixer_t *xp, char *name) oss_mixer_getattr(oss_mixer_t *self, char *name)
{ {
return Py_FindMethod(oss_mixer_methods, (PyObject *)xp, name); return Py_FindMethod(oss_mixer_methods, (PyObject *)self, name);
} }
static PyTypeObject OSSAudioType = { static PyTypeObject OSSAudioType = {
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment