Kaydet (Commit) 5a29dd30 authored tarafından Neal Norwitz's avatar Neal Norwitz

Fix Coverity #159.

This code was broken if save() returned a negative number since i contained
a boolean value and then we compared i < 0 which should never be true.

Will backport (assuming it's necessary)
üst 3adac217
...@@ -2249,7 +2249,7 @@ save_reduce(Picklerobject *self, PyObject *args, PyObject *ob) ...@@ -2249,7 +2249,7 @@ save_reduce(Picklerobject *self, PyObject *args, PyObject *ob)
Py_INCREF(temp); Py_INCREF(temp);
PyTuple_SET_ITEM(newargtup, i-1, temp); PyTuple_SET_ITEM(newargtup, i-1, temp);
} }
i = save(self, newargtup, 0) < 0; i = save(self, newargtup, 0);
Py_DECREF(newargtup); Py_DECREF(newargtup);
if (i < 0) if (i < 0)
return -1; return -1;
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment