Kaydet (Commit) 6063e261 authored tarafından Tim Peters's avatar Tim Peters

PyList_Reverse(): This was leaking a reference to Py_None on every call.

I believe I introduced this bug when I refactored the reversal code so
that the mergesort could use it too.  It's not a problem on the 2.2 branch.
üst 443fec3d
...@@ -1718,11 +1718,14 @@ listreverse(PyListObject *self) ...@@ -1718,11 +1718,14 @@ listreverse(PyListObject *self)
int int
PyList_Reverse(PyObject *v) PyList_Reverse(PyObject *v)
{ {
PyListObject *self = (PyListObject *)v;
if (v == NULL || !PyList_Check(v)) { if (v == NULL || !PyList_Check(v)) {
PyErr_BadInternalCall(); PyErr_BadInternalCall();
return -1; return -1;
} }
listreverse((PyListObject *)v); if (self->ob_size > 1)
reverse_slice(self->ob_item, self->ob_item + self->ob_size);
return 0; return 0;
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment